[jira] [Commented] (SOLR-14901) TestPackages uses binary precompiled classes to refer to analysis factory FQCNs

["Dawid Weiss (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203181#comment-17203181 ] 

Dawid Weiss commented on SOLR-14901:
------------------------------------

I looked at fixing this test but I don't know how. These binary classes in schema-plugins.jar.bin don't have any equivalent in the source code:
{code}
MyPatternReplaceCharFilterFactory.class
MyTextField.class
MyWhitespaceAnalyzer.class
MyWhitespaceTokenizerFactory.class
{code}

The entire JAR is also signed... [~noble.paul] can you regenerate these files after core classes have been repackaged? I don't think binary artifacts are great in this test - they should be generated dynamically - but it's way beyond my knowledge of this API to fix this test.

> TestPackages uses binary precompiled classes to refer to analysis factory FQCNs
> -------------------------------------------------------------------------------
>
>                 Key: SOLR-14901
>                 URL: https://issues.apache.org/jira/browse/SOLR-14901
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: master (9.0)
>            Reporter: Tomoko Uchida
>            Assignee: Dawid Weiss
>            Priority: Minor
>
> Base analysis factories' package name were renamed in [LUCENE-9317]. {{o.a.s.pkg.TestPackages}} is failing since it has hard coded their old FQCNs, that needs to be fixed.
> See https://github.com/apache/lucene-solr/pull/1836 for details.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org