You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/14 10:47:47 UTC

[GitHub] [pulsar] vagetablechicken opened a new pull request, #15174: [fix] Set sinkType in config file

vagetablechicken opened a new pull request, #15174:
URL: https://github.com/apache/pulsar/pull/15174

   
   *(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
   
   Fixes #12503
   
   ### Motivation
   
   The sink config file doesn't support set 'sinkType', e.g. https://github.com/apache/pulsar/blob/a19a30a5e89bfd2c2da5460db6120c8e0a48d8f7/site2/docs/io-jdbc-sink.md?plain=1#L51
   
   ### Modifications
   
   Add 'sinkType' to class `SinkConfig`. If no cmd arg '--sink-type' and 'sinkType' exists in config file, we will try to use the 'sinkType' built-in sink.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   
   This change added tests and can be verified as follows:
   - *Add tests for setting sink type in config file*
   
   ### Does this pull request potentially affect one of the following parts:
   
   Nope
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [ x ] `no-need-doc` 
   Just fix.
     
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-added`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] RobertIndie merged pull request #15174: [fix] Set sinkType in config file

Posted by GitBox <gi...@apache.org>.
RobertIndie merged PR #15174:
URL: https://github.com/apache/pulsar/pull/15174


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org