You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2019/03/13 03:33:45 UTC

[GitHub] [incubator-dubbo] codecov-io commented on issue #3642: [No issue] Fix: @Method default value will be set to the field of MethodConfig

# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3642?src=pr&el=h1) Report
> Merging [#3642](https://codecov.io/gh/apache/incubator-dubbo/pull/3642?src=pr&el=desc) into [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/8683da7231282ff8ab540e29752b46b1183cda6a?src=pr&el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `50%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3642/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3642?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##              2.6.x   #3642      +/-   ##
===========================================
- Coverage     47.09%     47%   -0.09%     
+ Complexity     4570    4386     -184     
===========================================
  Files           576     565      -11     
  Lines         26411   25119    -1292     
  Branches       4655    4430     -225     
===========================================
- Hits          12437   11806     -631     
+ Misses        12074   11481     -593     
+ Partials       1900    1832      -68
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3642?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...in/java/com/alibaba/dubbo/config/MethodConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3642/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvTWV0aG9kQ29uZmlnLmphdmE=) | `90.41% <50%> (-3.88%)` | `35 <0> (ø)` | |
| [.../remoting/transport/netty4/NettyServerHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3642/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L25ldHR5NC9OZXR0eVNlcnZlckhhbmRsZXIuamF2YQ==) | `72.22% <0%> (-11.12%)` | `6% <0%> (-1%)` | |
| [...ba/dubbo/remoting/transport/netty/NettyClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3642/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDbGllbnQuamF2YQ==) | `74.13% <0%> (-8.63%)` | `12% <0%> (-1%)` | |
| [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3642/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `83.33% <0%> (-5.56%)` | `6% <0%> (-1%)` | |
| [...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3642/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=) | `61.25% <0%> (-5%)` | `20% <0%> (-1%)` | |
| [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3642/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh) | `54.21% <0%> (-3.62%)` | `13% <0%> (-2%)` | |
| [...ba/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3642/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlTZXJ2ZXIuamF2YQ==) | `67.85% <0%> (-3.58%)` | `8% <0%> (-1%)` | |
| [...baba/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3642/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDbGllbnQuamF2YQ==) | `57.81% <0%> (-1.57%)` | `8% <0%> (-1%)` | |
| [...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3642/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==) | `53.12% <0%> (-1.57%)` | `3% <0%> (ø)` | |
| [.../java/com/alibaba/dubbo/common/json/JSONArray.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3642/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2pzb24vSlNPTkFycmF5LmphdmE=) | | | |
| ... and [10 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3642/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3642?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3642?src=pr&el=footer). Last update [8683da7...21e3e7c](https://codecov.io/gh/apache/incubator-dubbo/pull/3642?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3642 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org