You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/22 15:00:09 UTC
[GitHub] [incubator-superset] mistercrunch opened a new pull request #10394: style: use tabs in dashboard edit pane
mistercrunch opened a new pull request #10394:
URL: https://github.com/apache/incubator-superset/pull/10394
# DRAFT!
<img width="549" alt="Screen Shot 2020-07-22 at 7 59 34 AM" src="https://user-images.githubusercontent.com/487433/88192386-51505f00-cbf1-11ea-9fd6-5235fc431ab1.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10394: style: use tabs in dashboard edit pane
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #10394:
URL: https://github.com/apache/incubator-superset/pull/10394#discussion_r461336059
##########
File path: superset-frontend/src/dashboard/components/AddSliceCard.jsx
##########
@@ -62,9 +66,7 @@ function AddSliceCard({
</div>
<div className="item">
<span>{t('Data source')} </span>
- <span // eslint-disable-next-line react/no-danger
- dangerouslySetInnerHTML={{ __html: datasourceLink }}
- />
+ <a href={datasourceUrl}>{datasourceName}</a>
Review comment:
Bycatch - moving away from `dangerouslySetInnerHTML `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #10394: style: use tabs in dashboard edit pane
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #10394:
URL: https://github.com/apache/incubator-superset/pull/10394#issuecomment-664149974
Never even noticed the "Colors" setting. Agreed this is weird.
I use the Charts panel a lot. Sometimes you want to relayout the dashboard and it's easier to delete a chart first then re-add it later. Wondering if we can just keep the "Insert Components" panel as is and move "Set Color Scheme" to a modal triggered by a link in the dropdown menu?
Or we can change "Edit CSS" to "Change Appearance" and move color scheme selector to the Edit CSS modal. The same modal may even hold a "Select Theme" control in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] Steejay commented on pull request #10394: style: use tabs in dashboard edit pane
Posted by GitBox <gi...@apache.org>.
Steejay commented on pull request #10394:
URL: https://github.com/apache/incubator-superset/pull/10394#issuecomment-662611331
@mistercrunch wondering if we should change order to charts>components>colors? Charts are the main element of a dashboard.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #10394: style: use tabs in dashboard edit pane
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #10394:
URL: https://github.com/apache/incubator-superset/pull/10394#issuecomment-665359783
Makes sense. I can see why it'd be useful to have the tabs.
Here's another screenshot of SIP-34 design with proper tab titles and icons:
<img src="https://user-images.githubusercontent.com/335541/88742144-4a948100-d0f6-11ea-8bcd-15fe64481050.png" width="500">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on pull request #10394: style: use tabs in dashboard edit pane
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #10394:
URL: https://github.com/apache/incubator-superset/pull/10394#issuecomment-662706155
I have not usage data to back this up, but for me I always "Save and add to dashboard" from explore and almost never use the chart panel in the "dashboard editor"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #10394: style: use tabs in dashboard edit pane
Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #10394:
URL: https://github.com/apache/incubator-superset/pull/10394
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on pull request #10394: style: use tabs in dashboard edit pane
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #10394:
URL: https://github.com/apache/incubator-superset/pull/10394#issuecomment-665355491
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org