You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "benj-n (via GitHub)" <gi...@apache.org> on 2023/05/25 01:58:37 UTC
[GitHub] [cloudstack] benj-n opened a new pull request, #7559: Create user 'cloud' in cloudstack-usage postinstall
benj-n opened a new pull request, #7559:
URL: https://github.com/apache/cloudstack/pull/7559
### Description
This PR creates user 'cloud' in cloudstack-usage postinstall script. This ensures the chown 'cloud:cloud' command (later in the same file) is always performed with no error.
Fixes: #7507
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [X] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7559: Create user 'cloud' in cloudstack-usage postinstall
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7559:
URL: https://github.com/apache/cloudstack/pull/7559#issuecomment-1564079266
<b>[LL] Trillian Build Failed (tid-6548)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7559: Create user 'cloud' in cloudstack-usage postinstall
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7559:
URL: https://github.com/apache/cloudstack/pull/7559#issuecomment-1563956169
<b>[SF] Trillian Build Failed (tid-6593)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7559: Create user 'cloud' in cloudstack-usage postinstall
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7559:
URL: https://github.com/apache/cloudstack/pull/7559#issuecomment-1562810833
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7559?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#7559](https://app.codecov.io/gh/apache/cloudstack/pull/7559?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (faa744b) into [4.18](https://app.codecov.io/gh/apache/cloudstack/commit/5e71cea2c59217c92e8f271b315c8fd78136e89d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5e71cea) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 4.18 #7559 +/- ##
=========================================
Coverage 12.93% 12.93%
- Complexity 8949 8950 +1
=========================================
Files 2716 2716
Lines 256144 256144
Branches 39947 39947
=========================================
+ Hits 33141 33142 +1
+ Misses 218842 218840 -2
- Partials 4161 4162 +1
```
[see 1 file with indirect coverage changes](https://app.codecov.io/gh/apache/cloudstack/pull/7559/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7559: Create user 'cloud' in cloudstack-usage postinstall
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7559:
URL: https://github.com/apache/cloudstack/pull/7559#issuecomment-1562506971
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #7559: Create user 'cloud' in cloudstack-usage postinstall
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #7559:
URL: https://github.com/apache/cloudstack/pull/7559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7559: Create user 'cloud' in cloudstack-usage postinstall
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7559:
URL: https://github.com/apache/cloudstack/pull/7559#issuecomment-1563954079
@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7559: Create user 'cloud' in cloudstack-usage postinstall
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7559:
URL: https://github.com/apache/cloudstack/pull/7559#issuecomment-1562414024
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] benj-n commented on pull request #7559: Create user 'cloud' in cloudstack-usage postinstall
Posted by "benj-n (via GitHub)" <gi...@apache.org>.
benj-n commented on PR #7559:
URL: https://github.com/apache/cloudstack/pull/7559#issuecomment-1562153111
This PR supersedes https://github.com/apache/cloudstack/pull/7535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7559: Create user 'cloud' in cloudstack-usage postinstall
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7559:
URL: https://github.com/apache/cloudstack/pull/7559#issuecomment-1564069967
<b>[SF] Trillian Build Failed (tid-6596)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7559: Create user 'cloud' in cloudstack-usage postinstall
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7559:
URL: https://github.com/apache/cloudstack/pull/7559#issuecomment-1565014929
<b>[LL]Trillian test result (tid-6550)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45809 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7559-t6550-kvm-centos7.zip
Smoke tests completed. 105 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 323.56 | test_privategw_acl.py
test_04_rvpc_network_garbage_collector_nics | `Failure` | 319.79 | test_vpc_redundant.py
test_01_redundant_vpc_site2site_vpn | `Failure` | 542.14 | test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options | `Error` | 1222.88 | test_vpc_vpn.py
test_01_vpc_site2site_vpn | `Failure` | 264.35 | test_vpc_vpn.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7559: Create user 'cloud' in cloudstack-usage postinstall
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7559:
URL: https://github.com/apache/cloudstack/pull/7559#issuecomment-1563953233
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] benj-n commented on pull request #7559: Create user 'cloud' in cloudstack-usage postinstall
Posted by "benj-n (via GitHub)" <gi...@apache.org>.
benj-n commented on PR #7559:
URL: https://github.com/apache/cloudstack/pull/7559#issuecomment-1562919408
> LGTM - should we do this for EL7/EL8 etc rpms as well @benj-n for consistency?
According to https://github.com/apache/cloudstack/issues/7507#issuecomment-1562443286, the centos7/8 management and usage packages already have the 'cloud' user managed in their %pre phases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7559: Create user 'cloud' in cloudstack-usage postinstall
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7559:
URL: https://github.com/apache/cloudstack/pull/7559#issuecomment-1562414457
@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7559: Create user 'cloud' in cloudstack-usage postinstall
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7559:
URL: https://github.com/apache/cloudstack/pull/7559#issuecomment-1564024357
@DaanHoogland a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7559: Create user 'cloud' in cloudstack-usage postinstall
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7559:
URL: https://github.com/apache/cloudstack/pull/7559#issuecomment-1564022326
@blueorangutan LLtest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7559: Create user 'cloud' in cloudstack-usage postinstall
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7559:
URL: https://github.com/apache/cloudstack/pull/7559#issuecomment-1564194316
tested on ubuntu20 (and for comparison on rocky8) works as expected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org