You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/01/06 01:33:49 UTC
[GitHub] [incubator-yunikorn-core] wilfred-s opened a new pull request #234: [YUNIKORN-499] race condition in sorting apps
wilfred-s opened a new pull request #234:
URL: https://github.com/apache/incubator-yunikorn-core/pull/234
While sorting applications the pending resources of an application are
accessed. This could happen while a different routine is updating the
pending resources when a Ask is modified.
Replace the pending resource object instead of cloning on retrieval as it
is faster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] yangwwei merged pull request #234: [YUNIKORN-499] race condition in sorting apps
Posted by GitBox <gi...@apache.org>.
yangwwei merged pull request #234:
URL: https://github.com/apache/incubator-yunikorn-core/pull/234
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] commented on pull request #234: [YUNIKORN-499] race condition in sorting apps
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #234:
URL: https://github.com/apache/incubator-yunikorn-core/pull/234#issuecomment-755092275
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/234?src=pr&el=h1) Report
> Merging [#234](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/234?src=pr&el=desc) (bc649f1) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/5471d84cd619dc9b6c40e970b0e9d53aa3f8e07f?el=desc) (5471d84) will **not change** coverage.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #234 +/- ##
=======================================
Coverage 64.02% 64.02%
=======================================
Files 60 60
Lines 4984 4984
=======================================
Hits 3191 3191
Misses 1636 1636
Partials 157 157
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/234/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `55.30% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/234?src=pr&el=footer). Last update [5471d84...bc649f1](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org