You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "qindongliang (via GitHub)" <gi...@apache.org> on 2026/02/06 10:59:15 UTC

[PR] [fix](ui) Fix boolean values (true/false) displaying as empty in table cells [doris]

qindongliang opened a new pull request, #60579:
URL: https://github.com/apache/doris/pull/60579

   Boolean values were not displayed in table cells because React does not render boolean values as visible text. This fix converts all cell values to strings using String() to ensure proper display.
   Affected components:
   - content-result.tsx: Query result table
   - data-prev.tsx: Data preview table
   
   ### Affected Version
   - master
   - 4.0.2 
   - Other versions not tested
   
   current bug boolean column show :
   <img width="1206" height="349" alt="image" src="https://github.com/user-attachments/assets/2a3e8a3d-1333-4fdf-ae36-9eb62ff9f3cd" />
   
   
   fix bug boolean column show :
   <img width="948" height="305" alt="image" src="https://github.com/user-attachments/assets/f7acae07-ced9-49f1-9e1b-ef8ad2f79ff9" />
   
   ### What problem does this PR solve?
   Issue Number: close #xxx
   Related PR: #xxx
   Problem Summary:
   When querying tables containing `BOOLEAN` type columns in the Doris UI Playground, the values `true` and `false` were displayed as **empty cells** instead of displaying the actual text "true" or "false".
   **Root Cause**: In React/JSX, boolean values (`true`/`false`) are not rendered as visible text when used directly as child elements. They need to be explicitly converted to strings.
   **Solution**: Use `String()` to convert all cell values to strings before rendering, ensuring boolean values display correctly while preserving the existing behavior for other data types.
   ### Release note
   Fixed an issue where boolean values (true/false) were displayed as empty in the query result table and data preview table in the Playground UI.
   ### Check List (For Author)
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [x] Manual test (add detailed scripts or steps below)
           - Execute `SELECT * FROM table_with_boolean_column` in Playground or Click  Data Preview on Select Table
           - Verify that boolean values now display as "true" or "false" instead of empty cells
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   - Behavior changed:
       - [x] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   - Does this need documentation?
       - [x] No.
       - [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
   ### Check List (For Reviewer who merge this PR)
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](ui) Fix boolean values (true/false) displaying as empty in table cells [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60579:
URL: https://github.com/apache/doris/pull/60579#issuecomment-5198964251

   We're closing this PR because it hasn't been updated in a while.
   This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
   If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](ui) Fix boolean values (true/false) displaying as empty in table cells [doris]

Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #60579:
URL: https://github.com/apache/doris/pull/60579#issuecomment-3859722315

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](ui) Fix boolean values (true/false) displaying as empty in table cells [doris]

Posted by "qindongliang (via GitHub)" <gi...@apache.org>.
qindongliang closed pull request #60579: [fix](ui) Fix boolean values (true/false) displaying as empty in table cells
URL: https://github.com/apache/doris/pull/60579


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org