You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by "Lionel Cons (Created) (JIRA)" <ji...@apache.org> on 2012/04/05 08:44:09 UTC

[jira] [Created] (APLO-185) Apollo can send STOMP messages without a destination header (advisories)

Apollo can send STOMP messages without a destination header (advisories)
------------------------------------------------------------------------

                 Key: APLO-185
                 URL: https://issues.apache.org/jira/browse/APLO-185
             Project: ActiveMQ Apollo
          Issue Type: Bug
         Environment: apollo-99-trunk-20120404.190241-13
            Reporter: Lionel Cons


As discovered by accident in the console, recent Apollo snapshots use the following topics: ActiveMQ.Advisory.Topic and ActiveMQ.Advisory.Queue.

When trying to consume messages from these, the messages do not contain a "destination" header, this way violating the STOMP 1.1 spec.

Here is an example (the body contains binary characters):

  'body' => t{)ID:xxx-21826-1333604711518-0:0eActiveMQ.Advisory.Queuen{)ID:xxx-21826-1333604711518-0:0AdvisoryoriginBrokerId	NOT_SETd?monitor.test.yyy.apollo.xxx.stomp',
  'header' => {
    'content-length' => '378',
    'content-type' => 'protocol/openwire',
    'message-id' => 'apollo-5418',
    'subscription' => '8988460-4f7d3c07-589d-fa9a-6'
  },

Could the "destination" header be added please?

This also brings other questions:

(1) why does Apollo generate protocol/openwire messages although I did not enable OpenWire?

(2) if these advisories are useful without OpenWire, the body should be easier to parse (e.g. JSON)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (APLO-185) Apollo can send STOMP messages without a destination header (advisories)

Posted by "Hiram Chirino (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/APLO-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250158#comment-13250158 ] 

Hiram Chirino commented on APLO-185:
------------------------------------

I've also now changed this so that the Advisory topic is not created until the topic is subscribed to.  Helps keep the Openwire support hidden until it's fully supported and documented.
                
> Apollo can send STOMP messages without a destination header (advisories)
> ------------------------------------------------------------------------
>
>                 Key: APLO-185
>                 URL: https://issues.apache.org/jira/browse/APLO-185
>             Project: ActiveMQ Apollo
>          Issue Type: Bug
>         Environment: apollo-99-trunk-20120404.190241-13
>            Reporter: Lionel Cons
>            Assignee: Hiram Chirino
>             Fix For: 1.2
>
>
> As discovered by accident in the console, recent Apollo snapshots use the following topics: ActiveMQ.Advisory.Topic and ActiveMQ.Advisory.Queue.
> When trying to consume messages from these, the messages do not contain a "destination" header, this way violating the STOMP 1.1 spec.
> Here is an example (the body contains binary characters):
>   'body' => t{)ID:xxx-21826-1333604711518-0:0eActiveMQ.Advisory.Queuen{)ID:xxx-21826-1333604711518-0:0AdvisoryoriginBrokerId	NOT_SETd?monitor.test.yyy.apollo.xxx.stomp',
>   'header' => {
>     'content-length' => '378',
>     'content-type' => 'protocol/openwire',
>     'message-id' => 'apollo-5418',
>     'subscription' => '8988460-4f7d3c07-589d-fa9a-6'
>   },
> Could the "destination" header be added please?
> This also brings other questions:
> (1) why does Apollo generate protocol/openwire messages although I did not enable OpenWire?
> (2) if these advisories are useful without OpenWire, the body should be easier to parse (e.g. JSON)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (APLO-185) Apollo can send STOMP messages without a destination header (advisories)

Posted by "Hiram Chirino (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/APLO-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250046#comment-13250046 ] 

Hiram Chirino commented on APLO-185:
------------------------------------

(1) Although undocumented, Apollo has an initial openwire implementation.  To remove openwire support altogether, just delete the apollo-openwire-*.jar from the apollo lib directory.

(2) Agree.

And yes, the destination header should get added.  Thanks for spotting that.
                
> Apollo can send STOMP messages without a destination header (advisories)
> ------------------------------------------------------------------------
>
>                 Key: APLO-185
>                 URL: https://issues.apache.org/jira/browse/APLO-185
>             Project: ActiveMQ Apollo
>          Issue Type: Bug
>         Environment: apollo-99-trunk-20120404.190241-13
>            Reporter: Lionel Cons
>
> As discovered by accident in the console, recent Apollo snapshots use the following topics: ActiveMQ.Advisory.Topic and ActiveMQ.Advisory.Queue.
> When trying to consume messages from these, the messages do not contain a "destination" header, this way violating the STOMP 1.1 spec.
> Here is an example (the body contains binary characters):
>   'body' => t{)ID:xxx-21826-1333604711518-0:0eActiveMQ.Advisory.Queuen{)ID:xxx-21826-1333604711518-0:0AdvisoryoriginBrokerId	NOT_SETd?monitor.test.yyy.apollo.xxx.stomp',
>   'header' => {
>     'content-length' => '378',
>     'content-type' => 'protocol/openwire',
>     'message-id' => 'apollo-5418',
>     'subscription' => '8988460-4f7d3c07-589d-fa9a-6'
>   },
> Could the "destination" header be added please?
> This also brings other questions:
> (1) why does Apollo generate protocol/openwire messages although I did not enable OpenWire?
> (2) if these advisories are useful without OpenWire, the body should be easier to parse (e.g. JSON)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (APLO-185) Apollo can send STOMP messages without a destination header (advisories)

Posted by "Hiram Chirino (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/APLO-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hiram Chirino resolved APLO-185.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 1.2
         Assignee: Hiram Chirino

Fixed.  This would have also affect message which originated from Openwire or MQTT protocols.
                
> Apollo can send STOMP messages without a destination header (advisories)
> ------------------------------------------------------------------------
>
>                 Key: APLO-185
>                 URL: https://issues.apache.org/jira/browse/APLO-185
>             Project: ActiveMQ Apollo
>          Issue Type: Bug
>         Environment: apollo-99-trunk-20120404.190241-13
>            Reporter: Lionel Cons
>            Assignee: Hiram Chirino
>             Fix For: 1.2
>
>
> As discovered by accident in the console, recent Apollo snapshots use the following topics: ActiveMQ.Advisory.Topic and ActiveMQ.Advisory.Queue.
> When trying to consume messages from these, the messages do not contain a "destination" header, this way violating the STOMP 1.1 spec.
> Here is an example (the body contains binary characters):
>   'body' => t{)ID:xxx-21826-1333604711518-0:0eActiveMQ.Advisory.Queuen{)ID:xxx-21826-1333604711518-0:0AdvisoryoriginBrokerId	NOT_SETd?monitor.test.yyy.apollo.xxx.stomp',
>   'header' => {
>     'content-length' => '378',
>     'content-type' => 'protocol/openwire',
>     'message-id' => 'apollo-5418',
>     'subscription' => '8988460-4f7d3c07-589d-fa9a-6'
>   },
> Could the "destination" header be added please?
> This also brings other questions:
> (1) why does Apollo generate protocol/openwire messages although I did not enable OpenWire?
> (2) if these advisories are useful without OpenWire, the body should be easier to parse (e.g. JSON)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira