[jira] [Resolved] (WICKET-4758) Fix created in WICKET-3916 is not effective

["Jeremy Thomerson (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-4758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeremy Thomerson resolved WICKET-4758.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5.9
                   6.0.1
         Assignee: Jeremy Thomerson

This should fix it, but I don't currently have an easy way to test it.  Please verify and re-open this issue if it's not fixed.

Master: https://git-wip-us.apache.org/repos/asf?p=wicket.git;a=commit;h=c274a707c2929e853907d3bd9b64e1582c16faac

1.5.x: https://git-wip-us.apache.org/repos/asf?p=wicket.git;a=commit;h=ac7748671472ac7d4f3f82e8801b607d3f73e5c2
                
> Fix created in WICKET-3916 is not effective
> -------------------------------------------
>
>                 Key: WICKET-4758
>                 URL: https://issues.apache.org/jira/browse/WICKET-4758
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 1.5.0, 6.0.0
>            Reporter: Wolfgang Kritzinger
>            Assignee: Jeremy Thomerson
>             Fix For: 6.0.1, 1.5.9
>
>
> The fix in WICKET-3916 is not effective: https://fisheye6.atlassian.com/changelog/wicket?cs=1148229
> https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/Component.java#L2506
> As one can see in Component.internalRenderComponent(), the method Component.onComponentTag(), where the markup id is written to the tag, is called before the behavior had a chance to call setOutputMarkupId(true). (The Behavior.onComponentTag() is called in Component.renderComponentTag() a few lines down. The behavior has to call setOutputMarkupId() earlier, like in onConfigure()

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira