You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by "gengliangwang (via GitHub)" <gi...@apache.org> on 2023/11/30 22:47:56 UTC
[PR] Fix the CSS of Spark doc's generated tables [spark-website]
gengliangwang opened a new pull request, #492:
URL: https://github.com/apache/spark-website/pull/492
<!-- *Make sure that you generate site HTML with `bundle exec jekyll build`, and include the changes to the HTML in your pull request. See README.md for more information.* -->
After https://github.com/apache/spark/pull/40269, there is no border in the generated tables of Spark doc(for example, [sql-ref-ansi-compliance.html](https://spark.apache.org/docs/latest/sql-ref-ansi-compliance.html)) . Currently only the doc of Spark 3.5.0 is affected.
This PR is to apply the changes in https://github.com/apache/spark/pull/44096 on the current Spark 3.5.0 doc by
1. change the `site/docs/3.5.0/css/custom.css`
2. Execute `sed -i '' 's/table class="table table-striped"/table/' *.html` under `site/docs/3.5.0/` directory.
This should be a safe change. I have verified it on my local env.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
Re: [PR] Fix the CSS of Spark 3.5.0 doc's generated tables [spark-website]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #492:
URL: https://github.com/apache/spark-website/pull/492#issuecomment-1834822952
Thanks @gengliangwang for confirming that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
Re: [PR] Fix the CSS of Spark 3.5.0 doc's generated tables [spark-website]
Posted by "gengliangwang (via GitHub)" <gi...@apache.org>.
gengliangwang merged PR #492:
URL: https://github.com/apache/spark-website/pull/492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
Re: [PR] Fix the CSS of Spark 3.5.0 doc's generated tables [spark-website]
Posted by "gengliangwang (via GitHub)" <gi...@apache.org>.
gengliangwang commented on PR #492:
URL: https://github.com/apache/spark-website/pull/492#issuecomment-1834697041
@viirya Thanks for the review. I am merging it now and will double-check on the website.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
Re: [PR] Fix the CSS of Spark 3.5.0 doc's generated tables [spark-website]
Posted by "gengliangwang (via GitHub)" <gi...@apache.org>.
gengliangwang commented on PR #492:
URL: https://github.com/apache/spark-website/pull/492#issuecomment-1834718549
I confirmed that the changes work as expected!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
Re: [PR] Fix the CSS of Spark 3.5.0 doc's generated tables [spark-website]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #492:
URL: https://github.com/apache/spark-website/pull/492#issuecomment-1834697323
Thank you @gengliangwang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org