You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by liuyu000 <gi...@git.apache.org> on 2018/01/16 07:55:18 UTC
[GitHub] trafodion pull request #1400: [TRAFODION-2910] Add Details for Load Statemen...
GitHub user liuyu000 opened a pull request:
https://github.com/apache/trafodion/pull/1400
[TRAFODION-2910] Add Details for Load Statement 4 and Correct Typos for *Trafodion SQL Reference Manual*
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/liuyu000/trafodion LoadStatement4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafodion/pull/1400.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1400
----
commit 1e3707985078d1f5d338bfa69d9c4600c85085b7
Author: liu.yu <yu...@...>
Date: 2018-01-16T07:53:28Z
Add Details for Load Statement 4 and Correct Typos for *Trafodion SQL Reference Manual*
----
---
[GitHub] trafodion pull request #1400: [TRAFODION-2910] Add Details for Load Statemen...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafodion/pull/1400
---
[GitHub] trafodion pull request #1400: [TRAFODION-2910] Add Details for Load Statemen...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1400#discussion_r162189054
--- Diff: docs/sql_reference/src/asciidoc/_chapters/olap_functions.adoc ---
@@ -260,7 +260,7 @@ and <<interval_value_expressions,Interval Value Expressions>>.
* `_inline-window-specification_`
+
-specifies_the_window_over_which_the_avg_is_computed. The
+specifies the window over which the avg is computed. The
--- End diff --
It would be better to spell out "avg" (as "average"). Or if we are referring to the AVG syntax, capitalize it.
---
[GitHub] trafodion pull request #1400: [TRAFODION-2910] Add Details for Load Statemen...
Posted by liuyu000 <gi...@git.apache.org>.
Github user liuyu000 commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1400#discussion_r162230705
--- Diff: docs/sql_reference/src/asciidoc/_chapters/olap_functions.adoc ---
@@ -260,7 +260,7 @@ and <<interval_value_expressions,Interval Value Expressions>>.
* `_inline-window-specification_`
+
-specifies_the_window_over_which_the_avg_is_computed. The
+specifies the window over which the avg is computed. The
--- End diff --
Thanks Dave, your comment has been incorporated :)
---