You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "leaves12138 (via GitHub)" <gi...@apache.org> on 2023/09/19 07:37:17 UTC
[GitHub] [incubator-paimon] leaves12138 opened a new pull request, #2040: [flink] add dynamic table option for CompactAction and SortCompactAction.
leaves12138 opened a new pull request, #2040:
URL: https://github.com/apache/incubator-paimon/pull/2040
### Purpose
Add dynamic option to specify the dynamic table conf when execute CompactAction or SortCompactAction.
For example, we can add --table-conf sink.parallelism=xxx to specify the compaction sink parallelism without change the meta data of the table.
### Tests
Add Tests for CompactAction and SortCompactAction about dynamic table conf
### API and Format
No influence to other user behavior.
### Documentation
Added documentations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] add dynamic table option for CompactAction and SortCompactAction. [incubator-paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #2040:
URL: https://github.com/apache/incubator-paimon/pull/2040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] leaves12138 commented on a diff in pull request #2040: [flink] add dynamic table option for CompactAction and SortCompactAction.
Posted by "leaves12138 (via GitHub)" <gi...@apache.org>.
leaves12138 commented on code in PR #2040:
URL: https://github.com/apache/incubator-paimon/pull/2040#discussion_r1333839443
##########
docs/layouts/shortcodes/generated/core_configuration.html:
##########
@@ -473,6 +473,18 @@
<td>String</td>
<td>The time zone to parse the long watermark value to TIMESTAMP value. The default value is 'UTC', which means the watermark is defined on TIMESTAMP column or not defined. If the watermark is defined on TIMESTAMP_LTZ column, the time zone of watermark is user configured time zone, the value should be the user configured local time zone. The option value is either a full name such as 'America/Los_Angeles', or a custom timezone id such as 'GMT-08:00'.</td>
</tr>
+ <tr>
+ <td><h5>snapshot.expire.execution-mode</h5></td>
Review Comment:
The change is generated automatically by "mvn package -Pgenerate-docs -pl paimon-docs -nsu", I will remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] yuzelin commented on a diff in pull request #2040: [flink] add dynamic table option for CompactAction and SortCompactAction.
Posted by "yuzelin (via GitHub)" <gi...@apache.org>.
yuzelin commented on code in PR #2040:
URL: https://github.com/apache/incubator-paimon/pull/2040#discussion_r1333965739
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/procedure/CompactProcedure.java:
##########
@@ -62,18 +65,23 @@ public String[] call(
String orderStrategy,
String orderByColumns)
throws Exception {
- return call(procedureContext, tableId, orderStrategy, orderByColumns, new String[0]);
+ return call(procedureContext, tableId, orderStrategy, orderByColumns, "", new String[0]);
}
public String[] call(
ProcedureContext procedureContext,
String tableId,
String orderStrategy,
String orderByColumns,
+ String tableConfString,
String... partitionStrings)
throws Exception {
String warehouse = ((AbstractCatalog) catalog).warehouse();
Map<String, String> catalogOptions = ((AbstractCatalog) catalog).options();
+ Map<String, String> tableConf =
+ StringUtils.isEmpty(tableConfString)
Review Comment:
`isBlank`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] leaves12138 closed pull request #2040: [flink] add dynamic table option for CompactAction and SortCompactAction.
Posted by "leaves12138 (via GitHub)" <gi...@apache.org>.
leaves12138 closed pull request #2040: [flink] add dynamic table option for CompactAction and SortCompactAction.
URL: https://github.com/apache/incubator-paimon/pull/2040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #2040: [flink] add dynamic table option for CompactAction and SortCompactAction.
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #2040:
URL: https://github.com/apache/incubator-paimon/pull/2040#discussion_r1331599938
##########
docs/layouts/shortcodes/generated/core_configuration.html:
##########
@@ -473,6 +473,18 @@
<td>String</td>
<td>The time zone to parse the long watermark value to TIMESTAMP value. The default value is 'UTC', which means the watermark is defined on TIMESTAMP column or not defined. If the watermark is defined on TIMESTAMP_LTZ column, the time zone of watermark is user configured time zone, the value should be the user configured local time zone. The option value is either a full name such as 'America/Los_Angeles', or a custom timezone id such as 'GMT-08:00'.</td>
</tr>
+ <tr>
+ <td><h5>snapshot.expire.execution-mode</h5></td>
Review Comment:
Why you need to modify this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org