[jira] Commented: (OFBIZ-3099) PriceServices.calculateProductPrice should not process or return obsolete PriceRules

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770934#action_12770934 ] 

Jacques Le Roux commented on OFBIZ-3099:
----------------------------------------

Hi Patrick,

I agree and can't neither see why to calculate obsolete prices.
So I commited your 1st patch in trunk at r830528. Do you intend to provide another patch for the service definition ? Else I will close, except if somebody see a trouble with this change or want to enhance the service definition...


> PriceServices.calculateProductPrice should not process or return obsolete PriceRules
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3099
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3099
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Patrick Antivackis
>             Fix For: SVN trunk
>
>         Attachments: Patch-OFBIZ-3099.txt
>
>
> There is no filterByDate done on the allProductPriceRules returned line 559.
> The consequences are that a findAllQuantityPrices=Y return a Map with some obsolete PriceRule
> The calcPriceResultFromRules process some PriceRules that could be filtered before.
> I don't see the point of returning all the PriceRules found when using findAllQuantityPrices=Y as this map is used to display active price quantity condition to the customer.
> If the service do need to return all PriceRules, as it is today, the service should be updated in order to allow to specify if the returned list should be only active or all.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.