You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2014/12/10 10:58:36 UTC

[GitHub] spark pull request: SPARK-4159 [CORE] Maven build doesn't run JUni...

Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/3651#issuecomment-66428269
  
    I'm pretty convinced this works now. I'm diffing the test run output between master and this branch, and the scala tests are the same. The only visible differences are that `scalatest` turns up in every module, and of course, output from `surefire` now.
    
    Note that I did _not_ enable assertions in SBT now, which I mentioned in a related conversation. There's another issue with it tracked in http://issues.apache.org/jira/browse/SPARK-4814
    
    I also think this is a predecessor to https://issues.apache.org/jira/browse/SPARK-3431
    
    Let's see what Jenkins says. I'm calling this no longer a WIP.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org