You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "jdoe (JIRA)" <ji...@codehaus.org> on 2007/08/28 20:42:40 UTC

[jira] Created: (SUREFIRE-352) Get rid of hardcoded TestNG dependency name.

Get rid of hardcoded TestNG dependency name.
--------------------------------------------

                 Key: SUREFIRE-352
                 URL: http://jira.codehaus.org/browse/SUREFIRE-352
             Project: Maven Surefire
          Issue Type: Improvement
          Components: TestNG support
    Affects Versions: 2.4
            Reporter: jdoe
         Attachments: custom_testng_dep_name.diff

The name of the TestNG dependency is hardcoded ('org.testng:testng'). Some ppl are using internal repositories where artifacts are published under different names. It would be nice to able to specify the name of dependency, e.g.:

{code:title=build.pom|borderStyle=solid}
<plugin>
	<groupId>org.apache.maven.plugins</groupId>
	<artifactId>maven-surefire-plugin</artifactId>
	<version>2.4-SNAPSHOT</version>
	<configuration>
		<testNGDependency>testng:testng</testNGDependency> <!-- custom dependency name -->
		<suiteXmlFiles>
			<suiteXmlFile>testng.xml</suiteXmlFile>
		</suiteXmlFiles>
	</configuration>
</plugin>
{code}

Proposed patch attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (SUREFIRE-352) Get rid of hardcoded TestNG dependency name.

Posted by "Mauro Talevi (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SUREFIRE-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mauro Talevi updated SUREFIRE-352:
----------------------------------

    Affects Version/s:     (was: 2.4)
                       2.3

Fixed affects version.

> Get rid of hardcoded TestNG dependency name.
> --------------------------------------------
>
>                 Key: SUREFIRE-352
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-352
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: TestNG support
>    Affects Versions: 2.3
>            Reporter: jdoe
>            Assignee: Mauro Talevi
>             Fix For: 2.3.1, 2.4
>
>         Attachments: custom_testng_dep_name.diff
>
>
> The name of the TestNG dependency is hardcoded ('org.testng:testng'). Some ppl are using internal repositories where artifacts are published under different names. It would be nice to able to specify the name of dependency, e.g.:
> {code:title=build.pom|borderStyle=solid}
> <plugin>
> 	<groupId>org.apache.maven.plugins</groupId>
> 	<artifactId>maven-surefire-plugin</artifactId>
> 	<version>2.4-SNAPSHOT</version>
> 	<configuration>
> 		<testNGDependency>testng:testng</testNGDependency> <!-- custom dependency name -->
> 		<suiteXmlFiles>
> 			<suiteXmlFile>testng.xml</suiteXmlFile>
> 		</suiteXmlFiles>
> 	</configuration>
> </plugin>
> {code}
> Proposed patch attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SUREFIRE-352) Get rid of hardcoded TestNG dependency name.

Posted by "Mauro Talevi (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SUREFIRE-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_115786 ] 

Mauro Talevi commented on SUREFIRE-352:
---------------------------------------

Backported fix (-r597038:597039) to 2.3.x branch, being completely backward compatible. 

> Get rid of hardcoded TestNG dependency name.
> --------------------------------------------
>
>                 Key: SUREFIRE-352
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-352
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: TestNG support
>    Affects Versions: 2.4
>            Reporter: jdoe
>            Assignee: Mauro Talevi
>             Fix For: 2.4
>
>         Attachments: custom_testng_dep_name.diff
>
>
> The name of the TestNG dependency is hardcoded ('org.testng:testng'). Some ppl are using internal repositories where artifacts are published under different names. It would be nice to able to specify the name of dependency, e.g.:
> {code:title=build.pom|borderStyle=solid}
> <plugin>
> 	<groupId>org.apache.maven.plugins</groupId>
> 	<artifactId>maven-surefire-plugin</artifactId>
> 	<version>2.4-SNAPSHOT</version>
> 	<configuration>
> 		<testNGDependency>testng:testng</testNGDependency> <!-- custom dependency name -->
> 		<suiteXmlFiles>
> 			<suiteXmlFile>testng.xml</suiteXmlFile>
> 		</suiteXmlFiles>
> 	</configuration>
> </plugin>
> {code}
> Proposed patch attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (SUREFIRE-352) Get rid of hardcoded TestNG dependency name.

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SUREFIRE-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter updated SUREFIRE-352:
----------------------------------

    Fix Version/s: 2.4

> Get rid of hardcoded TestNG dependency name.
> --------------------------------------------
>
>                 Key: SUREFIRE-352
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-352
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: TestNG support
>    Affects Versions: 2.4
>            Reporter: jdoe
>             Fix For: 2.4
>
>         Attachments: custom_testng_dep_name.diff
>
>
> The name of the TestNG dependency is hardcoded ('org.testng:testng'). Some ppl are using internal repositories where artifacts are published under different names. It would be nice to able to specify the name of dependency, e.g.:
> {code:title=build.pom|borderStyle=solid}
> <plugin>
> 	<groupId>org.apache.maven.plugins</groupId>
> 	<artifactId>maven-surefire-plugin</artifactId>
> 	<version>2.4-SNAPSHOT</version>
> 	<configuration>
> 		<testNGDependency>testng:testng</testNGDependency> <!-- custom dependency name -->
> 		<suiteXmlFiles>
> 			<suiteXmlFile>testng.xml</suiteXmlFile>
> 		</suiteXmlFiles>
> 	</configuration>
> </plugin>
> {code}
> Proposed patch attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (SUREFIRE-352) Get rid of hardcoded TestNG dependency name.

Posted by "Mauro Talevi (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SUREFIRE-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mauro Talevi closed SUREFIRE-352.
---------------------------------

    Resolution: Fixed

Added optional properties junitArtifactName and testNGArtifactName which default to junit:junit and org.testng:testng, as in 2.3.    

Fix also addresses SUREFIRE-370.

> Get rid of hardcoded TestNG dependency name.
> --------------------------------------------
>
>                 Key: SUREFIRE-352
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-352
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: TestNG support
>    Affects Versions: 2.4
>            Reporter: jdoe
>            Assignee: Mauro Talevi
>             Fix For: 2.4
>
>         Attachments: custom_testng_dep_name.diff
>
>
> The name of the TestNG dependency is hardcoded ('org.testng:testng'). Some ppl are using internal repositories where artifacts are published under different names. It would be nice to able to specify the name of dependency, e.g.:
> {code:title=build.pom|borderStyle=solid}
> <plugin>
> 	<groupId>org.apache.maven.plugins</groupId>
> 	<artifactId>maven-surefire-plugin</artifactId>
> 	<version>2.4-SNAPSHOT</version>
> 	<configuration>
> 		<testNGDependency>testng:testng</testNGDependency> <!-- custom dependency name -->
> 		<suiteXmlFiles>
> 			<suiteXmlFile>testng.xml</suiteXmlFile>
> 		</suiteXmlFiles>
> 	</configuration>
> </plugin>
> {code}
> Proposed patch attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SUREFIRE-352) Get rid of hardcoded TestNG dependency name.

Posted by "Dan Fabulich (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SUREFIRE-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_114382 ] 

Dan Fabulich commented on SUREFIRE-352:
---------------------------------------

Duplicated by SUREFIRE-370.  There it was noted that you might also want to use junit:junit-dep 4.4.  (junit:junit 4.4 bundles hamcrest-core in its jar; junit:junit-dep includes only junit in its jar, and explicitly depends on the hamcrest jar separately).

> Get rid of hardcoded TestNG dependency name.
> --------------------------------------------
>
>                 Key: SUREFIRE-352
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-352
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: TestNG support
>    Affects Versions: 2.4
>            Reporter: jdoe
>             Fix For: 2.4
>
>         Attachments: custom_testng_dep_name.diff
>
>
> The name of the TestNG dependency is hardcoded ('org.testng:testng'). Some ppl are using internal repositories where artifacts are published under different names. It would be nice to able to specify the name of dependency, e.g.:
> {code:title=build.pom|borderStyle=solid}
> <plugin>
> 	<groupId>org.apache.maven.plugins</groupId>
> 	<artifactId>maven-surefire-plugin</artifactId>
> 	<version>2.4-SNAPSHOT</version>
> 	<configuration>
> 		<testNGDependency>testng:testng</testNGDependency> <!-- custom dependency name -->
> 		<suiteXmlFiles>
> 			<suiteXmlFile>testng.xml</suiteXmlFile>
> 		</suiteXmlFiles>
> 	</configuration>
> </plugin>
> {code}
> Proposed patch attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (SUREFIRE-352) Get rid of hardcoded TestNG dependency name.

Posted by "Mauro Talevi (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SUREFIRE-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mauro Talevi updated SUREFIRE-352:
----------------------------------

    Fix Version/s: 2.3.1

Added fix version 2.3.1

> Get rid of hardcoded TestNG dependency name.
> --------------------------------------------
>
>                 Key: SUREFIRE-352
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-352
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: TestNG support
>    Affects Versions: 2.4
>            Reporter: jdoe
>            Assignee: Mauro Talevi
>             Fix For: 2.3.1, 2.4
>
>         Attachments: custom_testng_dep_name.diff
>
>
> The name of the TestNG dependency is hardcoded ('org.testng:testng'). Some ppl are using internal repositories where artifacts are published under different names. It would be nice to able to specify the name of dependency, e.g.:
> {code:title=build.pom|borderStyle=solid}
> <plugin>
> 	<groupId>org.apache.maven.plugins</groupId>
> 	<artifactId>maven-surefire-plugin</artifactId>
> 	<version>2.4-SNAPSHOT</version>
> 	<configuration>
> 		<testNGDependency>testng:testng</testNGDependency> <!-- custom dependency name -->
> 		<suiteXmlFiles>
> 			<suiteXmlFile>testng.xml</suiteXmlFile>
> 		</suiteXmlFiles>
> 	</configuration>
> </plugin>
> {code}
> Proposed patch attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira