You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/01/01 21:27:05 UTC
[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #403:
HDDS-2820. OM Ratis dir creation may fail
adoroszlai opened a new pull request #403: HDDS-2820. OM Ratis dir creation may fail
URL: https://github.com/apache/hadoop-ozone/pull/403
## What changes were proposed in this pull request?
It may happen that `exists()` returns `false` because the dir is does not exist yet, but `mkdirs()` also returns `false` because the dir is created in the meantime by the Ratis thread. This PR proposes to swap the order of `exists` check and `mkdirs` call to avoid race condition.
https://issues.apache.org/jira/browse/HDDS-2820
## How was this patch tested?
Added unit test.
https://github.com/adoroszlai/hadoop-ozone/runs/366839202
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bshashikant merged pull request #403: HDDS-2820. OM
Ratis dir creation may fail
Posted by GitBox <gi...@apache.org>.
bshashikant merged pull request #403: HDDS-2820. OM Ratis dir creation may fail
URL: https://github.com/apache/hadoop-ozone/pull/403
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on issue #403: HDDS-2820. OM
Ratis dir creation may fail
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on issue #403: HDDS-2820. OM Ratis dir creation may fail
URL: https://github.com/apache/hadoop-ozone/pull/403#issuecomment-571103611
Thanks @cxorm and @bshashikant for the review, and @bshashikant for committing it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org