You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/07/19 12:31:43 UTC

[GitHub] [maven-integration-testing] michael-o commented on a diff in pull request #186: Fix minor typos

michael-o commented on code in PR #186:
URL: https://github.com/apache/maven-integration-testing/pull/186#discussion_r924435967


##########
core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java:
##########
@@ -262,7 +262,7 @@ public static Test suite()
         suite.addTestSuite( MavenITmng4720DependencyManagementExclusionMergeTest.class );
         suite.addTestSuite( MavenITmng4696MavenProjectDependencyArtifactsTest.class );
         suite.addTestSuite( MavenITmng4690InterdependentConflictResolutionTest.class );
-        suite.addTestSuite( MavenITmng4684DistMngtOverridenByProfileTest.class );
+        suite.addTestSuite( MavenITmng4684DistMngtOverriddenByProfileTest.class );

Review Comment:
   You might want to correct management as well: Mgmt



##########
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3023ReactorDependencyResolutionTest.java:
##########
@@ -112,7 +112,7 @@ public void testitMNG3023B()
     /**
      * Test that reactor projects are included in dependency resolution.
      *
-     * I this pass, the dependency should have been installed, so the dependency artifact should have
+     * If this pass, the dependency should have been installed, so the dependency artifact should have

Review Comment:
   ditto?



##########
core-it-support/core-it-plugins/maven-it-plugin-configuration/src/main/java/org/apache/maven/plugin/coreit/ConfigMojo.java:
##########
@@ -118,7 +118,7 @@
     /**
      * A simple parameter of type {@link java.lang.Integer}.
      *
-     * @parameter property="config.intergerParam"
+     * @parameter property="config.integerParam"

Review Comment:
   Attention: Is this property used in the IT?



##########
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3023ReactorDependencyResolutionTest.java:
##########
@@ -80,7 +80,7 @@ public void testitMNG3023A() throws Exception
     /**
      * Test that reactor projects are included in dependency resolution.
      *
-     * I this pass, the dependency artifact should have the file $(basedir)/dependency/dependency-classes
+     * If this pass, the dependency artifact should have the file $(basedir)/dependency/dependency-classes

Review Comment:
   passes?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org