You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Mehant Baid <ba...@gmail.com> on 2014/05/16 11:40:16 UTC
Review Request 21552: Fix OutputMutator interface

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21552/
-----------------------------------------------------------

Review request for drill and Jacques Nadeau.


Bugs: DRILL-757
    https://issues.apache.org/jira/browse/DRILL-757


Repository: drill-git


Description
-------

Removed deprecated interfaces from OutputMutator.
OutputMutator now manages schema changes, so unless schema changed between two RecordReaders OK_NEW_SCHEMA will not be returned downstream.
Modified RecordReader to reflect the interface changes.


Diffs
-----

  contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseRecordReader.java dbf8123 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/OutputMutator.java 38d56ea 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java a49d1a8 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader2.java bb52a20 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/hive/HiveRecordReader.java 9e01268 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/RowRecordReader.java ac601d4 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockRecordReader.java 5c07dc5 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRecordReader.java 4ca13a5 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/pojo/PojoRecordReader.java fc5a9b4 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/text/DrillTextRecordReader.java ef05b4c 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/TestOutputMutator.java 37369da 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/ischema/TestOrphanSchema.java 3b8b57b 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/ischema/TestTableProvider.java 8da1ea4 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetRecordReaderTest.java 5d2c859 

Diff: https://reviews.apache.org/r/21552/diff/


Testing
-------


Thanks,

Mehant Baid