You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Zsombor Gegesy <zs...@apache.org> on 2019/05/13 19:42:16 UTC
Review Request 70635: OOZIE-3488 - Migrate from guava classes to the
base Java implementations
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70635/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-3488
https://issues.apache.org/jira/browse/OOZIE-3488
Repository: oozie-git
Description
-------
In Oozie, guava classes are used even when Java 8 already provides a compatible implementation, removing these usages would reduce the dependency to guava (which is regularly a headache due to her backward incompatible changes).
This patch removes:
* com.google.common.base.Function
* com.google.common.collect.Iterables
* com.google.common.collect.Ordering
* com.google.common.collect.Lists
* com.google.common.base.Predicate
* com.google.common.base.Objects
* com.google.common.base.Optional
Diffs
-----
core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 7ebc909a
core/src/main/java/org/apache/oozie/util/db/CompositeIndex.java 88b9ca37
core/src/main/java/org/apache/oozie/util/db/DatabaseRetryPredicate.java c89aabe1
core/src/main/java/org/apache/oozie/util/db/FailingConnectionWrapper.java 9e603ed0
core/src/main/java/org/apache/oozie/util/db/FailingDBHelperForTest.java 7131e921
core/src/main/java/org/apache/oozie/util/db/FailingHSQLDBDriverWrapper.java 5f5d56f6
core/src/main/java/org/apache/oozie/util/db/OperationRetryHandler.java 16a0a827
core/src/main/java/org/apache/oozie/util/db/PersistenceExceptionSubclassFilterRetryPredicate.java 1e4413b6
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowValidator.java c7f2f498
core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java e1960332
core/src/test/java/org/apache/oozie/util/db/TestOozieDmlStatementPredicate.java c2d4b157
core/src/test/java/org/apache/oozie/util/db/TestOperationRetryHandler.java c61b1e55
core/src/test/java/org/apache/oozie/util/db/TestPersistenceExceptionSubclassFilterRetryPredicate.java 26dc13ba
sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAM.java 6df151cc
Diff: https://reviews.apache.org/r/70635/diff/1/
Testing
-------
Tested locally
Thanks,
Zsombor Gegesy
Re: Review Request 70635: OOZIE-3488 - Migrate from guava classes to
the base Java implementations
Posted by Andras Salamon <an...@melda.info>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70635/#review215296
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/util/db/CompositeIndex.java
Line 54 (original)
<https://reviews.apache.org/r/70635/#comment301961>
According to the comment this patch removes
com.google.common.collect.Lists, but this is the only reference to this class. There are other places where we use the Lists class, mostly for new arraylist creation like Lists.newArrayList.
I think it's possible to replace it with Arrays.asList, Collections.singletonList, Collections.emptyList. If we need a mutable list, we might use also new ArrayList<>.
core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java
Line 1308 (original), 1308 (patched)
<https://reviews.apache.org/r/70635/#comment301960>
Ouch, we need to use a fully qualified name here.
- Andras Salamon
On May 13, 2019, 7:42 p.m., Zsombor Gegesy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70635/
> -----------------------------------------------------------
>
> (Updated May 13, 2019, 7:42 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-3488
> https://issues.apache.org/jira/browse/OOZIE-3488
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> In Oozie, guava classes are used even when Java 8 already provides a compatible implementation, removing these usages would reduce the dependency to guava (which is regularly a headache due to her backward incompatible changes).
> This patch removes:
> * com.google.common.base.Function
> * com.google.common.collect.Iterables
> * com.google.common.collect.Ordering
> * com.google.common.collect.Lists
> * com.google.common.base.Predicate
> * com.google.common.base.Objects
> * com.google.common.base.Optional
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 7ebc909a
> core/src/main/java/org/apache/oozie/util/db/CompositeIndex.java 88b9ca37
> core/src/main/java/org/apache/oozie/util/db/DatabaseRetryPredicate.java c89aabe1
> core/src/main/java/org/apache/oozie/util/db/FailingConnectionWrapper.java 9e603ed0
> core/src/main/java/org/apache/oozie/util/db/FailingDBHelperForTest.java 7131e921
> core/src/main/java/org/apache/oozie/util/db/FailingHSQLDBDriverWrapper.java 5f5d56f6
> core/src/main/java/org/apache/oozie/util/db/OperationRetryHandler.java 16a0a827
> core/src/main/java/org/apache/oozie/util/db/PersistenceExceptionSubclassFilterRetryPredicate.java 1e4413b6
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowValidator.java c7f2f498
> core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java e1960332
> core/src/test/java/org/apache/oozie/util/db/TestOozieDmlStatementPredicate.java c2d4b157
> core/src/test/java/org/apache/oozie/util/db/TestOperationRetryHandler.java c61b1e55
> core/src/test/java/org/apache/oozie/util/db/TestPersistenceExceptionSubclassFilterRetryPredicate.java 26dc13ba
> sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAM.java 6df151cc
>
>
> Diff: https://reviews.apache.org/r/70635/diff/1/
>
>
> Testing
> -------
>
> Tested locally
>
>
> Thanks,
>
> Zsombor Gegesy
>
>
Re: Review Request 70635: OOZIE-3488 - Migrate from guava classes to
the base Java implementations
Posted by Zsombor Gegesy <zs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70635/
-----------------------------------------------------------
(Updated May 20, 2019, 9:17 a.m.)
Review request for oozie.
Changes
-------
Rebased change
Bugs: OOZIE-3488
https://issues.apache.org/jira/browse/OOZIE-3488
Repository: oozie-git
Description
-------
In Oozie, guava classes are used even when Java 8 already provides a compatible implementation, removing these usages would reduce the dependency to guava (which is regularly a headache due to her backward incompatible changes).
This patch removes:
* com.google.common.base.Function
* com.google.common.collect.Iterables
* com.google.common.collect.Ordering
* com.google.common.collect.Lists
* com.google.common.base.Predicate
* com.google.common.base.Objects
* com.google.common.base.Optional
Diffs (updated)
-----
client/src/main/java/org/apache/oozie/client/OozieClient.java 54e45c0b
core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 7ebc909a
core/src/main/java/org/apache/oozie/action/hadoop/SharelibResolver.java 18c50cbf
core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java e38f3d60
core/src/main/java/org/apache/oozie/service/JvmPauseMonitorService.java 13b28098
core/src/main/java/org/apache/oozie/servlet/V1JobsServlet.java 61db5def
core/src/main/java/org/apache/oozie/util/db/CompositeIndex.java 88b9ca37
core/src/main/java/org/apache/oozie/util/db/DatabaseRetryPredicate.java c89aabe1
core/src/main/java/org/apache/oozie/util/db/FailingConnectionWrapper.java 9e603ed0
core/src/main/java/org/apache/oozie/util/db/FailingDBHelperForTest.java 7131e921
core/src/main/java/org/apache/oozie/util/db/FailingHSQLDBDriverWrapper.java 5f5d56f6
core/src/main/java/org/apache/oozie/util/db/OperationRetryHandler.java 16a0a827
core/src/main/java/org/apache/oozie/util/db/PersistenceExceptionSubclassFilterRetryPredicate.java 1e4413b6
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowValidator.java c7f2f498
core/src/test/java/org/apache/oozie/action/hadoop/TestYarnApplicationIdFinder.java 3fd7149f
core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java aec1765b
core/src/test/java/org/apache/oozie/service/TestShareLibService.java 8bf2040c
core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java e1960332
core/src/test/java/org/apache/oozie/util/db/TestOozieDmlStatementPredicate.java c2d4b157
core/src/test/java/org/apache/oozie/util/db/TestOperationRetryHandler.java c61b1e55
core/src/test/java/org/apache/oozie/util/db/TestPersistenceExceptionSubclassFilterRetryPredicate.java 26dc13ba
fluent-job/fluent-job-api/src/test/java/org/apache/oozie/fluentjob/api/mapping/SourceDataFactory.java 4def062d
fluent-job/fluent-job-api/src/test/java/org/apache/oozie/fluentjob/api/workflow/TestCredentialsBuilder.java 4d3dce33
fluent-job/fluent-job-api/src/test/java/org/apache/oozie/fluentjob/api/workflow/TestWorkflowBuilder.java 29caf275
sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAM.java 6df151cc
sharelib/oozie/src/test/java/org/apache/oozie/action/hadoop/TestLauncherAMUtils.java 43c49144
sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java e86a2994
tools/src/main/java/org/apache/oozie/tools/OozieDBImportCLI.java 3db590d0
Diff: https://reviews.apache.org/r/70635/diff/3/
Changes: https://reviews.apache.org/r/70635/diff/2-3/
Testing
-------
Tested locally
Thanks,
Zsombor Gegesy
Re: Review Request 70635: OOZIE-3488 - Migrate from guava classes to
the base Java implementations
Posted by Zsombor Gegesy <zs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70635/
-----------------------------------------------------------
(Updated May 16, 2019, 6:39 p.m.)
Review request for oozie.
Changes
-------
Total removal of Lists usage too
Bugs: OOZIE-3488
https://issues.apache.org/jira/browse/OOZIE-3488
Repository: oozie-git
Description
-------
In Oozie, guava classes are used even when Java 8 already provides a compatible implementation, removing these usages would reduce the dependency to guava (which is regularly a headache due to her backward incompatible changes).
This patch removes:
* com.google.common.base.Function
* com.google.common.collect.Iterables
* com.google.common.collect.Ordering
* com.google.common.collect.Lists
* com.google.common.base.Predicate
* com.google.common.base.Objects
* com.google.common.base.Optional
Diffs (updated)
-----
client/src/main/java/org/apache/oozie/client/OozieClient.java 54e45c0b84b1df58e11ab1b67f8abc63e9d1bb30
core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 7ebc909a5bde24ee964373c9bc33f506afe23f43
core/src/main/java/org/apache/oozie/action/hadoop/SharelibResolver.java 18c50cbf7f1d1b549b00ad97f78ad16403d5f0d3
core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java e38f3d60dad2aae985bbdfec1239fd7f0afeec93
core/src/main/java/org/apache/oozie/service/JvmPauseMonitorService.java 13b28098c2fb6212e55c29dbef4ae3d2f23a6009
core/src/main/java/org/apache/oozie/servlet/V1JobsServlet.java 3a702aa124541c0f6a740a0114645c5ef17e5d76
core/src/main/java/org/apache/oozie/util/db/CompositeIndex.java 88b9ca37c34d1bae5a27a415d339b1f770d423ae
core/src/main/java/org/apache/oozie/util/db/DatabaseRetryPredicate.java c89aabe1adaacbb08e9a4236ba1109bf5fa2ecd0
core/src/main/java/org/apache/oozie/util/db/FailingConnectionWrapper.java 9e603ed03df516c8b08df9c7359a1aca57f4b796
core/src/main/java/org/apache/oozie/util/db/FailingDBHelperForTest.java 7131e921667e223a27a17b38ae515a9352425b96
core/src/main/java/org/apache/oozie/util/db/FailingHSQLDBDriverWrapper.java 5f5d56f66b2fde77d0a4da105b114a93f2597e16
core/src/main/java/org/apache/oozie/util/db/OperationRetryHandler.java 16a0a8272d1639e872b8a6a6715a8716fd549093
core/src/main/java/org/apache/oozie/util/db/PersistenceExceptionSubclassFilterRetryPredicate.java 1e4413b69eb5cddd0b72359615559b80d0c2a416
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowValidator.java c7f2f4989a7bd6fc695b45f0285689146d3ba567
core/src/test/java/org/apache/oozie/action/hadoop/TestYarnApplicationIdFinder.java 3fd7149f5f003f0abf2e28adb6871114cd8e036b
core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java aec1765bd895ca9ca9b35de23497da31a5ed3f83
core/src/test/java/org/apache/oozie/service/TestShareLibService.java 95dab5c97dc48305497ce20c5508849d6851a1ab
core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java e1960332d94d9db6f01c98e9bb3e2cf9e3d9a193
core/src/test/java/org/apache/oozie/util/db/TestOozieDmlStatementPredicate.java c2d4b157c1726b6c20c92b6c2f3dd13e9707b192
core/src/test/java/org/apache/oozie/util/db/TestOperationRetryHandler.java c61b1e55e9f9a6f319d656376792b6e89e7d5955
core/src/test/java/org/apache/oozie/util/db/TestPersistenceExceptionSubclassFilterRetryPredicate.java 26dc13baf02c601d93b0e9a527d5245c94813728
fluent-job/fluent-job-api/src/test/java/org/apache/oozie/fluentjob/api/mapping/SourceDataFactory.java 4def062d3ad0a2ea209ea5cfd510c6e7797f4329
fluent-job/fluent-job-api/src/test/java/org/apache/oozie/fluentjob/api/workflow/TestCredentialsBuilder.java 4d3dce33222163d4fd9421bf541cf3dec141cc26
fluent-job/fluent-job-api/src/test/java/org/apache/oozie/fluentjob/api/workflow/TestWorkflowBuilder.java 29caf2752b09a521598527cd88f7b9b447e59377
sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAM.java 6df151cc1ec3b56747e892b92df22b57213807fb
sharelib/oozie/src/test/java/org/apache/oozie/action/hadoop/TestLauncherAMUtils.java 43c4914421e16aab5a0c63ff4721486e79904576
sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java 474ecbfc9039e48c11d7a4dd364862bed3797d28
sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkMain.java 660a4ec9a118b2e276a18ca2e83de7af0e78f4ac
tools/src/main/java/org/apache/oozie/tools/OozieDBImportCLI.java 3db590d02090aa730d64706fe2fc56e927a0e4ff
Diff: https://reviews.apache.org/r/70635/diff/2/
Changes: https://reviews.apache.org/r/70635/diff/1-2/
Testing
-------
Tested locally
Thanks,
Zsombor Gegesy