[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #4265: [Fix] [Zeta] Fix TaskExecutionService Deploy Failed The Job Can't Stop

["Hisoka-X (via GitHub)" <gi...@apache.org>]

Hisoka-X commented on code in PR #4265:
URL: https://github.com/apache/incubator-seatunnel/pull/4265#discussion_r1132261564


##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/TaskExecutionService.java:
##########
@@ -276,30 +271,21 @@ public PassiveCompletableFuture<TaskExecutionState> deployTask(
                                     ? taskGroup.getTaskGroupLocation().toString()
                                     : "taskGroupLocation is null",
                             ExceptionUtils.getMessage(t)));
-            resultFuture.complete(
-                    new TaskExecutionState(
-                            taskGroup != null && taskGroup.getTaskGroupLocation() != null
-                                    ? taskGroup.getTaskGroupLocation()
-                                    : null,
-                            ExecutionState.FAILED,
-                            t));
+            return TaskDeployState.failed(t);
         }
-        return new PassiveCompletableFuture<>(resultFuture);
     }
 
     @Deprecated
     public PassiveCompletableFuture<TaskExecutionState> deployLocalTask(
             @NonNull TaskGroup taskGroup,
             @NonNull CompletableFuture<TaskExecutionState> resultFuture) {

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org