You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by "PengZheng (via GitHub)" <gi...@apache.org> on 2023/10/14 09:04:33 UTC
[PR] Remove broken discovery_shm implementation. (celix)
PengZheng opened a new pull request, #670:
URL: https://github.com/apache/celix/pull/670
Though discovery_shm compiles, Zhenbao Xu has verified that it does not work any longer. IMO, discovery_zeroconfig provides a better lightweight service discovery mechanism than discovery_shm, while the latter requires a Web server, and thus is a bit more heavyweight. If needed, we could re-implemented a discovery_shm without need of a Web server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove broken discovery_shm implementation. (celix)
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #670:
URL: https://github.com/apache/celix/pull/670#issuecomment-1762748846
## [Codecov](https://app.codecov.io/gh/apache/celix/pull/670?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#670](https://app.codecov.io/gh/apache/celix/pull/670?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (813bd77) into [master](https://app.codecov.io/gh/apache/celix/commit/3974d91f093e809bd33d4cb333969f236ceb3c70?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3974d91) will **increase** coverage by `0.05%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #670 +/- ##
==========================================
+ Coverage 81.66% 81.71% +0.05%
==========================================
Files 252 252
Lines 32656 32656
==========================================
+ Hits 26669 26686 +17
+ Misses 5987 5970 -17
```
[see 5 files with indirect coverage changes](https://app.codecov.io/gh/apache/celix/pull/670/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove broken discovery_shm implementation. (celix)
Posted by "PengZheng (via GitHub)" <gi...@apache.org>.
PengZheng merged PR #670:
URL: https://github.com/apache/celix/pull/670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org