[GitHub] [superset] rusackas commented on pull request #21779: fix(plugin-chart-handlebars): Update webpack/babel config to fix build/runtime warnings/errors

[GitBox <gi...@apache.org>]

rusackas commented on PR #21779:
URL: https://github.com/apache/superset/pull/21779#issuecomment-1276713694

   Heya @zhaoyongjie / @villebro 
   
   It's true, I don't like the idea of copying over all the internals of that helper module into our codebase for a couple of reasons:
   1) It feels "gross" from a copyright/licensing/plagiarism perspective
   2) We would lose the benefit of any updates/expansions that the other project takes on.
   
   So, I'd _like_ to use this `just-handlebars-helpers` module if possible. I'm also open to competitors, but nothing obvious turns up except for [this one](https://github.com/assemble/handlebars-helpers) which seems unmaintained.
   
   I'll open up an Issue on the `just-handlebars-helpers` repo to see if they would be willing to create an EJS version. Otherwise, if we can change the babel config for a specific file path, that'd be a little more surgical than this PR currently is.
   
   However, the big question I have is: do we see any realistic risk or downslides to this change in babel config? Maybe we can approve/merge this until the day that `just-handlebars-helpers` adds EJS (maybe we write a PR there!) at which point we can lock this back down.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org