[jira] Commented: (AXIS2C-1048) axiom_soap_header_block_set_attribute duplicate namespace creation

["Milinda Lakmal Pathirage (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AXIS2C-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600036#action_12600036 ] 

Milinda Lakmal Pathirage commented on AXIS2C-1048:
--------------------------------------------------

HI Lukas,
Can you send me a way to regenerate this error. I think the bug is in the axiom_header_block_set_attribute function. It first get the prefix from the parent node and create a qname using that prefix and soap_envelope_namespace_uri given as parameter to it for the attribute. Then it calls axiom_element_get_attribute function using previously created qname for attribute.

In the first case if that function returned a attribute, set the new value of that attribute and function returns. But if we can find a attribute, we create a attribute inside the axiom_header_block_set_attribute function and add it to the om_element. 

Bug is with that new attribute creation part. It use AXIOM_SOAP_DEFAULT_NAMESPACE_PREFIX instead of prefix we found earlier to create the namespace for new attribute .

if (soap_envelope_namespace_uri)
    {
        om_ns = axiom_namespace_create(env,
                                       soap_envelope_namespace_uri,
                                       AXIOM_SOAP_DEFAULT_NAMESPACE_PREFIX);
    }

 So just changing the above axiom_namespace_create to use the prefix we found earlier from parent block, we can fix the bug.

But I need to clarify whether the bug is fixed or not by above change. It's better if you can provide a way to regenerate it.

Thanks

Milinda


> axiom_soap_header_block_set_attribute duplicate namespace creation
> ------------------------------------------------------------------
>
>                 Key: AXIS2C-1048
>                 URL: https://issues.apache.org/jira/browse/AXIS2C-1048
>             Project: Axis2-C
>          Issue Type: Improvement
>    Affects Versions: 1.2.0
>            Reporter: Lukas JOSEFIK
>            Assignee: Milinda Lakmal Pathirage
>
> axiom_soap_header_block_set_attribute creates new attribute for mustUnderstand and declare soap envelope namespace if parent has another prefix and the result follows:
>  <SOAP-ENV:Envelope xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:SOAP-ENV="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
>  <SOAP-ENV:Header>
>  <wsse:Security soapenv:mustUnderstand="1" xmlns:wsse="http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-secext-1.0.xsd" xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/"> 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org