You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/01 19:20:14 UTC
[GitHub] [airflow] potiuk commented on a change in pull request #19911: Fix mypy checks for api_connexion
potiuk commented on a change in pull request #19911:
URL: https://github.com/apache/airflow/pull/19911#discussion_r760500937
##########
File path: airflow/api_connexion/schemas/dag_schema.py
##########
@@ -86,7 +86,7 @@ class DAGDetailSchema(DAGSchema):
doc_md = fields.String()
default_view = fields.String()
params = fields.Method('get_params', dump_only=True)
- tags = fields.Method("get_tags", dump_only=True)
+ tags = fields.Method("get_tags", dump_only=True) # type: ignore
Review comment:
@mik-laj @ephraimbuddy - > I am not sure if this is a "real" bug or this assignment is valid here:
The error here is:
```
airflow/api_connexion/schemas/dag_schema.py:89: error: Incompatible types in
assignment (expression has type "Method", base class "DAGSchema" defined the
type as "marshmallow.fields.List")
tags = fields.Method("get_tags", dump_only=True)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org