You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by ma...@apache.org on 2004/12/27 21:20:35 UTC
svn commit: r123447 - /struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java
Author: martinc
Date: Mon Dec 27 12:20:32 2004
New Revision: 123447
URL: http://svn.apache.org/viewcvs?view=rev&rev=123447
Log:
Bug #32016: Wrap the hidden token field in a <div> element for HTML 4.01 Strict compliance.
Modified:
struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java
Modified: struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java
Url: http://svn.apache.org/viewcvs/struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java?view=diff&rev=123447&p1=struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java&r1=123446&p2=struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java&r2=123447
==============================================================================
--- struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java (original)
+++ struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java Mon Dec 27 12:20:32 2004
@@ -529,7 +529,8 @@
}
/**
- * Generates a hidden input field with token information, if any.
+ * Generates a hidden input field with token information, if any. The
+ * field is added within a div element for HTML 4.01 Strict compliance.
* @return A hidden input field containing the token.
* @since Struts 1.1
*/
@@ -542,7 +543,7 @@
(String) session.getAttribute(Globals.TRANSACTION_TOKEN_KEY);
if (token != null) {
- results.append("<input type=\"hidden\" name=\"");
+ results.append("<div><input type=\"hidden\" name=\"");
results.append(Constants.TOKEN_KEY);
results.append("\" value=\"");
results.append(token);
@@ -551,6 +552,7 @@
} else {
results.append("\">");
}
+ results.append("</div>");
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Missing svn commit: r123447
Posted by Niall Pemberton <ni...@blueyonder.co.uk>.
I was looking at the history of revisions for FormTag in the taglib sub
project using ViewCVS - there is no record of Martin's Revision 123447.
However looking into it further - the code changes to FormTag are there but
they're showing under revision 12703 - which was Don's revision extracting
taglibs to their own sub project.
So looks like we lost the history?
Niall
----- Original Message -----
From: "James Mitchell" <jm...@apache.org>
To: "Struts Developers List" <de...@struts.apache.org>
Sent: Wednesday, February 02, 2005 12:36 AM
Subject: Re: Missing svn commit: r123447
> What do you mean? The files are there, did we lose the history or
> properties or something?
>
> --
> James Mitchell
> Software Engineer / Open Source Evangelist
> EdgeTech, Inc.
> 678.910.8017
> AIM: jmitchtx
>
> ----- Original Message -----
> From: "Niall Pemberton" <ni...@blueyonder.co.uk>
> To: "Struts Developers List" <de...@struts.apache.org>
> Sent: Tuesday, February 01, 2005 12:56 PM
> Subject: Missing svn commit: r123447
>
>
> > This commit seems to have gone missing - I don't see it in the new
> > "taglib"
> > sub-project. I'm guessing this happened when Don extracted the taglibs
out
> > of core and into their own sub-project? All I can see from the commit
> > message when taglibs were moved on 30/12/2004 is the following...
> >
> > struts/taglib/trunk/src/java/org/apache/struts/taglib/html/
> > - copied from r122972,
> > struts/core/trunk/src/share/org/apache/struts/taglib/html/
> >
> > Am wondering if we've lost anything else in the re-organisation?
> >
> > Niall
> >
> > ----- Original Message -----
> > From: <ma...@apache.org>
> > To: <co...@struts.apache.org>
> > Sent: Monday, December 27, 2004 8:20 PM
> > Subject: svn commit: r123447 -
> > /struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java
> >
> >
> >> Author: martinc
> >> Date: Mon Dec 27 12:20:32 2004
> >> New Revision: 123447
> >>
> >> URL: http://svn.apache.org/viewcvs?view=rev&rev=123447
> >> Log:
> >> Bug #32016: Wrap the hidden token field in a <div> element for HTML
4.01
> > Strict compliance.
> >> Modified:
> >>
struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java
> >>
> >> Modified:
> > struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java
> >> Url:
> >
http://svn.apache.org/viewcvs/struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java?view=diff&rev=123447&p1=struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java&r1=123446&p2=struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java&r2=123447
> >>
> >
============================================================================
> > ==
> >> ---
> >> struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java
> > (original)
> >> +++
> >> struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java
> > Mon Dec 27 12:20:32 2004
> >> @@ -529,7 +529,8 @@
> >> }
> >>
> >> /**
> >> - * Generates a hidden input field with token information, if any.
> >> + * Generates a hidden input field with token information, if any.
> >> The
> >> + * field is added within a div element for HTML 4.01 Strict
> > compliance.
> >> * @return A hidden input field containing the token.
> >> * @since Struts 1.1
> >> */
> >> @@ -542,7 +543,7 @@
> >> (String)
> > session.getAttribute(Globals.TRANSACTION_TOKEN_KEY);
> >>
> >> if (token != null) {
> >> - results.append("<input type=\"hidden\" name=\"");
> >> + results.append("<div><input type=\"hidden\" name=\"");
> >> results.append(Constants.TOKEN_KEY);
> >> results.append("\" value=\"");
> >> results.append(token);
> >> @@ -551,6 +552,7 @@
> >> } else {
> >> results.append("\">");
> >> }
> >> + results.append("</div>");
> >> }
> >> }
> >>
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > For additional commands, e-mail: dev-help@struts.apache.org
> >
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Missing svn commit: r123447
Posted by James Mitchell <jm...@apache.org>.
What do you mean? The files are there, did we lose the history or
properties or something?
--
James Mitchell
Software Engineer / Open Source Evangelist
EdgeTech, Inc.
678.910.8017
AIM: jmitchtx
----- Original Message -----
From: "Niall Pemberton" <ni...@blueyonder.co.uk>
To: "Struts Developers List" <de...@struts.apache.org>
Sent: Tuesday, February 01, 2005 12:56 PM
Subject: Missing svn commit: r123447
> This commit seems to have gone missing - I don't see it in the new
> "taglib"
> sub-project. I'm guessing this happened when Don extracted the taglibs out
> of core and into their own sub-project? All I can see from the commit
> message when taglibs were moved on 30/12/2004 is the following...
>
> struts/taglib/trunk/src/java/org/apache/struts/taglib/html/
> - copied from r122972,
> struts/core/trunk/src/share/org/apache/struts/taglib/html/
>
> Am wondering if we've lost anything else in the re-organisation?
>
> Niall
>
> ----- Original Message -----
> From: <ma...@apache.org>
> To: <co...@struts.apache.org>
> Sent: Monday, December 27, 2004 8:20 PM
> Subject: svn commit: r123447 -
> /struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java
>
>
>> Author: martinc
>> Date: Mon Dec 27 12:20:32 2004
>> New Revision: 123447
>>
>> URL: http://svn.apache.org/viewcvs?view=rev&rev=123447
>> Log:
>> Bug #32016: Wrap the hidden token field in a <div> element for HTML 4.01
> Strict compliance.
>> Modified:
>> struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java
>>
>> Modified:
> struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java
>> Url:
> http://svn.apache.org/viewcvs/struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java?view=diff&rev=123447&p1=struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java&r1=123446&p2=struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java&r2=123447
>>
> ============================================================================
> ==
>> ---
>> struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java
> (original)
>> +++
>> struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java
> Mon Dec 27 12:20:32 2004
>> @@ -529,7 +529,8 @@
>> }
>>
>> /**
>> - * Generates a hidden input field with token information, if any.
>> + * Generates a hidden input field with token information, if any.
>> The
>> + * field is added within a div element for HTML 4.01 Strict
> compliance.
>> * @return A hidden input field containing the token.
>> * @since Struts 1.1
>> */
>> @@ -542,7 +543,7 @@
>> (String)
> session.getAttribute(Globals.TRANSACTION_TOKEN_KEY);
>>
>> if (token != null) {
>> - results.append("<input type=\"hidden\" name=\"");
>> + results.append("<div><input type=\"hidden\" name=\"");
>> results.append(Constants.TOKEN_KEY);
>> results.append("\" value=\"");
>> results.append(token);
>> @@ -551,6 +552,7 @@
>> } else {
>> results.append("\">");
>> }
>> + results.append("</div>");
>> }
>> }
>>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Missing svn commit: r123447
Posted by Niall Pemberton <ni...@blueyonder.co.uk>.
This commit seems to have gone missing - I don't see it in the new "taglib"
sub-project. I'm guessing this happened when Don extracted the taglibs out
of core and into their own sub-project? All I can see from the commit
message when taglibs were moved on 30/12/2004 is the following...
struts/taglib/trunk/src/java/org/apache/struts/taglib/html/
- copied from r122972,
struts/core/trunk/src/share/org/apache/struts/taglib/html/
Am wondering if we've lost anything else in the re-organisation?
Niall
----- Original Message -----
From: <ma...@apache.org>
To: <co...@struts.apache.org>
Sent: Monday, December 27, 2004 8:20 PM
Subject: svn commit: r123447 -
/struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java
> Author: martinc
> Date: Mon Dec 27 12:20:32 2004
> New Revision: 123447
>
> URL: http://svn.apache.org/viewcvs?view=rev&rev=123447
> Log:
> Bug #32016: Wrap the hidden token field in a <div> element for HTML 4.01
Strict compliance.
> Modified:
> struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java
>
> Modified:
struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java
> Url:
http://svn.apache.org/viewcvs/struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java?view=diff&rev=123447&p1=struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java&r1=123446&p2=struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java&r2=123447
>
============================================================================
==
> --- struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java
(original)
> +++ struts/core/trunk/src/share/org/apache/struts/taglib/html/FormTag.java
Mon Dec 27 12:20:32 2004
> @@ -529,7 +529,8 @@
> }
>
> /**
> - * Generates a hidden input field with token information, if any.
> + * Generates a hidden input field with token information, if any. The
> + * field is added within a div element for HTML 4.01 Strict
compliance.
> * @return A hidden input field containing the token.
> * @since Struts 1.1
> */
> @@ -542,7 +543,7 @@
> (String)
session.getAttribute(Globals.TRANSACTION_TOKEN_KEY);
>
> if (token != null) {
> - results.append("<input type=\"hidden\" name=\"");
> + results.append("<div><input type=\"hidden\" name=\"");
> results.append(Constants.TOKEN_KEY);
> results.append("\" value=\"");
> results.append(token);
> @@ -551,6 +552,7 @@
> } else {
> results.append("\">");
> }
> + results.append("</div>");
> }
> }
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org