You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lo...@apache.org on 2016/08/29 05:32:39 UTC
svn commit: r1758165 [6/7] - /myfaces/site/publish/tobago/
Modified: myfaces/site/publish/tobago/pmd.html
URL: http://svn.apache.org/viewvc/myfaces/site/publish/tobago/pmd.html?rev=1758165&r1=1758164&r2=1758165&view=diff
==============================================================================
--- myfaces/site/publish/tobago/pmd.html (original)
+++ myfaces/site/publish/tobago/pmd.html Mon Aug 29 05:32:39 2016
@@ -14,7 +14,7 @@
<div class="date">
- Last Published: 03 Aug 2016
+ Last Published: 28 Aug 2016
</div>
<ul>
<li>
@@ -271,6 +271,20 @@
<div class="section">
<h2><a name="Files"></a>Files</h2>
<div class="section">
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagoajaxAjaxUtils.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/ajax/AjaxUtils.java</h3>
+ <table border="0" class="bodyTable">
+ <tr class="a">
+ <th>Violation</th>
+ <th>Line</th>
+ </tr>
+ <tr class="b">
+ <td>Avoid unused private fields such as 'LOG'.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/ajax/AjaxUtils.html#L41">41</a></td>
+ </tr>
+ </table>
+ </div>
+ <div class="section">
<h3><a name="Tobago_Core_-_orgapachemyfacestobagocomponentAttributes.java"></a>Tobago Core -
org/apache/myfaces/tobago/component/Attributes.java</h3>
<table border="0" class="bodyTable">
@@ -280,16 +294,39 @@
</tr>
<tr class="b">
<td>Parameter 'explicit' is not assigned and could be declared final</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Attributes.html#L277">277</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/Attributes.html#L271">271</a></td>
</tr>
<tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Attributes.html#L282">282</a>–<a
- href="./xref/org/apache/myfaces/tobago/component/Attributes.html#L286">286</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/Attributes.html#L276">276</a>–<a
+ href="./xref/org/apache/myfaces/tobago/component/Attributes.html#L280">280</a></td>
</tr>
<tr class="b">
<td>Parameter 'name' is not assigned and could be declared final</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Attributes.html#L289">289</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/Attributes.html#L283">283</a></td>
+ </tr>
+ </table>
+ </div>
+ <div class="section">
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagocomponentFacets.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/component/Facets.java</h3>
+ <table border="0" class="bodyTable">
+ <tr class="a">
+ <th>Violation</th>
+ <th>Line</th>
+ </tr>
+ <tr class="b">
+ <td>Perhaps 'event' could be replaced by a local variable.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/Facets.html#L66">66</a></td>
+ </tr>
+ <tr class="a">
+ <td>Document empty constructor</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/Facets.html#L68">68</a>–<a
+ href="./xref/org/apache/myfaces/tobago/component/Facets.html#L69">69</a></td>
+ </tr>
+ <tr class="b">
+ <td>Parameter 'event' is not assigned and could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/Facets.html#L71">71</a></td>
</tr>
</table>
</div>
@@ -386,27 +423,27 @@
href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L258">258</a></td>
</tr>
<tr class="a">
- <td>The class 'Sorter' has a Cyclomatic Complexity of 8 (Highest = 30).</td>
+ <td>The class 'Sorter' has a Modified Cyclomatic Complexity of 6 (Highest = 28).</td>
<td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L49">49</a>–<a
href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L258">258</a></td>
</tr>
<tr class="b">
- <td>The class 'Sorter' has a Modified Cyclomatic Complexity of 6 (Highest = 28).</td>
+ <td>The class 'Sorter' has a Cyclomatic Complexity of 8 (Highest = 30).</td>
<td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L49">49</a>–<a
href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L258">258</a></td>
</tr>
<tr class="a">
- <td>The method 'perform' has a Cyclomatic Complexity of 30.</td>
+ <td>The method 'perform' has a Standard Cyclomatic Complexity of 28.</td>
<td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L64">64</a>–<a
href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L201">201</a></td>
</tr>
<tr class="b">
- <td>The method perform() has an NPath complexity of 139872</td>
+ <td>Avoid really long methods.</td>
<td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L64">64</a>–<a
href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L201">201</a></td>
</tr>
<tr class="a">
- <td>Avoid really long methods.</td>
+ <td>The method perform() has an NPath complexity of 139872</td>
<td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L64">64</a>–<a
href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L201">201</a></td>
</tr>
@@ -416,7 +453,7 @@
href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L201">201</a></td>
</tr>
<tr class="a">
- <td>The method 'perform' has a Standard Cyclomatic Complexity of 28.</td>
+ <td>The method 'perform' has a Cyclomatic Complexity of 30.</td>
<td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L64">64</a>–<a
href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L201">201</a></td>
</tr>
@@ -442,34 +479,16 @@
</table>
</div>
<div class="section">
- <h3><a name="Tobago_Core_-_orgapachemyfacestobagocomponentSupportsAjaxBehaviorHolder.java"></a>Tobago Core -
- org/apache/myfaces/tobago/component/SupportsAjaxBehaviorHolder.java</h3>
- <table border="0" class="bodyTable">
- <tr class="b">
- <th>Violation</th>
- <th>Line</th>
- </tr>
- <tr class="a">
- <td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/SupportsAjaxBehaviorHolder.html#L28">28</a></td>
- </tr>
- <tr class="b">
- <td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/SupportsAjaxBehaviorHolder.html#L32">32</a></td>
- </tr>
- </table>
- </div>
- <div class="section">
<h3><a name="Tobago_Core_-_orgapachemyfacestobagocomponentSupportsRenderedPartially.java"></a>Tobago Core -
org/apache/myfaces/tobago/component/SupportsRenderedPartially.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/SupportsRenderedPartially.html#L27">27</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/SupportsRenderedPartially.html#L32">32</a></td>
</tr>
</table>
</div>
@@ -477,11 +496,11 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagocontextClientProperties.java"></a>Tobago Core -
org/apache/myfaces/tobago/context/ClientProperties.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Use equals() to compare object references.</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ClientProperties.html#L133">133</a></td>
</tr>
@@ -491,71 +510,66 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagocontextMarkup.java"></a>Tobago Core -
org/apache/myfaces/tobago/context/Markup.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
- <td>The class 'Markup' has a Cyclomatic Complexity of 5 (Highest = 11).</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L57">57</a>–<a
- href="./xref/org/apache/myfaces/tobago/context/Markup.html#L369">369</a></td>
- </tr>
<tr class="a">
- <td>The class 'Markup' has a Standard Cyclomatic Complexity of 5 (Highest = 10).</td>
+ <td>This class has too many methods, consider refactoring it.</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L57">57</a>–<a
href="./xref/org/apache/myfaces/tobago/context/Markup.html#L369">369</a></td>
</tr>
<tr class="b">
- <td>This class has too many methods, consider refactoring it.</td>
+ <td>The class 'Markup' has a Modified Cyclomatic Complexity of 5 (Highest = 10).</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L57">57</a>–<a
href="./xref/org/apache/myfaces/tobago/context/Markup.html#L369">369</a></td>
</tr>
<tr class="a">
- <td>The class 'Markup' has a Modified Cyclomatic Complexity of 5 (Highest = 10).</td>
+ <td>The class 'Markup' has a Cyclomatic Complexity of 5 (Highest = 11).</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L57">57</a>–<a
href="./xref/org/apache/myfaces/tobago/context/Markup.html#L369">369</a></td>
</tr>
<tr class="b">
+ <td>The class 'Markup' has a Standard Cyclomatic Complexity of 5 (Highest = 10).</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L57">57</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/Markup.html#L369">369</a></td>
+ </tr>
+ <tr class="a">
<td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L115">115</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L125">125</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L185">185</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L197">197</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L198">198</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Use equals() to compare object references.</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L221">221</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L224">224</a>–<a
href="./xref/org/apache/myfaces/tobago/context/Markup.html#L235">235</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L265">265</a>–<a
href="./xref/org/apache/myfaces/tobago/context/Markup.html#L274">274</a></td>
</tr>
- <tr class="b">
- <td>The method 'contains' has a Modified Cyclomatic Complexity of 10.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L326">326</a>–<a
- href="./xref/org/apache/myfaces/tobago/context/Markup.html#L356">356</a></td>
- </tr>
<tr class="a">
- <td>The method 'contains' has a Standard Cyclomatic Complexity of 10.</td>
+ <td>The method 'contains' has a Modified Cyclomatic Complexity of 10.</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L326">326</a>–<a
href="./xref/org/apache/myfaces/tobago/context/Markup.html#L356">356</a></td>
</tr>
@@ -565,20 +579,25 @@
href="./xref/org/apache/myfaces/tobago/context/Markup.html#L356">356</a></td>
</tr>
<tr class="a">
+ <td>The method 'contains' has a Standard Cyclomatic Complexity of 10.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L326">326</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/Markup.html#L356">356</a></td>
+ </tr>
+ <tr class="b">
<td>Use equals() to compare object references.</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L327">327</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L333">333</a>–<a
href="./xref/org/apache/myfaces/tobago/context/Markup.html#L355">355</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L334">334</a>–<a
href="./xref/org/apache/myfaces/tobago/context/Markup.html#L343">343</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L345">345</a>–<a
href="./xref/org/apache/myfaces/tobago/context/Markup.html#L354">354</a></td>
@@ -589,11 +608,11 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagocontextMarkupConfig.java"></a>Tobago Core -
org/apache/myfaces/tobago/context/MarkupConfig.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Private field 'markups' could be made final; it is only initialized in the declaration or
constructor.
</td>
@@ -605,19 +624,19 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagocontextResourceManagerUtils.java"></a>Tobago Core -
org/apache/myfaces/tobago/context/ResourceManagerUtils.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>This call to String.startsWith can be rewritten using String.charAt(0)</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ResourceManagerUtils.html#L184">184</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Local variable 'dot' could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ResourceManagerUtils.html#L194">194</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Local variable 'slash' could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ResourceManagerUtils.html#L198">198</a></td>
</tr>
@@ -627,22 +646,27 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagocontextThemeImpl.java"></a>Tobago Core -
org/apache/myfaces/tobago/context/ThemeImpl.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Possible God class (WMC=60, ATFD=16, TCC=0.07816091954022988)</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L20">20</a>–<a
href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L314">314</a></td>
</tr>
+ <tr class="b">
+ <td>The class 'ThemeImpl' has a Standard Cyclomatic Complexity of 2 (Highest = 12).</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L33">33</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L314">314</a></td>
+ </tr>
<tr class="a">
- <td>The class 'ThemeImpl' has a Modified Cyclomatic Complexity of 2 (Highest = 12).</td>
+ <td>Too many fields</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L33">33</a>–<a
href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L314">314</a></td>
</tr>
<tr class="b">
- <td>Too many fields</td>
+ <td>The class 'ThemeImpl' has a Modified Cyclomatic Complexity of 2 (Highest = 12).</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L33">33</a>–<a
href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L314">314</a></td>
</tr>
@@ -652,126 +676,121 @@
href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L314">314</a></td>
</tr>
<tr class="b">
- <td>The class 'ThemeImpl' has a Standard Cyclomatic Complexity of 2 (Highest = 12).</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L33">33</a>–<a
- href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L314">314</a></td>
- </tr>
- <tr class="a">
<td>Private field 'productionResources' could be made final; it is only initialized in the declaration or
constructor.
</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L46">46</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Private field 'resources' could be made final; it is only initialized in the declaration or
constructor.
</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L47">47</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Avoid using redundant field initializer for 'unmodifiable'</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L55">55</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Deeply nested if..then statements are hard to read</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L154">154</a>–<a
href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L159">159</a></td>
</tr>
- <tr class="a">
- <td>The method 'toString' has a Standard Cyclomatic Complexity of 12.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L273">273</a>–<a
- href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L313">313</a></td>
- </tr>
<tr class="b">
<td>The method 'toString' has a Cyclomatic Complexity of 12.</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L273">273</a>–<a
href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L313">313</a></td>
</tr>
<tr class="a">
- <td>The method 'toString' has a Modified Cyclomatic Complexity of 12.</td>
+ <td>The method 'toString' has a Standard Cyclomatic Complexity of 12.</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L273">273</a>–<a
href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L313">313</a></td>
</tr>
<tr class="b">
+ <td>The method 'toString' has a Modified Cyclomatic Complexity of 12.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L273">273</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L313">313</a></td>
+ </tr>
+ <tr class="a">
<td>StringBuffer constructor is initialized with size 16, but has at least 112 characters appended.</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L274">274</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L275">275</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L276">276</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L278">278</a>–<a
href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L284">284</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid appending characters as strings in StringBuffer.append.</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L279">279</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Avoid appending characters as strings in StringBuffer.append.</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L281">281</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Local variable 's' could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L286">286</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L286">286</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid appending characters as strings in StringBuffer.append.</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L287">287</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L291">291</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Local variable 's' could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L291">291</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Avoid appending characters as strings in StringBuffer.append.</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L292">292</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L296">296</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Local variable 's' could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L296">296</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid appending characters as strings in StringBuffer.append.</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L297">297</a></td>
</tr>
- <tr class="a">
- <td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L301">301</a></td>
- </tr>
<tr class="b">
<td>Local variable 's' could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L301">301</a></td>
</tr>
<tr class="a">
+ <td>Avoid if (x != y) ..; else ..;</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L301">301</a></td>
+ </tr>
+ <tr class="b">
<td>Avoid appending characters as strings in StringBuffer.append.</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L302">302</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid appending characters as strings in StringBuffer.append.</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L306">306</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Avoid appending characters as strings in StringBuffer.append.</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L309">309</a></td>
</tr>
@@ -781,15 +800,15 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagocontextThemeResource.java"></a>Tobago Core -
org/apache/myfaces/tobago/context/ThemeResource.java</h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeResource.html#L50">50</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeResource.html#L56">56</a></td>
</tr>
@@ -799,19 +818,19 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagocontextThemeResources.java"></a>Tobago Core -
org/apache/myfaces/tobago/context/ThemeResources.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Parameter 'production' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeResources.html#L39">39</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Parameter 'exclude' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeResources.html#L67">67</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Parameter 'exclude' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeResources.html#L71">71</a></td>
</tr>
@@ -821,11 +840,11 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagocontextTobagoBundle.java"></a>Tobago Core -
org/apache/myfaces/tobago/context/TobagoBundle.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Private field 'bundleName' could be made final; it is only initialized in the declaration or
constructor.
</td>
@@ -837,11 +856,11 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagocontextTransientStateHolder.java"></a>Tobago Core -
org/apache/myfaces/tobago/context/TransientStateHolder.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Document empty constructor</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/TransientStateHolder.html#L33">33</a>–<a
href="./xref/org/apache/myfaces/tobago/context/TransientStateHolder.html#L34">34</a></td>
@@ -852,17 +871,12 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagocontextUserAgent.java"></a>Tobago Core -
org/apache/myfaces/tobago/context/UserAgent.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
- <td>The class 'UserAgent' has a Modified Cyclomatic Complexity of 3 (Highest = 19).</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L33">33</a>–<a
- href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L390">390</a></td>
- </tr>
<tr class="a">
- <td>The class 'UserAgent' has a Cyclomatic Complexity of 3 (Highest = 20).</td>
+ <td>The class 'UserAgent' has a Modified Cyclomatic Complexity of 3 (Highest = 19).</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L33">33</a>–<a
href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L390">390</a></td>
</tr>
@@ -872,54 +886,59 @@
href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L390">390</a></td>
</tr>
<tr class="a">
+ <td>The class 'UserAgent' has a Cyclomatic Complexity of 3 (Highest = 20).</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L33">33</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L390">390</a></td>
+ </tr>
+ <tr class="b">
<td>The String literal "msie" appears 12 times in this file; the first occurrence is on line
43
</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L43">43</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>The String literal "opera" appears 4 times in this file; the first occurrence is on line
107
</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L107">107</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>The String literal "mozilla" appears 4 times in this file; the first occurrence is on line
131
</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L131">131</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>The String literal "gecko" appears 5 times in this file; the first occurrence is on line
154
</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L154">154</a></td>
</tr>
- <tr class="a">
- <td>The method 'getInstance' has a Modified Cyclomatic Complexity of 19.</td>
+ <tr class="b">
+ <td>The method 'getInstance' has a Standard Cyclomatic Complexity of 19.</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L279">279</a>–<a
href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L334">334</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>The method 'getInstance' has a Cyclomatic Complexity of 20.</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L279">279</a>–<a
href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L334">334</a></td>
</tr>
- <tr class="a">
- <td>The method 'getInstance' has a Standard Cyclomatic Complexity of 19.</td>
+ <tr class="b">
+ <td>The method 'getInstance' has a Modified Cyclomatic Complexity of 19.</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L279">279</a>–<a
href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L334">334</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L350">350</a>–<a
href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L352">352</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L364">364</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L382">382</a></td>
</tr>
@@ -929,19 +948,19 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagoconvertDurationConverter.java"></a>Tobago Core -
org/apache/myfaces/tobago/convert/DurationConverter.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Unnecessary wrapper object creation</td>
<td><a href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L65">65</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Avoid declaring a variable if it is unreferenced before a possible exit point.</td>
<td><a href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L89">89</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>The default label should be the last label in a switch statement</td>
<td><a href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L129">129</a>–<a
href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L145">145</a></td>
@@ -952,70 +971,70 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagoelConstantMethodExpression.java"></a>Tobago Core -
org/apache/myfaces/tobago/el/ConstantMethodExpression.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Document empty constructor</td>
<td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L35">35</a>–<a
href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L36">36</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Parameter 'outcome' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L38">38</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Parameter 'context' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L43">43</a></td>
</tr>
- <tr class="a">
- <td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L49">49</a></td>
- </tr>
<tr class="b">
- <td>Parameter 'params' is not assigned and could be declared final</td>
+ <td>Parameter 'context' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L49">49</a></td>
</tr>
<tr class="a">
- <td>Parameter 'context' is not assigned and could be declared final</td>
+ <td>Parameter 'params' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L49">49</a></td>
</tr>
<tr class="b">
+ <td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L49">49</a></td>
+ </tr>
+ <tr class="a">
<td>Parameter 'o' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L55">55</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Local variable 'that' could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L63">63</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L65">65</a></td>
</tr>
- <tr class="a">
- <td>Parameter 'context' is not assigned and could be declared final</td>
- <td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L85">85</a></td>
- </tr>
<tr class="b">
<td>Parameter 'context' is not assigned and could be declared final</td>
- <td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L90">90</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L85">85</a></td>
</tr>
<tr class="a">
<td>Parameter 'state' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L90">90</a></td>
</tr>
+ <tr class="b">
+ <td>Parameter 'context' is not assigned and could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L90">90</a></td>
+ </tr>
</table>
</div>
<div class="section">
<h3><a name="Tobago_Core_-_orgapachemyfacestobagoelUserWrapper.java"></a>Tobago Core -
org/apache/myfaces/tobago/el/UserWrapper.java</h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Private field 'roles' could be made final; it is only initialized in the declaration or constructor.
</td>
<td><a href="./xref/org/apache/myfaces/tobago/el/UserWrapper.html#L35">35</a></td>
@@ -1026,23 +1045,23 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventCollapsibleActionListener.java"></a>Tobago Core -
org/apache/myfaces/tobago/event/CollapsibleActionListener.java</h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
- <td>Parameter 'context' is not assigned and could be declared final</td>
- <td><a href="./xref/org/apache/myfaces/tobago/event/CollapsibleActionListener.html#L69">69</a></td>
- </tr>
<tr class="b">
<td>Parameter 'context' is not assigned and could be declared final</td>
- <td><a href="./xref/org/apache/myfaces/tobago/event/CollapsibleActionListener.html#L74">74</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/CollapsibleActionListener.html#L69">69</a></td>
</tr>
<tr class="a">
<td>Parameter 'state' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/CollapsibleActionListener.html#L74">74</a></td>
</tr>
<tr class="b">
+ <td>Parameter 'context' is not assigned and could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/CollapsibleActionListener.html#L74">74</a></td>
+ </tr>
+ <tr class="a">
<td>Parameter 'transientFlag' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/CollapsibleActionListener.html#L84">84</a></td>
</tr>
@@ -1052,11 +1071,11 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventFacesEventWrapper.java"></a>Tobago Core -
org/apache/myfaces/tobago/event/FacesEventWrapper.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Private field 'wrappedFacesEvent' could be made final; it is only initialized in the declaration or
constructor.
</td>
@@ -1068,16 +1087,16 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventMethodExpressionStateChangeListener.java"></a>Tobago
Core - org/apache/myfaces/tobago/event/MethodExpressionStateChangeListener.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid using redundant field initializer for 'isTransient'</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionStateChangeListener.html#L33">33</a>
</td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Document empty constructor</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionStateChangeListener.html#L35">35</a>–<a
href="./xref/org/apache/myfaces/tobago/event/MethodExpressionStateChangeListener.html#L36">36</a></td>
@@ -1088,16 +1107,16 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventMethodExpressionTabChangeListener.java"></a>Tobago Core
- org/apache/myfaces/tobago/event/MethodExpressionTabChangeListener.java</h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Avoid using redundant field initializer for 'isTransient'</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTabChangeListener.html#L33">33</a>
</td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Document empty constructor</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTabChangeListener.html#L35">35</a>–<a
href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTabChangeListener.html#L36">36</a></td>
@@ -1108,22 +1127,22 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventMethodExpressionTreeExpansionListener.java"></a>Tobago
Core - org/apache/myfaces/tobago/event/MethodExpressionTreeExpansionListener.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid using redundant field initializer for 'isTransient'</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeExpansionListener.html#L34">34</a>
</td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Document empty constructor</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeExpansionListener.html#L36">36</a>–<a
href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeExpansionListener.html#L37">37</a>
</td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid unused private methods such as 'elContext()'.</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeExpansionListener.html#L48">48</a>
</td>
@@ -1134,22 +1153,22 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventMethodExpressionTreeSelectedListener.java"></a>Tobago
Core - org/apache/myfaces/tobago/event/MethodExpressionTreeSelectedListener.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid using redundant field initializer for 'isTransient'</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeSelectedListener.html#L33">33</a>
</td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Document empty constructor</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeSelectedListener.html#L35">35</a>–<a
href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeSelectedListener.html#L36">36</a>
</td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid unused private methods such as 'elContext()'.</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeSelectedListener.html#L47">47</a>
</td>
@@ -1160,11 +1179,11 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventPageAction.java"></a>Tobago Core -
org/apache/myfaces/tobago/event/PageAction.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/PageAction.html#L85">85</a>–<a
href="./xref/org/apache/myfaces/tobago/event/PageAction.html#L89">89</a></td>
@@ -1175,11 +1194,11 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventPageActionEvent.java"></a>Tobago Core -
org/apache/myfaces/tobago/event/PageActionEvent.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Private field 'action' could be made final; it is only initialized in the declaration or
constructor.
</td>
@@ -1191,16 +1210,16 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventResetInputActionListener.java"></a>Tobago Core -
org/apache/myfaces/tobago/event/ResetInputActionListener.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Document empty constructor</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/ResetInputActionListener.html#L34">34</a>–<a
href="./xref/org/apache/myfaces/tobago/event/ResetInputActionListener.html#L35">35</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/ResetInputActionListener.html#L37">37</a></td>
</tr>
@@ -1210,11 +1229,11 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventSortActionEvent.java"></a>Tobago Core -
org/apache/myfaces/tobago/event/SortActionEvent.java</h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Private field 'column' could be made final; it is only initialized in the declaration or
constructor.
</td>
@@ -1226,17 +1245,17 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventTreeExpansionEvent.java"></a>Tobago Core -
org/apache/myfaces/tobago/event/TreeExpansionEvent.java</h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Private field 'oldExpanded' could be made final; it is only initialized in the declaration or
constructor.
</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/TreeExpansionEvent.html#L30">30</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Private field 'newExpanded' could be made final; it is only initialized in the declaration or
constructor.
</td>
@@ -1248,17 +1267,17 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventTreeSelectedEvent.java"></a>Tobago Core -
org/apache/myfaces/tobago/event/TreeSelectedEvent.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Private field 'oldSelected' could be made final; it is only initialized in the declaration or
constructor.
</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/TreeSelectedEvent.html#L30">30</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Private field 'newSelected' could be made final; it is only initialized in the declaration or
constructor.
</td>
@@ -1270,11 +1289,11 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventValueExpressionResetInputActionListener.java"></a>Tobago
Core - org/apache/myfaces/tobago/event/ValueExpressionResetInputActionListener.java</h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Document empty constructor</td>
<td><a
href="./xref/org/apache/myfaces/tobago/event/ValueExpressionResetInputActionListener.html#L44">44</a>–<a
@@ -1287,25 +1306,25 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventValueExpressionSheetStateChangeListener.java"></a>Tobago
Core - org/apache/myfaces/tobago/event/ValueExpressionSheetStateChangeListener.java</h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Document empty constructor</td>
<td><a
href="./xref/org/apache/myfaces/tobago/event/ValueExpressionSheetStateChangeListener.html#L37">37</a>–<a
href="./xref/org/apache/myfaces/tobago/event/ValueExpressionSheetStateChangeListener.html#L38">38</a>
</td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a
href="./xref/org/apache/myfaces/tobago/event/ValueExpressionSheetStateChangeListener.html#L48">48</a>–<a
href="./xref/org/apache/myfaces/tobago/event/ValueExpressionSheetStateChangeListener.html#L52">52</a>
</td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>No need to check for null before an instanceof</td>
<td><a
href="./xref/org/apache/myfaces/tobago/event/ValueExpressionSheetStateChangeListener.html#L85">85</a>
@@ -1317,21 +1336,21 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventValueExpressionTabChangeListener.java"></a>Tobago Core -
org/apache/myfaces/tobago/event/ValueExpressionTabChangeListener.java</h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Document empty constructor</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/ValueExpressionTabChangeListener.html#L37">37</a>–<a
href="./xref/org/apache/myfaces/tobago/event/ValueExpressionTabChangeListener.html#L38">38</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/ValueExpressionTabChangeListener.html#L48">48</a>–<a
href="./xref/org/apache/myfaces/tobago/event/ValueExpressionTabChangeListener.html#L52">52</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>No need to check for null before an instanceof</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/ValueExpressionTabChangeListener.html#L85">85</a></td>
</tr>
@@ -1341,88 +1360,88 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagofaceletsAttributeHandler.java"></a>Tobago Core -
org/apache/myfaces/tobago/facelets/AttributeHandler.java</h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
- <td>A high number of imports can indicate a high degree of coupling within an object.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L20">20</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L361">361</a></td>
- </tr>
<tr class="b">
- <td>Possible God class (WMC=78, ATFD=88, TCC=0.027777777777777776)</td>
+ <td>A high number of imports can indicate a high degree of coupling within an object.</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L20">20</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L361">361</a></td>
+ href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L354">354</a></td>
</tr>
<tr class="a">
- <td>The class 'AttributeHandler' has a Standard Cyclomatic Complexity of 6 (Highest = 51).</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L56">56</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L361">361</a></td>
+ <td>Possible God class (WMC=75, ATFD=82, TCC=0.027777777777777776)</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L20">20</a>–<a
+ href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L354">354</a></td>
</tr>
<tr class="b">
- <td>The class 'AttributeHandler' has a Modified Cyclomatic Complexity of 6 (Highest = 51).</td>
+ <td>The class 'AttributeHandler' has a Standard Cyclomatic Complexity of 6 (Highest = 49).</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L56">56</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L361">361</a></td>
+ href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L354">354</a></td>
</tr>
<tr class="a">
- <td>The class 'AttributeHandler' has a Cyclomatic Complexity of 7 (Highest = 58).</td>
+ <td>The class 'AttributeHandler' has a Cyclomatic Complexity of 7 (Highest = 55).</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L56">56</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L361">361</a></td>
+ href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L354">354</a></td>
</tr>
<tr class="b">
- <td>The method apply() has an NCSS line count of 162</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L74">74</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L278">278</a></td>
+ <td>The class 'AttributeHandler' has a Modified Cyclomatic Complexity of 6 (Highest = 49).</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L56">56</a>–<a
+ href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L354">354</a></td>
</tr>
<tr class="a">
- <td>The method 'apply' has a Standard Cyclomatic Complexity of 51.</td>
+ <td>The method 'apply' has a Standard Cyclomatic Complexity of 49.</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L74">74</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L278">278</a></td>
+ href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L271">271</a></td>
</tr>
<tr class="b">
- <td>The method 'apply' has a Modified Cyclomatic Complexity of 51.</td>
+ <td>Avoid really long methods.</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L74">74</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L278">278</a></td>
+ href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L271">271</a></td>
</tr>
<tr class="a">
- <td>The method 'apply' has a Cyclomatic Complexity of 58.</td>
+ <td>The method 'apply' has a Modified Cyclomatic Complexity of 49.</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L74">74</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L278">278</a></td>
+ href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L271">271</a></td>
</tr>
<tr class="b">
- <td>Avoid really long methods.</td>
+ <td>The method 'apply' has a Cyclomatic Complexity of 55.</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L74">74</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L278">278</a></td>
+ href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L271">271</a></td>
</tr>
<tr class="a">
+ <td>The method apply() has an NCSS line count of 155</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L74">74</a>–<a
+ href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L271">271</a></td>
+ </tr>
+ <tr class="b">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L81">81</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L276">276</a></td>
+ href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L269">269</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L85">85</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L103">103</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L108">108</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L126">126</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L194">194</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L201">201</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L302">302</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L295">295</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L308">308</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L314">314</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L301">301</a>–<a
+ href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L307">307</a></td>
</tr>
</table>
</div>
@@ -1430,19 +1449,19 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagofaceletsConverterHandler.java"></a>Tobago Core -
org/apache/myfaces/tobago/facelets/ConverterHandler.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid declaring a variable if it is unreferenced before a possible exit point.</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/ConverterHandler.html#L54">54</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>New exception is thrown in catch block, original stack trace may be lost</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/ConverterHandler.html#L66">66</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Deeply nested if..then statements are hard to read</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/ConverterHandler.html#L68">68</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/ConverterHandler.html#L70">70</a></td>
@@ -1453,11 +1472,11 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagofaceletsFixCharacterEncodingFilter.java"></a>Tobago Core -
org/apache/myfaces/tobago/facelets/FixCharacterEncodingFilter.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Document empty method</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/FixCharacterEncodingFilter.html#L57">57</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/FixCharacterEncodingFilter.html#L58">58</a></td>
@@ -1468,15 +1487,15 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagofaceletsGridLayoutConstraintHandler.java"></a>Tobago Core -
org/apache/myfaces/tobago/facelets/GridLayoutConstraintHandler.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid reassigning parameters such as 'parent'</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/GridLayoutConstraintHandler.html#L49">49</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Avoid reassigning parameters such as 'parent'</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/GridLayoutConstraintHandler.html#L49">49</a></td>
</tr>
@@ -1486,23 +1505,23 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagofaceletsMetaInfResourcesClasspathResourceResolver.java"></a>Tobago
Core - org/apache/myfaces/tobago/facelets/MetaInfResourcesClasspathResourceResolver.java</h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Avoid reassigning parameters such as 'path'</td>
<td><a
href="./xref/org/apache/myfaces/tobago/facelets/MetaInfResourcesClasspathResourceResolver.html#L55">55</a>
</td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid reassigning parameters such as 'path'</td>
<td><a
href="./xref/org/apache/myfaces/tobago/facelets/MetaInfResourcesClasspathResourceResolver.html#L55">55</a>
</td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>This call to String.startsWith can be rewritten using String.charAt(0)</td>
<td><a
href="./xref/org/apache/myfaces/tobago/facelets/MetaInfResourcesClasspathResourceResolver.html#L61">61</a>
@@ -1514,21 +1533,21 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagofaceletsResource.java"></a>Tobago Core -
org/apache/myfaces/tobago/facelets/Resource.java</h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
+ <tr class="b">
<td>These nested if statements could be combined</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/Resource.html#L72">72</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/Resource.html#L74">74</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Document empty method</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/Resource.html#L114">114</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/Resource.html#L115">115</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/Resource.html#L136">136</a></td>
</tr>
@@ -1538,11 +1557,11 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagofaceletsScriptHandler.java"></a>Tobago Core -
org/apache/myfaces/tobago/facelets/ScriptHandler.java</h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Document empty method</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/ScriptHandler.html#L50">50</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/ScriptHandler.html#L51">51</a></td>
@@ -1553,35 +1572,35 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagofaceletsSegmentLayoutRule.java"></a>Tobago Core -
org/apache/myfaces/tobago/facelets/SegmentLayoutRule.java</h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
+ <tr class="b">
<td>These nested if statements could be combined</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutRule.html#L39">39</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutRule.html#L53">53</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Local variable 'a' could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutRule.html#L40">40</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Deeply nested if..then statements are hard to read</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutRule.html#L41">41</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutRule.html#L43">43</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Deeply nested if..then statements are hard to read</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutRule.html#L44">44</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutRule.html#L46">46</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Deeply nested if..then statements are hard to read</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutRule.html#L47">47</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutRule.html#L49">49</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Deeply nested if..then statements are hard to read</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutRule.html#L50">50</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutRule.html#L52">52</a></td>
@@ -1592,11 +1611,11 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagofaceletsSheetStateChangeSourceRule.java"></a>Tobago Core -
org/apache/myfaces/tobago/facelets/SheetStateChangeSourceRule.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>These nested if statements could be combined</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/SheetStateChangeSourceRule.html#L41">41</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/SheetStateChangeSourceRule.html#L43">43</a></td>
@@ -1607,11 +1626,11 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagofaceletsSortActionSourceRule.java"></a>Tobago Core -
org/apache/myfaces/tobago/facelets/SortActionSourceRule.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>These nested if statements could be combined</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/SortActionSourceRule.html#L42">42</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/SortActionSourceRule.html#L44">44</a></td>
@@ -1622,26 +1641,26 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagofaceletsSuggestMethodRule.java"></a>Tobago Core -
org/apache/myfaces/tobago/facelets/SuggestMethodRule.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>These nested if statements could be combined</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/SuggestMethodRule.html#L42">42</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/SuggestMethodRule.html#L44">44</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>These nested if statements could be combined</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/SuggestMethodRule.html#L47">47</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/SuggestMethodRule.html#L51">51</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Deeply nested if..then statements are hard to read</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/SuggestMethodRule.html#L48">48</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/SuggestMethodRule.html#L50">50</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>These nested if statements could be combined</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/SuggestMethodRule.html#L48">48</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/SuggestMethodRule.html#L50">50</a></td>
@@ -1649,66 +1668,30 @@
</table>
</div>
<div class="section">
- <h3><a name="Tobago_Core_-_orgapachemyfacestobagofaceletsSupportsAjaxBehaviorHolderRule.java"></a>Tobago Core
- - org/apache/myfaces/tobago/facelets/SupportsAjaxBehaviorHolderRule.java</h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagofaceletsSupportsMarkupRule.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/facelets/SupportsMarkupRule.java</h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
- <td>Local variable 'a' could be declared final</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/SupportsAjaxBehaviorHolderRule.html#L45">45</a>
- </td>
- </tr>
<tr class="b">
- <td>Parameter 'tobagoAttribute' is not assigned and could be declared final</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/SupportsAjaxBehaviorHolderRule.html#L64">64</a>
- </td>
+ <td>Local variable 'a' could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/SupportsMarkupRule.html#L41">41</a></td>
</tr>
+ </table>
+ </div>
+ <div class="section">
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagofaceletsSupportsRenderedPartiallyRule.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/facelets/SupportsRenderedPartiallyRule.java</h3>
+ <table border="0" class="bodyTable">
<tr class="a">
- <td>Local variable 'supportsRenderedPartially' could be declared final</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/SupportsAjaxBehaviorHolderRule.html#L81">81</a>
- </td>
- </tr>
- <tr class="b">
- <td>Parameter 'behaviorHolder' is not assigned and could be declared final</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/SupportsAjaxBehaviorHolderRule.html#L99">99</a>
- </td>
- </tr>
- <tr class="a">
- <td>Parameter 'faceletContext' is not assigned and could be declared final</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/SupportsAjaxBehaviorHolderRule.html#L99">99</a>
- </td>
- </tr>
- <tr class="b">
- <td>Local variable 'clientBehaviors' could be declared final</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/SupportsAjaxBehaviorHolderRule.html#L100">100</a>
- </td>
- </tr>
- <tr class="a">
- <td>Local variable 'behaviors' could be declared final</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/SupportsAjaxBehaviorHolderRule.html#L102">102</a>
- </td>
- </tr>
- <tr class="b">
- <td>Local variable 'cb' could be declared final</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/SupportsAjaxBehaviorHolderRule.html#L104">104</a>
- </td>
- </tr>
- </table>
- </div>
- <div class="section">
- <h3><a name="Tobago_Core_-_orgapachemyfacestobagofaceletsSupportsMarkupRule.java"></a>Tobago Core -
- org/apache/myfaces/tobago/facelets/SupportsMarkupRule.java</h3>
- <table border="0" class="bodyTable">
- <tr class="a">
- <th>Violation</th>
- <th>Line</th>
+ <th>Violation</th>
+ <th>Line</th>
</tr>
<tr class="b">
<td>Local variable 'a' could be declared final</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/SupportsMarkupRule.html#L41">41</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/SupportsRenderedPartiallyRule.html#L41">41</a></td>
</tr>
</table>
</div>
@@ -2097,31 +2080,31 @@
</tr>
<tr class="a">
<td>Avoid unused private fields such as 'LOG'.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUICommand.html#L49">49</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUICommand.html#L47">47</a></td>
</tr>
<tr class="b">
<td>Local variable 'operation' could be declared final</td>
- <td><a href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUICommand.html#L65">65</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUICommand.html#L63">63</a></td>
</tr>
<tr class="a">
<td>Avoid instantiating new objects inside loops</td>
- <td><a href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUICommand.html#L66">66</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUICommand.html#L64">64</a></td>
</tr>
<tr class="b">
<td>Local variable 'child' could be declared final</td>
- <td><a href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUICommand.html#L112">112</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUICommand.html#L110">110</a></td>
</tr>
<tr class="a">
<td>Do not use if statements that are always true or always false</td>
- <td><a href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUICommand.html#L130">130</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUICommand.html#L128">128</a></td>
</tr>
<tr class="b">
<td>Local variable 'bool' could be declared final</td>
- <td><a href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUICommand.html#L142">142</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUICommand.html#L140">140</a></td>
</tr>
<tr class="a">
<td>Parameter 'disabled' is not assigned and could be declared final</td>
- <td><a href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUICommand.html#L149">149</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUICommand.html#L147">147</a></td>
</tr>
</table>
</div>
@@ -2181,21 +2164,6 @@
</table>
</div>
<div class="section">
- <h3><a name="Tobago_Core_-_orgapachemyfacestobagointernalcomponentAbstractUIDate.java"></a>Tobago Core -
- org/apache/myfaces/tobago/internal/component/AbstractUIDate.java</h3>
- <table border="0" class="bodyTable">
- <tr class="a">
- <th>Violation</th>
- <th>Line</th>
- </tr>
- <tr class="b">
- <td>These nested if statements could be combined</td>
- <td><a href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUIDate.html#L43">43</a>–<a
- href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUIDate.html#L46">46</a></td>
- </tr>
- </table>
- </div>
- <div class="section">
<h3><a name="Tobago_Core_-_orgapachemyfacestobagointernalcomponentAbstractUIFlexLayout.java"></a>Tobago Core -
org/apache/myfaces/tobago/internal/component/AbstractUIFlexLayout.java</h3>
<table border="0" class="bodyTable">
@@ -2207,8 +2175,8 @@
<td>No abstract method which means that the keyword is most likely used to prevent instantiation. Use a
private or protected constructor instead.
</td>
- <td><a href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUIFlexLayout.html#L31">31</a>–<a
- href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUIFlexLayout.html#L34">34</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUIFlexLayout.html#L29">29</a>–<a
+ href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUIFlexLayout.html#L32">32</a></td>
</tr>
</table>
</div>
@@ -2263,13 +2231,13 @@
</td>
</tr>
<tr class="b">
- <td>Avoid appending characters as strings in StringBuffer.append.</td>
+ <td>StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
+ </td>
<td><a href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUIGridLayout.html#L92">92</a>
</td>
</tr>
<tr class="a">
- <td>StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
- </td>
+ <td>Avoid appending characters as strings in StringBuffer.append.</td>
[... 11111 lines stripped ...]