You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "XuNeo (via GitHub)" <gi...@apache.org> on 2024/10/26 17:55:19 UTC
[PR] lvgldemo: allow to customize input dev path [nuttx-apps]
XuNeo opened a new pull request, #2776:
URL: https://github.com/apache/nuttx-apps/pull/2776
## Summary
Default to /dev/input0, now it's configurable.
## Impact
No functionality change after this change. Impact is minor.
## Testing
Tested with `sim:lvgl_fb`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] lvgldemo: allow to customize input dev path [nuttx-apps]
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #2776:
URL: https://github.com/apache/nuttx-apps/pull/2776#discussion_r1817929310
##########
examples/lvgldemo/Kconfig:
##########
@@ -20,4 +20,14 @@ config EXAMPLES_LVGLDEMO_STACKSIZE
int "lvgldemo stack size"
default 16384
+if INPUT_TOUCHSCREEN
+
+config EXAMPLES_LVGLDEMO_INPUT_DEVPATH
+ string "Touchscreen device path"
+ default "/dev/input0"
+ ---help---
Review Comment:
Let's use `depends on INPUT_TOUCHSCREEN` here instead of `if INPUT_TOUCHSCREEN` wrapper
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] lvgldemo: allow to customize input dev path [nuttx-apps]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #2776:
URL: https://github.com/apache/nuttx-apps/pull/2776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] lvgldemo: allow to customize input dev path [nuttx-apps]
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #2776:
URL: https://github.com/apache/nuttx-apps/pull/2776#discussion_r1817929310
##########
examples/lvgldemo/Kconfig:
##########
@@ -20,4 +20,14 @@ config EXAMPLES_LVGLDEMO_STACKSIZE
int "lvgldemo stack size"
default 16384
+if INPUT_TOUCHSCREEN
+
+config EXAMPLES_LVGLDEMO_INPUT_DEVPATH
+ string "Touchscreen device path"
+ default "/dev/input0"
+ ---help---
Review Comment:
Let's use `depends on INPUT_TOUCHSCREEN` here instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] lvgldemo: allow to customize input dev path [nuttx-apps]
Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #2776:
URL: https://github.com/apache/nuttx-apps/pull/2776#issuecomment-2439678722
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
This Pull Request is **missing crucial information** required by the NuttX PR requirements.
Here's what's missing and needs to be addressed:
**Summary:**
* **Why is this change necessary?** Is it a fix for a bug? Are you adding a new feature to allow users to configure the input device? Clearly state the reason for the change.
* **What functional part of the code is being changed?** Be specific. Mention the file(s), modules, or subsystems affected by the change.
* **How does the change exactly work?** Provide a technical explanation. If you've added configuration options, explain how to use them.
**Impact:**
* **You need to be more specific for all "NO" answers.** Just saying "NO" is not sufficient. For example, instead of "Impact on build (will build process change)? NO", say "Impact on build: The build process remains unchanged." If an item is a "YES", then you MUST provide a description.
* **Target(s):** Since you've tested with `sim:lvgl_fb`, specify what architecture the simulator is running on (e.g., `sim:qemu-arm`).
**Testing:**
* **Provide actual testing logs (before and after the change).** This is essential to demonstrate the issue the PR addresses and to prove the fix works.
**To improve your PR:**
1. **Expand on the missing information** detailed above.
2. **Clearly link your PR to any related NuttX issues.** If there's no related issue, consider creating one to explain the motivation behind the change.
By providing complete and detailed information, your PR will be easier to review, understand, and ultimately merge into NuttX.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org