[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2851: ARTEMIS-2503 Improve wildcards for the roles access match

[GitBox <gi...@apache.org>]

clebertsuconic commented on a change in pull request #2851: ARTEMIS-2503 Improve wildcards for the roles access match
URL: https://github.com/apache/activemq-artemis/pull/2851#discussion_r334547881
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/management/JMXAccessControlList.java
 ##########
 @@ -25,12 +25,22 @@
 import java.util.Map;
 import java.util.concurrent.ConcurrentHashMap;
 
+import org.apache.activemq.artemis.core.config.WildcardConfiguration;
+import org.apache.activemq.artemis.core.settings.HierarchicalRepository;
+import org.apache.activemq.artemis.core.settings.impl.HierarchicalObjectRepository;
+
 public class JMXAccessControlList {
 
    private Access defaultAccess = new Access("*");
-   private Map<String, Access> domainAccess = new HashMap<>();
+   private HierarchicalRepository<Access> domainAccess;
    private ConcurrentHashMap<String, List<String>> whitelist = new ConcurrentHashMap<>();
 
+   public JMXAccessControlList() {
+      WildcardConfiguration domainAccessWildcardConfiguration = new WildcardConfiguration();
 
 Review comment:
   @michaelandrepearce my personal opinion here: can't we keep this simple.. meaning. no configuration of wildcard for management?
   
   I see this can be useful on queues.. etc.. but on management, if we could keep it simple??
   
   I mean... management and broker should be kept independent.. I wouldn't load something from broker.xml to change semantics on management... 
   
   And if you require the wildcard configuration, then you need testing..and more moving parts bound to fail and document...
   
   I would prefer to keep it simpler?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services