You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/19 08:16:43 UTC
[GitHub] [flink] c4emmmm commented on a change in pull request #8776:
[FLINK-12881][ml] Add more functionalities for ML Params and ParamInfo class
c4emmmm commented on a change in pull request #8776: [FLINK-12881][ml] Add more functionalities for ML Params and ParamInfo class
URL: https://github.com/apache/flink/pull/8776#discussion_r295173128
##########
File path: flink-ml-parent/flink-ml-api/src/test/java/org/apache/flink/ml/api/misc/ParamsTest.java
##########
@@ -39,7 +40,18 @@ public void testDefaultBehavior() {
ParamInfo<String> optionalWithoutDefault =
ParamInfoFactory.createParamInfo("a", String.class).build();
- assert params.get(optionalWithoutDefault) == null;
+ /**
+ * It should call params.contain to check when get the param in this case.
+ *
+ * example:
+ *
+ * in {@link HasPredDetailColName}, it should be optional, and has not default value.
Review comment:
I suppose we should not link from flink-ml-api model to a param defined in flink-ml-lib. flink-ml-api should be independent. Please check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services