[GitHub] [flink] AHeise commented on a change in pull request #10931: [FLINK-15603][metrics] Add checkpointStartDelay metric

[GitBox <gi...@apache.org>]

AHeise commented on a change in pull request #10931: [FLINK-15603][metrics] Add checkpointStartDelay metric
URL: https://github.com/apache/flink/pull/10931#discussion_r369991681
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierHandler.java
 ##########
 @@ -95,4 +101,10 @@ protected void notifyAbortOnCancellationBarrier(long checkpointId) throws Except
 	protected void notifyAbort(long checkpointId, CheckpointException cause) throws Exception {
 		toNotifyOnCheckpoint.abortCheckpointOnBarrier(checkpointId, cause);
 	}
+
+	protected void markCheckpointStart(long checkpointCreationTimestamp) {
+		latestCheckpointStartDelayNanos = 1000_000 * Math.max(
 
 Review comment:
   1_000_000, while you usually don't use a separator up to 9999, once you start, you use it consistently every 3 places.
   Why storing it as nanos at all? Should we just track it as ms and only display it as nano (for consistency?). We are faking a precision that is not there.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services