You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "jonvex (via GitHub)" <gi...@apache.org> on 2023/03/30 15:22:49 UTC

[GitHub] [hudi] jonvex opened a new pull request, #8327: [HUDI-5361] Propagate all hoodie configs from spark sqlconf, but don't overwrite values already set

jonvex opened a new pull request, #8327:
URL: https://github.com/apache/hudi/pull/8327

   ### Change Logs
   
   _Describe context and summary for this change. Highlight if any code was copied._
   
   ### Impact
   
   _Describe any public API or user-facing feature change or any performance impact._
   
   ### Risk level (write none, low medium or high below)
   
   _If medium or high, explain what verification was done to mitigate the risks._
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, config, or user-facing change_
   
   - _The config description must be updated if new configs are added or the default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
     ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8327: [HUDI-5361] Propagate all hoodie configs from spark sqlconf, but don't overwrite values already set

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8327:
URL: https://github.com/apache/hudi/pull/8327#issuecomment-1672385859

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b3388a3bb559227d2415e747681326f6109b4cc2",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15998",
       "triggerID" : "b3388a3bb559227d2415e747681326f6109b4cc2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "94e4c2e74c6170ceee8c303f7237bd10f2cd334f",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19232",
       "triggerID" : "94e4c2e74c6170ceee8c303f7237bd10f2cd334f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 94e4c2e74c6170ceee8c303f7237bd10f2cd334f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19232) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] codope merged pull request #8327: [HUDI-5361] Propagate all hoodie configs from spark sqlconf, but don't overwrite values already set

Posted by "codope (via GitHub)" <gi...@apache.org>.
codope merged PR #8327:
URL: https://github.com/apache/hudi/pull/8327


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8327: [HUDI-5361] Propagate all hoodie configs from spark sqlconf, but don't overwrite values already set

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8327:
URL: https://github.com/apache/hudi/pull/8327#issuecomment-1672232135

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b3388a3bb559227d2415e747681326f6109b4cc2",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15998",
       "triggerID" : "b3388a3bb559227d2415e747681326f6109b4cc2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "94e4c2e74c6170ceee8c303f7237bd10f2cd334f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19232",
       "triggerID" : "94e4c2e74c6170ceee8c303f7237bd10f2cd334f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b3388a3bb559227d2415e747681326f6109b4cc2 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15998) 
   * 94e4c2e74c6170ceee8c303f7237bd10f2cd334f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19232) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8327: [HUDI-5361] Propagate all hoodie configs from spark sqlconf, but don't overwrite values already set

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8327:
URL: https://github.com/apache/hudi/pull/8327#issuecomment-1490745211

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b3388a3bb559227d2415e747681326f6109b4cc2",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15998",
       "triggerID" : "b3388a3bb559227d2415e747681326f6109b4cc2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b3388a3bb559227d2415e747681326f6109b4cc2 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15998) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] rahil-c commented on pull request #8327: [HUDI-5361] Propagate all hoodie configs from spark sqlconf, but don't overwrite values already set

Posted by "rahil-c (via GitHub)" <gi...@apache.org>.
rahil-c commented on PR #8327:
URL: https://github.com/apache/hudi/pull/8327#issuecomment-1577486780

   Thanks @jonvex for opening this up again. I tested this change for incremental queries without any issues and was wondering if we can land this if others do not have concerns.
   
   cc @xushiyan @yihua 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8327: [HUDI-5361] Propagate all hoodie configs from spark sqlconf, but don't overwrite values already set

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8327:
URL: https://github.com/apache/hudi/pull/8327#issuecomment-1672221796

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b3388a3bb559227d2415e747681326f6109b4cc2",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15998",
       "triggerID" : "b3388a3bb559227d2415e747681326f6109b4cc2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "94e4c2e74c6170ceee8c303f7237bd10f2cd334f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "94e4c2e74c6170ceee8c303f7237bd10f2cd334f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b3388a3bb559227d2415e747681326f6109b4cc2 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15998) 
   * 94e4c2e74c6170ceee8c303f7237bd10f2cd334f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] jonvex closed pull request #8327: [HUDI-5361] Propagate all hoodie configs from spark sqlconf, but don't overwrite values already set

Posted by "jonvex (via GitHub)" <gi...@apache.org>.
jonvex closed pull request #8327: [HUDI-5361] Propagate all hoodie configs from spark sqlconf, but don't overwrite values already set
URL: https://github.com/apache/hudi/pull/8327


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8327: [HUDI-5361] Propagate all hoodie configs from spark sqlconf, but don't overwrite values already set

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8327:
URL: https://github.com/apache/hudi/pull/8327#issuecomment-1490519396

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b3388a3bb559227d2415e747681326f6109b4cc2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b3388a3bb559227d2415e747681326f6109b4cc2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b3388a3bb559227d2415e747681326f6109b4cc2 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8327: [HUDI-5361] Propagate all hoodie configs from spark sqlconf, but don't overwrite values already set

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8327:
URL: https://github.com/apache/hudi/pull/8327#issuecomment-1490532346

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b3388a3bb559227d2415e747681326f6109b4cc2",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15998",
       "triggerID" : "b3388a3bb559227d2415e747681326f6109b4cc2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b3388a3bb559227d2415e747681326f6109b4cc2 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15998) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org