You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/15 17:32:40 UTC

[GitHub] [airflow] dimberman commented on a change in pull request #13080: KubernetesExecutor overrides should only append to lists

dimberman commented on a change in pull request #13080:
URL: https://github.com/apache/airflow/pull/13080#discussion_r543544646



##########
File path: airflow/kubernetes/pod_generator.py
##########
@@ -501,14 +505,18 @@ def reconcile_containers(base_containers,
         client_container = client_containers[0]
         base_container = base_containers[0]
         client_container = extend_object_field(
-            base_container,
-            client_container,
-            'volume_mounts',
-            'mount_path')

Review comment:
       Hi @potiuk this removal is deliberate as that is how it is treated in 2.0. 2.0 only allows appends to lists. I believe this actually wroks out nicely as when there are multiple of hte same value k8s will just take the last value.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org