You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/10 11:07:42 UTC
[GitHub] [airflow] turbaszek opened a new pull request #12981: Add possibility to check if upgrade check rule applies
turbaszek opened a new pull request #12981:
URL: https://github.com/apache/airflow/pull/12981
closes: #12897
```
root@36cdf678d49c:/opt/airflow# airflow upgrade_check
================================================ STATUS ================================================
Check for latest versions of apache-airflow and checker.......................................FAIL
Remove airflow.AirflowMacroPlugin class.......................................................SUCCESS
Chain between DAG and operator not allowed....................................................SUCCESS
Connection.conn_id is not unique..............................................................SUCCESS
Connection.conn_type is not nullable..........................................................SUCCESS
Ensure users are not using custom metaclasses in custom operators.............................SUCCESS
Fernet is enabled by default..................................................................SUCCESS
GCP service account key deprecation...........................................................SUCCESS
Unify hostname_callable option in core section................................................FAIL
Changes in import paths of hooks, operators, sensors and others...............................FAIL
Legacy UI is deprecated by default............................................................SUCCESS
Logging configuration has been moved to new section...........................................SUCCESS
Removal of Mesos Executor.....................................................................SUCCESS
Users must set a kubernetes.pod_template_file value...........................................SKIPPED
SendGrid email uses old airflow.contrib module................................................SUCCESS
Changes in import path of remote task handlers................................................SUCCESS
Jinja Template Variables cannot be undefined..................................................SUCCESS
Found 8 problems.
=========================================== RECOMMENDATIONS ============================================
Check for latest versions of apache-airflow and checker
-------------------------------------------------------
Check that the latest version of apache-airflow-upgrade-check is installed, and
that you are on the latest 1.10.x release of apache-airflow.
Problems:
1. There is a more recent version of apache-airflow-upgrade-check. Please upgrade to 1.0.0 and re-run this script
Unify hostname_callable option in core section
----------------------------------------------
Problems:
1. Error: hostname_callable `socket:getfqdn` contains a colon instead of a dot. please change to `socket.getfqdn`
Changes in import paths of hooks, operators, sensors and others
---------------------------------------------------------------
Many hooks, operators and other classes has been renamed and moved. Those changes were part of unifying names and imports paths as described in AIP-21.
The `contrib` folder has been replaced by `providers` directory and packages:
https://github.com/apache/airflow#backport-packages
Problems:
1. Using `airflow.operators.bash_operator.BashOperator` will be replaced by `airflow.operators.bash.BashOperator`. Affected file: /files/dags/blogpost.py
2. Using `airflow.operators.python_operator.PythonOperator` will be replaced by `airflow.operators.python.PythonOperator`. Affected file: /files/dags/blogpost.py
3. Using `airflow.operators.bash_operator.BashOperator` will be replaced by `airflow.operators.bash.BashOperator`. Affected file: /files/dags/none-from-time-to-time.py
4. Using `airflow.operators.bash_operator.BashOperator` will be replaced by `airflow.operators.bash.BashOperator`. Affected file: /files/dags/td_test.py
5. Using `airflow.operators.python_operator.PythonOperator` will be replaced by `airflow.operators.python.PythonOperator`. Affected file: /files/dags/td_test.py
Users must set a kubernetes.pod_template_file value
---------------------------------------------------
Skipped because this rule applies only to environment using KubernetesExecutor.
```
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #12981: Add possibility to check if upgrade check rule applies
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #12981:
URL: https://github.com/apache/airflow/pull/12981#issuecomment-742452374
CC @vikramkoka
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek merged pull request #12981: Add possibility to check if upgrade check rule applies
Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #12981:
URL: https://github.com/apache/airflow/pull/12981
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #12981: Add possibility to check if upgrade check rule applies
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #12981:
URL: https://github.com/apache/airflow/pull/12981#issuecomment-742532111
The tests should now pass once you rebase it on v1-10-stable again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12981: Add possibility to check if upgrade check rule applies
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12981:
URL: https://github.com/apache/airflow/pull/12981#issuecomment-742472385
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org