You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "yaooqinn (via GitHub)" <gi...@apache.org> on 2025/08/29 10:14:58 UTC

[PR] [SPARK-53437][SQL] InterpretedUnsafeProjection shall setNull4Bytes for YearMonthIntervalType field [spark]

yaooqinn opened a new pull request, #52178:
URL: https://github.com/apache/spark/pull/52178

   ### What changes were proposed in this pull request?
   
   
   InterpretedUnsafeProjection shall setNull4Bytes for a YearMonthIntervalType field instead of setNull8Bytes
   
   ### Why are the changes needed?
   
   YearMonthIntervalType is 4-byte length
   
   ### Does this PR introduce _any_ user-facing change?
   'No'.
   
   
   
   ### How was this patch tested?
   Passing CI
   
   ### Was this patch authored or co-authored using generative AI tooling?
   no


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-53437][SQL] InterpretedUnsafeProjection shall setNull4Bytes for YearMonthIntervalType field [spark]

Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #52178:
URL: https://github.com/apache/spark/pull/52178#issuecomment-3240686618

   cc @cloud-fan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-53437][SQL] InterpretedUnsafeProjection shall setNull4Bytes for YearMonthIntervalType field [spark]

Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #52178:
URL: https://github.com/apache/spark/pull/52178#discussion_r2312819942


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/InterpretedUnsafeProjection.scala:
##########
@@ -268,7 +268,7 @@ object InterpretedUnsafeProjection {
             writer.setNull2Bytes(i)
           }
         }
-      case IntegerType | DateType | FloatType =>
+      case IntegerType | DateType | FloatType | _: YearMonthIntervalType =>

Review Comment:
   Based on my analysis, these additional 4-byte portions will be overwritten by the next value. It's kinda safe here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-53437][SQL] InterpretedUnsafeProjection shall setNull4Bytes for YearMonthIntervalType field [spark]

Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #52178:
URL: https://github.com/apache/spark/pull/52178#issuecomment-3240767365

   Merged to master, thank you @cloud-fan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-53437][SQL] InterpretedUnsafeProjection shall setNull4Bytes for YearMonthIntervalType field [spark]

Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #52178:
URL: https://github.com/apache/spark/pull/52178#discussion_r2312802475


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/InterpretedUnsafeProjection.scala:
##########
@@ -268,7 +268,7 @@ object InterpretedUnsafeProjection {
             writer.setNull2Bytes(i)
           }
         }
-      case IntegerType | DateType | FloatType =>
+      case IntegerType | DateType | FloatType | _: YearMonthIntervalType =>

Review Comment:
   good catch! Does it cause any actual issues?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-53437][SQL] InterpretedUnsafeProjection shall setNull4Bytes for YearMonthIntervalType field [spark]

Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn closed pull request #52178: [SPARK-53437][SQL] InterpretedUnsafeProjection shall setNull4Bytes for YearMonthIntervalType field
URL: https://github.com/apache/spark/pull/52178


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org