You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by "Dave Wolf (JIRA)" <ji...@apache.org> on 2007/11/25 14:56:43 UTC
[jira] Created: (JSPWIKI-57) UserManager & JSONUserModule missing
Serializable
UserManager & JSONUserModule missing Serializable
--------------------------------------------------
Key: JSPWIKI-57
URL: https://issues.apache.org/jira/browse/JSPWIKI-57
Project: JSPWiki
Issue Type: Bug
Components: Authentication&Authorization
Affects Versions: 2.6.0
Environment: All
Reporter: Dave Wolf
Priority: Trivial
Fix For: 2.6.0
Errors being thrown in Catalina logs complaining that the UserManager and its inner class JSONUserModule not being Serializable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-57) UserManager & JSONUserModule missing
Serializable
Posted by "Olaf Kock (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552666 ]
Olaf Kock commented on JSPWIKI-57:
----------------------------------
A quick fix for this issue is to configure a non-serializeable session manager that doesn't attempt to save anything to disk, therefor does not need any serializable stuff.
As far as I recall, in tomcat 5.5 you set pathname="", as documented here: http://tomcat.apache.org/tomcat-5.5-doc/config/manager.html
But as said above: It's not really an error, just an annoying, non-fatal, log entry that shouldn't be there.
> UserManager & JSONUserModule missing Serializable
> --------------------------------------------------
>
> Key: JSPWIKI-57
> URL: https://issues.apache.org/jira/browse/JSPWIKI-57
> Project: JSPWiki
> Issue Type: Bug
> Components: Core & storage
> Affects Versions: 2.6.0
> Environment: All
> Reporter: Dave Wolf
> Priority: Trivial
> Fix For: 2.8
>
> Attachments: 20071125-patch.txt
>
>
> Errors being thrown in Catalina logs complaining that the UserManager and its inner class JSONUserModule not being Serializable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-57) UserManager & JSONUserModule missing
Serializable
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545297 ]
Janne Jalkanen commented on JSPWIKI-57:
---------------------------------------
The exception is mostly harmless, but I agree it is annoying.
> UserManager & JSONUserModule missing Serializable
> --------------------------------------------------
>
> Key: JSPWIKI-57
> URL: https://issues.apache.org/jira/browse/JSPWIKI-57
> Project: JSPWiki
> Issue Type: Bug
> Components: Core & storage
> Affects Versions: 2.6.0
> Environment: All
> Reporter: Dave Wolf
> Priority: Trivial
> Attachments: 20071125-patch.txt
>
>
> Errors being thrown in Catalina logs complaining that the UserManager and its inner class JSONUserModule not being Serializable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-57) UserManager & JSONUserModule missing
Serializable
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605087#action_12605087 ]
Janne Jalkanen commented on JSPWIKI-57:
---------------------------------------
No it has not... I know exactly what the issue is (JSONGlobalBridge), but I don't quite know what to do about it.
> UserManager & JSONUserModule missing Serializable
> --------------------------------------------------
>
> Key: JSPWIKI-57
> URL: https://issues.apache.org/jira/browse/JSPWIKI-57
> Project: JSPWiki
> Issue Type: Bug
> Components: Core & storage
> Affects Versions: 2.6.0
> Environment: All
> Reporter: Dave Wolf
> Priority: Trivial
> Fix For: 2.8
>
> Attachments: 20071125-patch.txt
>
>
> Errors being thrown in Catalina logs complaining that the UserManager and its inner class JSONUserModule not being Serializable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JSPWIKI-57) UserManager & JSONUserModule missing
Serializable
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-57?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Janne Jalkanen resolved JSPWIKI-57.
-----------------------------------
Resolution: Fixed
Fixed in 2.7.0-svn-42.
> UserManager & JSONUserModule missing Serializable
> --------------------------------------------------
>
> Key: JSPWIKI-57
> URL: https://issues.apache.org/jira/browse/JSPWIKI-57
> Project: JSPWiki
> Issue Type: Bug
> Components: Core & storage
> Affects Versions: 2.6.0
> Environment: All
> Reporter: Dave Wolf
> Priority: Trivial
> Fix For: 2.8
>
> Attachments: 20071125-patch.txt, JSPWIKI-57-stacktrace.txt
>
>
> Errors being thrown in Catalina logs complaining that the UserManager and its inner class JSONUserModule not being Serializable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (JSPWIKI-57) UserManager & JSONUserModule missing Serializable
Posted by Janne Jalkanen <Ja...@ecyrd.com>.
On 14 Jun 2008, at 23:37, Andrew Jaquith wrote:
> There is nothing in JSONUserModuke that requires it to have
> privileged access to any of UserManager's innards. So it could
> easily be made into a stand-alone class.
>
> As for the direct reference, is there some way we could obtain the
> UserManager via lookup rather than maintaining a hard reference?
> That would solve the problem...
Probably. Since it's an AJAX thing, having a bit of speed might be a
good idea; but if we put in a volatile field referencing UserManager
and look it up if it's missing, it should work fine.
/Janne
Re: [jira] Commented: (JSPWIKI-57) UserManager & JSONUserModule
missing Serializable
Posted by Andrew Jaquith <an...@mac.com>.
There is nothing in JSONUserModuke that requires it to have privileged
access to any of UserManager's innards. So it could easily be made
into a stand-alone class.
As for the direct reference, is there some way we could obtain the
UserManager via lookup rather than maintaining a hard reference? That
would solve the problem...
On Jun 14, 2008, at 3:01 PM, Janne Jalkanen <Ja...@ecyrd.com>
wrote:
>
> The problem is that the jsonrpc lib puts the JSON objects in the
> session. And since JSONUserModule is not a static class, it
> contains a reference to UserManager. Which in turn makes the
> container serialize the whole shebang...
>
> One trick would be to make the reference volatile. But that would
> mean that whenever the container deserializes the whole thing, the
> JSONUserModule is no longer valid, and will break horribly.
>
> /Janne
>
> On Jun 14, 2008, at 21:15 , Andrew Jaquith wrote:
>
>> Forgive my ignorance, but why does UserManager need to be
>> serializable?It is a manager class, not an object that needs to be
>> persisted. Is there an object reference or something we can remove?
>>
>> On Jun 14, 2008, at 12:09 PM, "Harry Metske (JIRA)"
>> <ji...@apache.org> wrote:
>>
>>>
>>> [ https://issues.apache.org/jira/browse/JSPWIKI-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605084#action_12605084
>>> ]
>>>
>>> Harry Metske commented on JSPWIKI-57:
>>> -------------------------------------
>>>
>>> The last time I have seen this exception in my logs is 2 May 2008,
>>> and I regularly upgrade my wiki's to the latest version. Has it
>>> been fixed in between?
>>>
>>>> UserManager & JSONUserModule missing Serializable
>>>> --------------------------------------------------
>>>>
>>>> Key: JSPWIKI-57
>>>> URL: https://issues.apache.org/jira/browse/JSPWIKI-57
>>>> Project: JSPWiki
>>>> Issue Type: Bug
>>>> Components: Core & storage
>>>> Affects Versions: 2.6.0
>>>> Environment: All
>>>> Reporter: Dave Wolf
>>>> Priority: Trivial
>>>> Fix For: 2.8
>>>>
>>>> Attachments: 20071125-patch.txt
>>>>
>>>>
>>>> Errors being thrown in Catalina logs complaining that the
>>>> UserManager and its inner class JSONUserModule not being
>>>> Serializable.
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> -
>>> You can reply to this email to add a comment to the issue online.
>>>
>
Re: [jira] Commented: (JSPWIKI-57) UserManager & JSONUserModule missing Serializable
Posted by Janne Jalkanen <Ja...@ecyrd.com>.
The problem is that the jsonrpc lib puts the JSON objects in the
session. And since JSONUserModule is not a static class, it contains
a reference to UserManager. Which in turn makes the container
serialize the whole shebang...
One trick would be to make the reference volatile. But that would
mean that whenever the container deserializes the whole thing, the
JSONUserModule is no longer valid, and will break horribly.
/Janne
On Jun 14, 2008, at 21:15 , Andrew Jaquith wrote:
> Forgive my ignorance, but why does UserManager need to be
> serializable?It is a manager class, not an object that needs to be
> persisted. Is there an object reference or something we can remove?
>
> On Jun 14, 2008, at 12:09 PM, "Harry Metske (JIRA)"
> <ji...@apache.org> wrote:
>
>>
>> [ https://issues.apache.org/jira/browse/JSPWIKI-57?
>> page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
>> tabpanel&focusedCommentId=12605084#action_12605084 ]
>>
>> Harry Metske commented on JSPWIKI-57:
>> -------------------------------------
>>
>> The last time I have seen this exception in my logs is 2 May 2008,
>> and I regularly upgrade my wiki's to the latest version. Has it
>> been fixed in between?
>>
>>> UserManager & JSONUserModule missing Serializable
>>> --------------------------------------------------
>>>
>>> Key: JSPWIKI-57
>>> URL: https://issues.apache.org/jira/browse/JSPWIKI-57
>>> Project: JSPWiki
>>> Issue Type: Bug
>>> Components: Core & storage
>>> Affects Versions: 2.6.0
>>> Environment: All
>>> Reporter: Dave Wolf
>>> Priority: Trivial
>>> Fix For: 2.8
>>>
>>> Attachments: 20071125-patch.txt
>>>
>>>
>>> Errors being thrown in Catalina logs complaining that the
>>> UserManager and its inner class JSONUserModule not being
>>> Serializable.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
Re: [jira] Commented: (JSPWIKI-57) UserManager & JSONUserModule
missing Serializable
Posted by Andrew Jaquith <an...@mac.com>.
Forgive my ignorance, but why does UserManager need to be serializable?
It is a manager class, not an object that needs to be persisted. Is
there an object reference or something we can remove?
On Jun 14, 2008, at 12:09 PM, "Harry Metske (JIRA)" <ji...@apache.org>
wrote:
>
> [ https://issues.apache.org/jira/browse/JSPWIKI-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605084#action_12605084
> ]
>
> Harry Metske commented on JSPWIKI-57:
> -------------------------------------
>
> The last time I have seen this exception in my logs is 2 May 2008,
> and I regularly upgrade my wiki's to the latest version. Has it been
> fixed in between?
>
>> UserManager & JSONUserModule missing Serializable
>> --------------------------------------------------
>>
>> Key: JSPWIKI-57
>> URL: https://issues.apache.org/jira/browse/JSPWIKI-57
>> Project: JSPWiki
>> Issue Type: Bug
>> Components: Core & storage
>> Affects Versions: 2.6.0
>> Environment: All
>> Reporter: Dave Wolf
>> Priority: Trivial
>> Fix For: 2.8
>>
>> Attachments: 20071125-patch.txt
>>
>>
>> Errors being thrown in Catalina logs complaining that the
>> UserManager and its inner class JSONUserModule not being
>> Serializable.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
[jira] Commented: (JSPWIKI-57) UserManager & JSONUserModule missing
Serializable
Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605084#action_12605084 ]
Harry Metske commented on JSPWIKI-57:
-------------------------------------
The last time I have seen this exception in my logs is 2 May 2008, and I regularly upgrade my wiki's to the latest version. Has it been fixed in between?
> UserManager & JSONUserModule missing Serializable
> --------------------------------------------------
>
> Key: JSPWIKI-57
> URL: https://issues.apache.org/jira/browse/JSPWIKI-57
> Project: JSPWiki
> Issue Type: Bug
> Components: Core & storage
> Affects Versions: 2.6.0
> Environment: All
> Reporter: Dave Wolf
> Priority: Trivial
> Fix For: 2.8
>
> Attachments: 20071125-patch.txt
>
>
> Errors being thrown in Catalina logs complaining that the UserManager and its inner class JSONUserModule not being Serializable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.