[jira] [Commented] (NIFI-4583) Restructure package nifi-solr-processors

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-4583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308930#comment-16308930 ] 

ASF GitHub Bot commented on NIFI-4583:
--------------------------------------

Github user ijokarumawak commented on the issue:

    https://github.com/apache/nifi/pull/2285
  
    @JohannesDaniel Thanks for the updates. Now it LGTM, +1. Merging in. Thank you for your contribution!


> Restructure package nifi-solr-processors
> ----------------------------------------
>
>                 Key: NIFI-4583
>                 URL: https://issues.apache.org/jira/browse/NIFI-4583
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Johannes Peter
>            Assignee: Johannes Peter
>            Priority: Minor
>
> Several functionalities currently implemented e. g. in GetSolr or SolrProcessor should be made available for other processors or controller services. A class SolrUtils should be created containing several static methods. This includes the methods 
> - getRequestParams (PutSolrContentStream)
> - solrDocumentsToRecordSet (GetSolr) 
> - createSolrClient (SolrProcessor)
> and the inner class QueryResponseOutputStreamCallback (GetSolr)
> Some unit tests might be affected.
> The method declaration  
> protected SolrClient createSolrClient(final ProcessContext context, final String solrLocation)
> should be changed to 
> public static SolrClient createSolrClient(final PropertyContext context, final String solrLocation)
> to be suitable also for controller services.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)