[GitHub] [ignite] ololo3000 commented on a change in pull request #9195: IGNITE-14990 Incorrect values of cache, cache group, data region metrics after cluster re-activation

[GitBox <gi...@apache.org>]

ololo3000 commented on a change in pull request #9195:
URL: https://github.com/apache/ignite/pull/9195#discussion_r659357032



##########
File path: modules/core/src/test/java/org/apache/ignite/internal/metric/CacheMetricsAddRemoveTest.java
##########
@@ -204,12 +253,14 @@ private void checkMetricsEmpty(String cachePrefix) {
 

Review comment:
       `MetricRegistry mreg = mmgr.registry(cachePrefix);`
   
   Can we just iterate over mmgr and check that there is no registry with specified name? Mentioned above call creates registry if it does not exist. I see no need for this.

##########
File path: modules/core/src/test/java/org/apache/ignite/internal/metric/CacheMetricsAddRemoveTest.java
##########
@@ -204,12 +253,14 @@ private void checkMetricsEmpty(String cachePrefix) {
 
             assertNull(mreg.findMetric(metricName(cachePrefix, CACHE_GETS)));
             assertNull(mreg.findMetric(metricName(cachePrefix, CACHE_PUTS)));
+            assertNull(mreg.findMetric(metricName(cachePrefix, GET_TIME)));

Review comment:
       Here and above, we must use mreg.findMetric(<metric_name>) without registry prefix. Otherwise, this check makes no sense and always true.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org