[jira] [Commented] (AIRFLOW-6574) Docker operator needs a private environment dict

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055401#comment-17055401 ] 

ASF GitHub Bot commented on AIRFLOW-6574:
-----------------------------------------

CaptainCuddleCube commented on pull request #7184: [AIRFLOW-6574] Adding private_environment to docker operator.
URL: https://github.com/apache/airflow/pull/7184
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Docker operator needs a private environment dict
> ------------------------------------------------
>
>                 Key: AIRFLOW-6574
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6574
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.10.7
>            Reporter: Ashton Hudson
>            Assignee: Ashton Hudson
>            Priority: Major
>              Labels: beginner, easyfix, newbie
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> The docker operator currently assigns the environment dict to the operators self, which leads to the effect that when viewing the task in the browser, it displays all the environment variables.
> This is an issue if the docker container gets it's database credentials via the environment variables.
> A proposed solution is to create a private_environment dict that is added to the operator's class with a leading underscore. Since the browser renderer excludes all class attributes with a leading underscore - the information won't be leaked.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)