[GitHub] [pinot] siddharthteotia commented on a change in pull request #7654: Enhance ColumnValueSegmentPruner and support bloom filter prefetch

[GitBox <gi...@apache.org>]

siddharthteotia commented on a change in pull request #7654:
URL: https://github.com/apache/pinot/pull/7654#discussion_r738868832



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/query/pruner/ColumnValueSegmentPruner.java
##########
@@ -164,7 +274,73 @@ private boolean pruneEqPredicate(IndexSegment segment, EqPredicate eqPredicate,
   }
 
   /**
-   * For RANGE predicate, prune the segment based on:
+   * For IN predicate, prune the segments based on:
+   * <ul>
+   *   <li>Column min/max value</li>
+   *   <li>Column bloom filter</li>
+   * </ul>
+   * <p>NOTE: segments will not be pruned if the number of values is greater than the threshold.
+   */
+  private boolean pruneInPredicate(IndexSegment segment, InPredicate inPredicate,

Review comment:
       Maybe this is just github thing that it is showing both functions as deleted and rewritten ? Apart from fetchcontext, nothing else seems to have changed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org