You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by mkedwards <gi...@git.apache.org> on 2018/11/22 12:09:27 UTC
[GitHub] zookeeper pull request #715: Rollup of blocker/critical fixes for 3.5 (to tr...
GitHub user mkedwards opened a pull request:
https://github.com/apache/zookeeper/pull/715
Rollup of blocker/critical fixes for 3.5 (to trigger CI)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mkedwards/zookeeper rollup-3.5
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/715.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #715
----
commit 3694a4e31eef9b85de59112c22ab163452610743
Author: Michael Edwards <me...@...>
Date: 2018-11-20T13:33:09Z
[ZOOKEEPER-2778] QuorumPeer: encapsulate quorum/election/client addresses in an AddressTuple held through an AtomicReference
commit 4cd10c86519b75521f89e451033dca4869d8d0d1
Author: Michael Edwards <michael edwards>
Date: 2018-11-21T08:53:54Z
[ZOOKEEPER-2778] QuorumPeer/QuorumCnxManager: address deadlock and visibility issues
commit 03d259bae3b744dc494022698fa843f6cf35e7ed
Author: Michael Edwards <michael edwards>
Date: 2018-11-21T09:01:45Z
[ZOOKEEPER-2778] QuorumPeer: add fast path for already-non-null quorum/election address
commit 0531d9c8e6a44ec531a4d8ad667307d9859bef7e
Author: Michael Edwards <michael edwards>
Date: 2018-11-21T17:13:14Z
[ZOOKEEPER-2778] QuorumPeer: fixes from code review
commit 9701f0576f53d1859d3584d0bb9730c89eb57ac1
Author: Michael Edwards <michael edwards>
Date: 2018-11-21T17:19:44Z
[ZOOKEEPER-2778] QuorumPeer: fix access to newly private data members from ReconfigTest
commit bbeeebf87391ef642059c4b3b65592c361a2ab4e
Author: Michael Edwards <michael edwards>
Date: 2018-11-21T19:48:49Z
[ZOOKEEPER-2778] LeaderBeanTest: set up mock QuorumVerifier so that addresses get set
commit 0e2b571d452306ae151b106e05d0511b09a237d3
Author: Michael Edwards <michael edwards>
Date: 2018-11-21T20:31:16Z
ZOOKEEPER-1636: cleanup completion list of a failed multi request (from Thawan Kooburat)
commit 3683a1b451fa334ba51227db327557966d319a4d
Author: Fangmin Lyu <fa...@...>
Date: 2018-11-15T17:46:51Z
ZOOKEEPER-1818: Correctly handle potentially inconsistent zxid/electionEpoch and peerEpoch during leader election
commit a1b56505671b756448f7c0126de764cd25633e2f
Author: Michael Edwards <michael edwards>
Date: 2018-11-21T21:33:01Z
Bump library versions, fix 'ant package-native tar' targets
commit 3dfd49f6bfea357c838e21d5a2e4f1486ed753e9
Author: Michael Edwards <michael edwards>
Date: 2018-11-21T23:09:55Z
ZOOKEEPER-2488: Synchronized access to shuttingDownLE in QuorumPeer
commit 1cbaec427037b8ac10004e8198821da524949843
Author: Andor Molnar <an...@...>
Date: 2018-11-19T16:25:52Z
ZOOKEEPER-3193. Refactor SaslAuthFail test to use single class. Use CountDownLatch to sync with watcher.
commit 0d4e7839eaab8b3222be31a705f9edded1ad98a5
Author: Michael Edwards <michael edwards>
Date: 2018-11-22T08:38:28Z
Add OneLinerFormatter to get semi-verbose logs with captured stdout/stderr
commit 3b19067c2a5b213e53f6e2ce7638b76250076fe6
Author: Michael Edwards <michael edwards>
Date: 2018-11-22T12:07:38Z
Throw BindException out as far as the caller of QuorumPeer.processReconfig
----
---
[GitHub] zookeeper issue #715: Rollup of blocker/critical fixes for 3.5 (to trigger C...
Posted by nkalmar <gi...@git.apache.org>.
Github user nkalmar commented on the issue:
https://github.com/apache/zookeeper/pull/715
I'm not sure what this is. Do you have a corresponding jira?
---
[GitHub] zookeeper pull request #715: Rollup of blocker/critical fixes for 3.5 (to tr...
Posted by mkedwards <gi...@git.apache.org>.
Github user mkedwards closed the pull request at:
https://github.com/apache/zookeeper/pull/715
---
[GitHub] zookeeper pull request #715: Rollup of blocker/critical fixes for 3.5 (to tr...
Posted by mkedwards <gi...@git.apache.org>.
GitHub user mkedwards reopened a pull request:
https://github.com/apache/zookeeper/pull/715
Rollup of blocker/critical fixes for 3.5 (to trigger CI)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mkedwards/zookeeper rollup-3.5
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/715.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #715
----
commit 3694a4e31eef9b85de59112c22ab163452610743
Author: Michael Edwards <me...@...>
Date: 2018-11-20T13:33:09Z
[ZOOKEEPER-2778] QuorumPeer: encapsulate quorum/election/client addresses in an AddressTuple held through an AtomicReference
commit 4cd10c86519b75521f89e451033dca4869d8d0d1
Author: Michael Edwards <michael edwards>
Date: 2018-11-21T08:53:54Z
[ZOOKEEPER-2778] QuorumPeer/QuorumCnxManager: address deadlock and visibility issues
commit 03d259bae3b744dc494022698fa843f6cf35e7ed
Author: Michael Edwards <michael edwards>
Date: 2018-11-21T09:01:45Z
[ZOOKEEPER-2778] QuorumPeer: add fast path for already-non-null quorum/election address
commit 0531d9c8e6a44ec531a4d8ad667307d9859bef7e
Author: Michael Edwards <michael edwards>
Date: 2018-11-21T17:13:14Z
[ZOOKEEPER-2778] QuorumPeer: fixes from code review
commit 9701f0576f53d1859d3584d0bb9730c89eb57ac1
Author: Michael Edwards <michael edwards>
Date: 2018-11-21T17:19:44Z
[ZOOKEEPER-2778] QuorumPeer: fix access to newly private data members from ReconfigTest
commit bbeeebf87391ef642059c4b3b65592c361a2ab4e
Author: Michael Edwards <michael edwards>
Date: 2018-11-21T19:48:49Z
[ZOOKEEPER-2778] LeaderBeanTest: set up mock QuorumVerifier so that addresses get set
commit 5038179e217a0b80805fbb6780a6fec024f9e29d
Author: Michael Edwards <michael edwards>
Date: 2018-11-22T19:21:19Z
[ZOOKEEPER-2778] QuorumPeer: warn when clobbering existing election algorithm
commit 78df674c4413561336e3435eaa692a9ec2ede0ca
Author: Michael Edwards <michael edwards>
Date: 2018-11-22T19:29:27Z
[ZOOKEEPER-2778] QuorumPeer: halt old QCM when clobbering existing election algorithm
commit d6898072947cc908ca802fa542e636d615ac29f0
Author: Fangmin Lyu <fa...@...>
Date: 2018-11-15T17:46:51Z
ZOOKEEPER-1818: Correctly handle potentially inconsistent zxid/electionEpoch and peerEpoch during leader election
commit ab30d5c8fb64b9fc93bd5e691855f6c17abd3d17
Author: Michael Edwards <michael edwards>
Date: 2018-11-21T20:31:16Z
ZOOKEEPER-1636: cleanup completion list of a failed multi request (from Thawan Kooburat)
commit e05ae82437e8a7124c5501772ce188d29ac9bfc2
Author: Michael Edwards <michael edwards>
Date: 2018-11-21T23:09:55Z
ZOOKEEPER-2488: Synchronized access to shuttingDownLE in QuorumPeer
commit bf685a609c991ac4642da42ab41c7d43d6e35246
Author: Andor Molnar <an...@...>
Date: 2018-11-19T16:25:52Z
ZOOKEEPER-3193. Refactor SaslAuthFail test to use single class. Use CountDownLatch to sync with watcher.
commit b964efbaa363fc873205acba4aefc76940a358f1
Author: Michael Edwards <michael edwards>
Date: 2018-11-21T21:33:01Z
Bump library versions, fix 'ant package-native tar' targets
commit bba8aebae6c153d21913f7391f2201c148f24f1e
Author: Michael Edwards <michael edwards>
Date: 2018-11-22T08:38:28Z
Add OneLinerFormatter to get semi-verbose logs with captured stdout/stderr
commit 984189537df99a6c55b058362047d272a5c59145
Author: Michael Edwards <michael edwards>
Date: 2018-11-22T12:07:38Z
ZOOKEEPER-3198: plumb BindException up to Leader and its peers
* Normalize bind failures to java.net.BindException in both implementation of ServerCnxnFactory
* Throw BindException out as far as the caller of QuorumPeer.processReconfig
* Catch BindException in tryToCommit(); the transaction needs to be committed
----
---
[GitHub] zookeeper issue #715: Rollup of blocker/critical fixes for 3.5 (to trigger C...
Posted by nkalmar <gi...@git.apache.org>.
Github user nkalmar commented on the issue:
https://github.com/apache/zookeeper/pull/715
Oh, so it's basically an aggregation of the flaky test fixes, I already seen some of your PR on them.
This is awesome, thanks for this!
---
[GitHub] zookeeper issue #715: Rollup of blocker/critical fixes for 3.5 (to trigger C...
Posted by mkedwards <gi...@git.apache.org>.
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/715
This is the branch where my colleague Eric Schwartz and I are trying to get
to a "zero flaky tests" standard. (It started as the branch where I worked
on ZOOKEEPER-2778, and grew from there.) The pull request is not really a
pull request any more; I was just still interested in what Jenkins makes of
the state of the branch. If anybody wants to go over with me what we've
done in this branch and why, I'd be *delighted* to discuss it. (We're down
to one test that needs a bit of work to restore the functional equivalent
of the log-grepping verification we ripped out so we could switch to the
log4j2 implementation of slf4j.)
On Tue, Dec 4, 2018, 6:54 AM Norbert Kalmar <notifications@github.com wrote:
> I'm not sure what this is. Do you have a corresponding jira?
>
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/zookeeper/pull/715#issuecomment-444127695>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AAzdsgFEKqCiQzKnr-K5s-2m6qTG7M2fks5u1oyzgaJpZM4YvOj3>
> .
>
---