You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/30 20:33:34 UTC
[GitHub] [airflow] nic314 opened a new pull request #13394: Add rest API to query for providers
nic314 opened a new pull request #13394:
URL: https://github.com/apache/airflow/pull/13394
closes: #12468
Added a new api rest endpoint in the stable api to query the installed providers. It provides the same information as the cli command "airflow providers list"
Note: There is some code duplication between provider_endpoint.py and provider_command.py regarding_remove_rst_syntax and the mapping, i kept it like this becouse i assume that in future its possible that the rest api and the cli returns different informations/fields but if that's not the case and the rest and cli will always return the same information then i can refactor my pr to avoid this duplication.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jhtimmins commented on pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
jhtimmins commented on pull request #13394:
URL: https://github.com/apache/airflow/pull/13394#issuecomment-833893844
@ephraimbuddy We can go ahead and merge, since this has targeted 2.1 and we're actively trying to get those PRs in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] nic314 commented on a change in pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
nic314 commented on a change in pull request #13394:
URL: https://github.com/apache/airflow/pull/13394#discussion_r627280826
##########
File path: tests/api_connexion/endpoints/test_provider_endpoint.py
##########
@@ -0,0 +1,127 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import unittest
+from collections import OrderedDict
+from unittest import mock
+
+from airflow.security import permissions
+from airflow.www import app
+from tests.test_utils.api_connexion_utils import create_user, delete_user
+from tests.test_utils.config import conf_vars
+
+MOCK_PROVIDERS = OrderedDict(
+ [
+ (
+ 'apache-airflow-providers-amazon',
+ (
+ '1.0.0',
+ {
+ 'package-name': 'apache-airflow-providers-amazon',
+ 'name': 'Amazon',
+ 'description': '`Amazon Web Services (AWS) <https://aws.amazon.com/>`__.\n',
+ 'versions': ['1.0.0'],
+ },
+ ),
+ ),
+ (
+ 'apache-airflow-providers-apache-cassandra',
+ (
+ '1.0.0',
+ {
+ 'package-name': 'apache-airflow-providers-apache-cassandra',
+ 'name': 'Apache Cassandra',
+ 'description': '`Apache Cassandra <http://cassandra.apache.org/>`__.\n',
+ 'versions': ['1.0.0'],
+ },
+ ),
+ ),
+ ]
+)
+
+
+class TestBaseProviderEndpoint(unittest.TestCase):
+ @classmethod
+ def setUpClass(cls) -> None:
+ with conf_vars({("api", "auth_backend"): "tests.test_utils.remote_user_api_auth_backend"}):
+ cls.app = app.create_app(testing=True) # type:ignore
+ create_user(
+ cls.app, # type:ignore
+ username="test",
+ role_name="Test",
+ permissions=[(permissions.ACTION_CAN_READ, permissions.RESOURCE_PROVIDER)], # type: ignore
+ )
+ create_user(cls.app, username="test_no_permissions", role_name="TestNoPermissions") # type: ignore
+
Review comment:
i will do asap, i think within today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jhtimmins commented on pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
jhtimmins commented on pull request #13394:
URL: https://github.com/apache/airflow/pull/13394#issuecomment-833920947
@potiuk Thanks for the heads up about master, I missed that it was failing.
As I understood it, Ephraim was asking whether we _actually_ wanted this to be included for 2.1. As I'm in the middle of working on the 2.1 release, and am currently making a list of what will get into the release versus pushed to a later one, I was confirming that this feature should be included. Since the release date is approaching, I was encouraging him to be proactive about getting it fully reviewed and merged, not to cut any corners in quality or good practices.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13394:
URL: https://github.com/apache/airflow/pull/13394#issuecomment-752989330
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13394:
URL: https://github.com/apache/airflow/pull/13394#issuecomment-834151801
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] nic314 commented on pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
nic314 commented on pull request #13394:
URL: https://github.com/apache/airflow/pull/13394#issuecomment-833291383
@jhtimmins I rebased, but the cicd needs some approval. Also i was assuming this was for the version 2.1, let me know is i need to change here https://github.com/apache/airflow/pull/13394/commits/c4c5a6f89df01b70bbc09535e6b7326107e6285e#diff-191056f40fba6bf5886956aa281e0e0d2bb4ddaa380beb012d922a25f5c65750R136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13394:
URL: https://github.com/apache/airflow/pull/13394#issuecomment-752989815
I think we should refrain from merging it until we agree on how we approach 2.0.1 with branching: https://github.com/apache/airflow/pull/13382#issuecomment-752570884
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13394:
URL: https://github.com/apache/airflow/pull/13394#issuecomment-752986077
Yep. We just merged a fix for that AWS batch. If f you could rebase the last time (I hope) that would be great!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13394:
URL: https://github.com/apache/airflow/pull/13394#issuecomment-833900985
I think so far in Airflow we were doing really well about avoiding the "not my problem" attitude.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] nic314 commented on a change in pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
nic314 commented on a change in pull request #13394:
URL: https://github.com/apache/airflow/pull/13394#discussion_r550496887
##########
File path: airflow/api_connexion/openapi/v1.yaml
##########
@@ -843,6 +843,26 @@ paths:
'404':
$ref: '#/components/responses/NotFound'
+ /providers:
Review comment:
I added a new line in that summary table, let me know if its fine .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] nic314 commented on pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
nic314 commented on pull request #13394:
URL: https://github.com/apache/airflow/pull/13394#issuecomment-752981581
@potiuk You mean the step in the CI that was failing? Or i missed to update some documentation files?
I rebased from master, now the only failure is in TestAwsBatchOperator but locally im able to reproduce the same failure on the master branch so i don't think that it's connected to this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] nic314 edited a comment on pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
nic314 edited a comment on pull request #13394:
URL: https://github.com/apache/airflow/pull/13394#issuecomment-834378831
looks like everything passedđź‘Ť
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13394:
URL: https://github.com/apache/airflow/pull/13394#issuecomment-834099710
Hey @nic314 - can you please rebase. I am also happy to merge it as soon as it is green!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13394:
URL: https://github.com/apache/airflow/pull/13394#issuecomment-834410419
Wohoo :tada: !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13394:
URL: https://github.com/apache/airflow/pull/13394#issuecomment-752799118
[The Workflow run](https://github.com/apache/airflow/actions/runs/453624949) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13394:
URL: https://github.com/apache/airflow/pull/13394#issuecomment-752940362
Docs also need to be fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] nic314 removed a comment on pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
nic314 removed a comment on pull request #13394:
URL: https://github.com/apache/airflow/pull/13394#issuecomment-752780231
i see that "build docs" and "Sqlite Py3.6: Always Core Other API CLI Providers WWW Integration Heisentests" failed, i tried locally to run those steps on the master branch and i have the same exact error, seems like they are not related to this PR.
My first PR though so i may be wrong :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #13394:
URL: https://github.com/apache/airflow/pull/13394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13394:
URL: https://github.com/apache/airflow/pull/13394#issuecomment-752767834
[The Workflow run](https://github.com/apache/airflow/actions/runs/453429028) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #13394:
URL: https://github.com/apache/airflow/pull/13394#issuecomment-833851833
> Looks good, but seems this is the first change to be merged that should be targeted to 2.1 so we need to decide how we approach it.
Hi @potiuk , is it time we merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13394:
URL: https://github.com/apache/airflow/pull/13394#issuecomment-833862181
[The Workflow run](https://github.com/apache/airflow/actions/runs/818176863) is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13394:
URL: https://github.com/apache/airflow/pull/13394#issuecomment-834410156
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] nic314 edited a comment on pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
nic314 edited a comment on pull request #13394:
URL: https://github.com/apache/airflow/pull/13394#issuecomment-833291383
@jhtimmins I rebased, but looks like the cicd needs some approval. Also i was assuming this was for the version 2.1, let me know is i need to change here https://github.com/apache/airflow/pull/13394/commits/c4c5a6f89df01b70bbc09535e6b7326107e6285e#diff-191056f40fba6bf5886956aa281e0e0d2bb4ddaa380beb012d922a25f5c65750R136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a change in pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on a change in pull request #13394:
URL: https://github.com/apache/airflow/pull/13394#discussion_r627243560
##########
File path: tests/api_connexion/endpoints/test_provider_endpoint.py
##########
@@ -0,0 +1,127 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import unittest
+from collections import OrderedDict
+from unittest import mock
+
+from airflow.security import permissions
+from airflow.www import app
+from tests.test_utils.api_connexion_utils import create_user, delete_user
+from tests.test_utils.config import conf_vars
+
+MOCK_PROVIDERS = OrderedDict(
+ [
+ (
+ 'apache-airflow-providers-amazon',
+ (
+ '1.0.0',
+ {
+ 'package-name': 'apache-airflow-providers-amazon',
+ 'name': 'Amazon',
+ 'description': '`Amazon Web Services (AWS) <https://aws.amazon.com/>`__.\n',
+ 'versions': ['1.0.0'],
+ },
+ ),
+ ),
+ (
+ 'apache-airflow-providers-apache-cassandra',
+ (
+ '1.0.0',
+ {
+ 'package-name': 'apache-airflow-providers-apache-cassandra',
+ 'name': 'Apache Cassandra',
+ 'description': '`Apache Cassandra <http://cassandra.apache.org/>`__.\n',
+ 'versions': ['1.0.0'],
+ },
+ ),
+ ),
+ ]
+)
+
+
+class TestBaseProviderEndpoint(unittest.TestCase):
+ @classmethod
+ def setUpClass(cls) -> None:
+ with conf_vars({("api", "auth_backend"): "tests.test_utils.remote_user_api_auth_backend"}):
+ cls.app = app.create_app(testing=True) # type:ignore
+ create_user(
+ cls.app, # type:ignore
+ username="test",
+ role_name="Test",
+ permissions=[(permissions.ACTION_CAN_READ, permissions.RESOURCE_PROVIDER)], # type: ignore
+ )
+ create_user(cls.app, username="test_no_permissions", role_name="TestNoPermissions") # type: ignore
+
Review comment:
A while ago, we made some changes to tests speedup. I'd appreciate a change of this test to use that. See https://github.com/apache/airflow/blob/b7b17641d0c17bfa5e1f8c77b9c232da73bbedcd/tests/api_connexion/endpoints/test_connection_endpoint.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13394:
URL: https://github.com/apache/airflow/pull/13394#issuecomment-834099319
> @potiuk Thanks for the heads up about master, I missed that it was failing.
>
> As I understood it, Ephraim was asking whether we _actually_ wanted this to be included for 2.1. As I'm in the middle of working on the 2.1 release, and am currently making a list of what will get into the release versus pushed to a later one, I was confirming that this feature should be included. Since the release date is approaching, I was encouraging him to be proactive about getting it fully reviewed and merged, not to cut any corners in quality or good practices.
Sorry then :). I misunderstood that - It looked as if we are hurrying now for unknown reason :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13394:
URL: https://github.com/apache/airflow/pull/13394#issuecomment-833900053
> @ephraimbuddy We can go ahead and merge, since this has targeted 2.1 and we're actively trying to get those PRs in.
I just reverted the offending PR (and asked the author to fix also the reason why (https://github.com/apache/airflow/pull/15703#issuecomment-833894099)
hey @jhtimmins - broken master happens from time to time for different reasons, so far we've been trying to fix such things (often by just pin-pointing and reverting such offending PRs'). I think we should keep doing it, Merging "quickly" something because we are in hurry is almost never a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jhtimmins commented on pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
jhtimmins commented on pull request #13394:
URL: https://github.com/apache/airflow/pull/13394#issuecomment-833201711
@kaxil @ephraimbuddy This looks good to me, but can y'all confirm that this is still good to go? If so, we can merge it tomorrow.
@nic314 Sorry this has been left in limbo for so long. Would you mind rebasing it onto master?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] nic314 commented on pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
nic314 commented on pull request #13394:
URL: https://github.com/apache/airflow/pull/13394#issuecomment-834378831
looks like everything passed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13394:
URL: https://github.com/apache/airflow/pull/13394#issuecomment-787209739
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #13394:
URL: https://github.com/apache/airflow/pull/13394
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13394:
URL: https://github.com/apache/airflow/pull/13394#discussion_r550363298
##########
File path: airflow/api_connexion/openapi/v1.yaml
##########
@@ -843,6 +843,26 @@ paths:
'404':
$ref: '#/components/responses/NotFound'
+ /providers:
Review comment:
Can you add this change to "Summary of changes"? http://apache-airflow-docs.s3-website.eu-central-1.amazonaws.com/docs/apache-airflow/latest/stable-rest-api-ref.html#section/Summary-of-Changes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13394:
URL: https://github.com/apache/airflow/pull/13394#issuecomment-752749710
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] nic314 commented on pull request #13394: Add rest API to query for providers
Posted by GitBox <gi...@apache.org>.
nic314 commented on pull request #13394:
URL: https://github.com/apache/airflow/pull/13394#issuecomment-752780231
i see that "build docs" and "Sqlite Py3.6: Always Core Other API CLI Providers WWW Integration Heisentests" failed, i tried locally to run those steps on the master branch and i have the same exact error, seems like they are not related to this PR.
My first PR though so i may be wrong :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org