You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by gx...@apache.org on 2019/10/24 09:10:19 UTC
[hbase] branch branch-1 updated: HBASE-23149
RatioBasedCompactionPolicy#shouldPerformMajorCompaction logic is not
correct (#744)
This is an automated email from the ASF dual-hosted git repository.
gxcheng pushed a commit to branch branch-1
in repository https://gitbox.apache.org/repos/asf/hbase.git
The following commit(s) were added to refs/heads/branch-1 by this push:
new 41f6713 HBASE-23149 RatioBasedCompactionPolicy#shouldPerformMajorCompaction logic is not correct (#744)
41f6713 is described below
commit 41f671336cec9122b09c42d1c827b822fc854c70
Author: Jacky Lau <li...@gmail.com>
AuthorDate: Thu Oct 24 16:56:48 2019 +0800
HBASE-23149 RatioBasedCompactionPolicy#shouldPerformMajorCompaction logic is not correct (#744)
Signed-off-by: Guangxu Cheng <gu...@gmail.com>
---
.../hbase/regionserver/compactions/RatioBasedCompactionPolicy.java | 2 +-
.../hadoop/hbase/regionserver/compactions/SortedCompactionPolicy.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/RatioBasedCompactionPolicy.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/RatioBasedCompactionPolicy.java
index 9e11ecf..4e7b506 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/RatioBasedCompactionPolicy.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/RatioBasedCompactionPolicy.java
@@ -105,8 +105,8 @@ public class RatioBasedCompactionPolicy extends SortedCompactionPolicy {
} else {
LOG.debug("Major compaction triggered on store " + regionInfo
+ "; time since last major compaction " + (now - lowTimestamp) + "ms");
+ result = true;
}
- result = true;
}
return result;
}
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/SortedCompactionPolicy.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/SortedCompactionPolicy.java
index 4e8c35a..e49ac93 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/SortedCompactionPolicy.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/SortedCompactionPolicy.java
@@ -120,7 +120,7 @@ public abstract class SortedCompactionPolicy extends CompactionPolicy {
* @return When to run next major compaction
*/
public long getNextMajorCompactTime(final Collection<StoreFile> filesToCompact) {
- // default = 24hrs
+ // default = 7days
long ret = comConf.getMajorCompactionPeriod();
if (ret > 0) {
// default = 20% = +/- 4.8 hrs