[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1785: Update Circuit Breaker configured as a standard plugin

[GitBox <gi...@apache.org>]

noblepaul commented on a change in pull request #1785:
URL: https://github.com/apache/lucene-solr/pull/1785#discussion_r477128165



##########
File path: solr/core/src/java/org/apache/solr/core/SolrCore.java
##########
@@ -1174,7 +1174,8 @@ private SolrCoreMetricManager initCoreMetricManager(SolrConfig config) {
   }
 
   private CircuitBreakerManager initCircuitBreakerManager() {
-    CircuitBreakerManager circuitBreakerManager = CircuitBreakerManager.build(solrConfig);
+    final PluginInfo info = solrConfig.getPluginInfo(CircuitBreakerManager.class.getName());
+    CircuitBreakerManager circuitBreakerManager = CircuitBreakerManager.build(info.initArgs);

Review comment:
       Make `CircuitBreakerManager` implement `PluginInfoInitialized`

##########
File path: solr/solr-ref-guide/src/query-settings-in-solrconfig.adoc
##########
@@ -172,24 +172,54 @@ This parameter sets the maximum number of documents to cache for any entry in th
 <queryResultMaxDocsCached>200</queryResultMaxDocsCached>
 ----
 
-=== useCircuitBreakers
+=== circuitBreaker
 
-Global control flag for enabling circuit breakers.
+This set of configurations control the behaviour of circuit breakers.
 
 [source,xml]
 ----
-<useCircuitBreakers>true</useCircuitBreakers>
+<circuitBreaker class="solr.CircuitBreakerManager">
+  <!-- All specific configs in this section -->
+</circuitBreaker>
 ----
 
-=== memoryCircuitBreakerThresholdPct
+To control whether Circuit Breakers are globally enabled, use the following flag:
+
+[source,xml]
+----
+<str name="enabled">true</str>

Review comment:
       standard syntax for enabled is 
   
   `<circuitBreaker class="solr.CircuitBreakerManager" enabled="true">`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org