You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ly...@apache.org on 2023/01/12 23:57:34 UTC
[superset] branch lyndsi/fix-alert-modal-spacing created (now a4f741f39f)
This is an automated email from the ASF dual-hosted git repository.
lyndsi pushed a change to branch lyndsi/fix-alert-modal-spacing
in repository https://gitbox.apache.org/repos/asf/superset.git
at a4f741f39f Fix spacing on StyledCheckbox, NotificationMethod, and .control-label
This branch includes the following new commits:
new a4f741f39f Fix spacing on StyledCheckbox, NotificationMethod, and .control-label
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[superset] 01/01: Fix spacing on StyledCheckbox, NotificationMethod, and .control-label
Posted by ly...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
lyndsi pushed a commit to branch lyndsi/fix-alert-modal-spacing
in repository https://gitbox.apache.org/repos/asf/superset.git
commit a4f741f39f0d68e0104b965708c763e994f0ffdb
Author: lyndsiWilliams <kc...@gmail.com>
AuthorDate: Thu Jan 12 17:57:03 2023 -0600
Fix spacing on StyledCheckbox, NotificationMethod, and .control-label
---
.../src/views/CRUD/alert/AlertReportModal.tsx | 37 +++++++++++++++-------
1 file changed, 25 insertions(+), 12 deletions(-)
diff --git a/superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx b/superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx
index 1b8a802fe7..74d9af7f44 100644
--- a/superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx
+++ b/superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx
@@ -171,6 +171,10 @@ const StyledSectionContainer = styled.div`
display: flex;
flex-direction: column;
+ .control-label {
+ margin-top: ${({ theme }) => theme.gridUnit}px;
+ }
+
.header-section {
display: flex;
flex: 0 0 auto;
@@ -339,6 +343,7 @@ const StyledRadioGroup = styled(Radio.Group)`
const StyledCheckbox = styled(AntdCheckbox)`
margin-left: ${({ theme }) => theme.gridUnit * 5.5}px;
+ margin-top: ${({ theme }) => theme.gridUnit}px;
`;
// Notification Method components
@@ -356,6 +361,12 @@ const StyledNotificationAddButton = styled.div`
}
`;
+const StyledNotificationMethodWrapper = styled.div`
+ .input-container {
+ margin-left: 0 !important;
+ }
+`;
+
const timezoneHeaderStyle = (theme: SupersetTheme) => css`
margin: ${theme.gridUnit * 3}px 0;
`;
@@ -1445,18 +1456,20 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
<span className="required">*</span>
</StyledSectionTitle>
{notificationSettings.map((notificationSetting, i) => (
- <NotificationMethod
- setting={notificationSetting}
- index={i}
- key={`NotificationMethod-${i}`}
- onUpdate={updateNotificationSetting}
- onRemove={removeNotificationSetting}
- css={css`
- .input-container {
- margin-left: 0;
- }
- `}
- />
+ <StyledNotificationMethodWrapper>
+ <NotificationMethod
+ setting={notificationSetting}
+ index={i}
+ key={`NotificationMethod-${i}`}
+ onUpdate={updateNotificationSetting}
+ onRemove={removeNotificationSetting}
+ css={css`
+ .input-container {
+ margin-left: 0 !important;
+ }
+ `}
+ />
+ </StyledNotificationMethodWrapper>
))}
<NotificationMethodAdd
data-test="notification-add"