[jira] [Commented] (S2GRAPH-39) Better exception message on converting between Json and InnerVal.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/S2GRAPH-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153882#comment-15153882 ] 

ASF GitHub Bot commented on S2GRAPH-39:
---------------------------------------

GitHub user SteamShon opened a pull request:

    https://github.com/apache/incubator-s2graph/pull/22

    [S2GRAPH-39] Better exception message on converting between Json and InnerVal.

    + think this is more clear exception message

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-39

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-s2graph/pull/22.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22
    
----
commit 1a9b2ef5319266b4ce37fa6f4f373a889e6f7647
Author: DO YUNG YOON <st...@apache.org>
Date:   2016-02-19T08:04:02Z

    S2GRAPH-39 Better exception message on converting between Json and InnerVal.

----


> Better exception message on converting between Json and InnerVal.
> -----------------------------------------------------------------
>
>                 Key: S2GRAPH-39
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-39
>             Project: S2Graph
>          Issue Type: Improvement
>            Reporter: DOYUNG YOON
>            Assignee: DOYUNG YOON
>            Priority: Trivial
>              Labels: Exception
>
> Currently, converting our inner class InnerVal into JSON is done by {{JSONParser}}.
> I think there is lack of information why Exception has been thrown when converting InnerVal into Json(see innerValToJsValue method).
> It would be better provide more informations as following.
> 1. what was the innerVal value we are trying to convert.
> 2. what was actual dataType of innerVal we are trying to convert.
> 3. what dataType this innerVal need to be converted into in Json.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)