Re: [PR] Cassandra 12937 - Default SSTable compression in yaml [cassandra]

["Claudenw (via GitHub)" <gi...@apache.org>]

Claudenw commented on code in PR #3168:
URL: https://github.com/apache/cassandra/pull/3168#discussion_r1547216866


##########
src/java/org/apache/cassandra/schema/TableParams.java:
##########
@@ -490,6 +490,11 @@ public Builder extensions(Map<String, ByteBuffer> val)
 
     public static class Serializer implements MetadataSerializer<TableParams>
     {
+        private final String keyspace;

Review Comment:
   `TableParams.Serializer` requires the keyspace for the deserialization method to call the `builder.build(keyspace)` method.  Since `TableParams.Serializer` implements `MetadataSerializer<TableParams>` we would have to change the signature of `deserialize` on all `MetadataSerializer` implementations.  I think this is a far worse idea than having `new TableParams.Serializer(keyspace)` called  in various places.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org