[jira] [Commented] (BOOKKEEPER-836) disable compaction when disk becomes full, otherwise compaction will fill up disk quickly

["Sijie Guo (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358227#comment-14358227 ] 

Sijie Guo commented on BOOKKEEPER-836:
--------------------------------------

if the disk space hitting critical threshold, the bookie would be turned to readonly. so there won't be new data written to this bookie. so the bookie will wait old data (old ledgers to be deleted) to be garbage collected to reclaim disk space.

in most of the cases, the liveness of ledgers are short. so deleting ledgers (deleting whole entry log files) is the major contribution on reclaiming disk spaces, not compaction. 

> disable compaction when disk becomes full, otherwise compaction will fill up disk quickly
> -----------------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-836
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-836
>             Project: Bookkeeper
>          Issue Type: Improvement
>          Components: bookkeeper-server
>    Affects Versions: 4.2.3
>            Reporter: Jia Zhai
>            Assignee: Jia Zhai
>             Fix For: 4.4.0, 4.3.2
>
>         Attachments: BOOKKEEPER-836-v2.patch, BOOKKEEPER-836.patch
>
>
> In doCompactEntryLogs, Entries are added to new logs, while all old logs were not released until the end of handling.  So during the process, a lot of space will be used. Need to disable compaction when disk becomes full, otherwise compaction will fill up disk quickly.
> I would like to change old "forced garbage collection" logic, and suspend major compaction when it reaches warn threshold, suspend minor compaction when it reaches critical threshold.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)