You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by ch...@apache.org on 2022/07/06 07:11:50 UTC

[flink] 01/02: [FLINK-26979][core] Make Transformation#getNewNodeId() thread-safe

This is an automated email from the ASF dual-hosted git repository.

chesnay pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git

commit 8d548d683dbb005ee75cf07f99fc014901c0c94a
Author: Shubham Bansal <il...@gmail.com>
AuthorDate: Sat Jun 18 00:19:02 2022 -0700

    [FLINK-26979][core] Make Transformation#getNewNodeId() thread-safe
---
 .../src/main/java/org/apache/flink/api/dag/Transformation.java      | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/flink-core/src/main/java/org/apache/flink/api/dag/Transformation.java b/flink-core/src/main/java/org/apache/flink/api/dag/Transformation.java
index 0d30b17e155..afb21fbbbc8 100644
--- a/flink-core/src/main/java/org/apache/flink/api/dag/Transformation.java
+++ b/flink-core/src/main/java/org/apache/flink/api/dag/Transformation.java
@@ -37,6 +37,7 @@ import java.util.List;
 import java.util.Map;
 import java.util.Optional;
 import java.util.Set;
+import java.util.concurrent.atomic.AtomicInteger;
 
 import static org.apache.flink.util.Preconditions.checkArgument;
 import static org.apache.flink.util.Preconditions.checkNotNull;
@@ -108,11 +109,10 @@ public abstract class Transformation<T> {
     public static final int UPPER_BOUND_MAX_PARALLELISM = 1 << 15;
 
     // This is used to assign a unique ID to every Transformation
-    protected static Integer idCounter = 0;
+    private static final AtomicInteger ID_COUNTER = new AtomicInteger(0);
 
     public static int getNewNodeId() {
-        idCounter++;
-        return idCounter;
+        return ID_COUNTER.incrementAndGet();
     }
 
     protected final int id;