You are viewing a plain text version of this content. The canonical link for it is here.
Posted to websh-dev@tcl.apache.org by "David N. Welton" <da...@dedasys.com> on 2002/02/15 13:17:29 UTC
remaining source code issues
Should the recently committed changes be acceptable, there are just a
few things left off of the bug list to do in the actual source code:
Decide what to do about {=. I don't like it much, myself.
Decide what to do about attempting to catch blocks of code in
'putx'.
Beyond that, what else is there to do before we are ready to freeze
the source code? There are a number of fixme's in the sources - are
there any of them that should be given priority?
--
David N. Welton
Consulting: http://www.dedasys.com/
Personal: http://www.dedasys.com/davidw/
Free Software: http://www.dedasys.com/freesoftware/
Apache Tcl: http://tcl.apache.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: websh-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: websh-dev-help@tcl.apache.org
Re: remaining source code issues
Posted by Ronnie Brunner <ro...@netcetera.ch>.
> It might be nice to create a utility proc for the if {[catch
> .... idiom. That gives people a simple wrapper to use without
> cluttering up their code too much. How about:
>
> proc docatch {code {errmsg "Error occured: $err"}} {
> if { [catch {
> uplevel $code
> } err] } {
> puts [subst -nobackslashes -nocommands "$errmsg"]
> }
> }
Yes, but I wouldn't even bother to put it somewhere now. Maybe in th
future we'll have something like a HOWTO collection for such things.
I'd really like to keep it as simple as possible at this time. (Every
line we can trow out of the code is an improvment.)
Ronnie
------------------------------------------------------------------------
Ronnie Brunner ronnie.brunner@netcetera.ch
Netcetera AG, 8040 Zuerich phone +41 1 247 79 79 Fax: +41 1 247 70 75
---------------------------------------------------------------------
To unsubscribe, e-mail: websh-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: websh-dev-help@tcl.apache.org
Re: remaining source code issues
Posted by "David N. Welton" <da...@dedasys.com>.
Ronnie Brunner <ro...@netcetera.ch> writes:
> > Should the recently committed changes be acceptable, there are
> > just a few things left off of the bug list to do in the actual
> > source code:
> > Decide what to do about {=. I don't like it much, myself.
> I'd throw it out. The same can be achieved with
> proc = {msg} {web::put $msg}
> so there is no added value in it, just more code and exceptions and
> stuff.
Ok, sounds good to me.
> > Decide what to do about attempting to catch blocks of code in
> > 'putx'.
> After thinking about it for a while, I tend to agree with David: let
> the developer care. if he doesn't want a code block to crash, he's
> got to catch it and react properly {if {[catch {do somthing
> stupid}]} {web::put "I'm sorry"}}. -> putx should just normaly
> return as soon as there is an uncaught error.
It might be nice to create a utility proc for the if {[catch
.... idiom. That gives people a simple wrapper to use without
cluttering up their code too much. How about:
proc docatch {code {errmsg "Error occured: $err"}} {
if { [catch {
uplevel $code
} err] } {
puts [subst -nobackslashes -nocommands "$errmsg"]
}
}
> > Beyond that, what else is there to do before we are ready to
> > freeze the source code? There are a number of fixme's in the
> > sources - are there any of them that should be given priority?
> It seems there are still tons of fixmes in the mod_websh part of the
> code. I think we should make sure that the most important one of
> those are fixed: i.e. have a reliable mod_websh for the release. (I
> haven't looked at them very specifically yet.)
I have been looking through them some, but any triage you can provide
will be helpful.
> I'd like to look at some issues when you David are in Zurich next
> week: I'll opt for the code freeze after your visit. (But what ever
> you can do before that -> all the better.)
Ok.
Ciao,
--
David N. Welton
Consulting: http://www.dedasys.com/
Personal: http://www.dedasys.com/davidw/
Free Software: http://www.dedasys.com/freesoftware/
Apache Tcl: http://tcl.apache.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: websh-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: websh-dev-help@tcl.apache.org
Re: remaining source code issues
Posted by Ronnie Brunner <ro...@netcetera.ch>.
> Should the recently committed changes be acceptable, there are just a
> few things left off of the bug list to do in the actual source code:
>
> Decide what to do about {=. I don't like it much, myself.
I'd throw it out. The same can be achieved with
proc = {msg} {web::put $msg}
so there is no added value in it, just more code and exceptions and stuff.
> Decide what to do about attempting to catch blocks of code in
> 'putx'.
After thinking about it for a while, I tend to agree with David: let
the developer care. if he doesn't want a code block to crash, he's got
to catch it and react properly {if {[catch {do somthing stupid}]}
{web::put "I'm sorry"}}. -> putx should just normaly return as soon as
there is an uncaught error.
> Beyond that, what else is there to do before we are ready to freeze
> the source code? There are a number of fixme's in the sources - are
> there any of them that should be given priority?
It seems there are still tons of fixmes in the mod_websh part of the
code. I think we should make sure that the most important one of those
are fixed: i.e. have a reliable mod_websh for the release. (I haven't
looked at them very specifically yet.)
I'd like to look at some issues when you David are in Zurich next
week: I'll opt for the code freeze after your visit. (But what ever
you can do before that -> all the better.)
Ronnie
------------------------------------------------------------------------
Ronnie Brunner ronnie.brunner@netcetera.ch
Netcetera AG, 8040 Zuerich phone +41 1 247 79 79 Fax: +41 1 247 70 75
---------------------------------------------------------------------
To unsubscribe, e-mail: websh-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: websh-dev-help@tcl.apache.org