You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/01/28 06:16:12 UTC
[GitHub] [hive] dengzhhu653 opened a new pull request #1920: HIVE-24694: Early connection close to release server resources during creating
dengzhhu653 opened a new pull request #1920:
URL: https://github.com/apache/hive/pull/1920
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on a change in pull request #1920: HIVE-24694: Early connection close to release server resources during creating
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on a change in pull request #1920:
URL: https://github.com/apache/hive/pull/1920#discussion_r565991791
##########
File path: jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java
##########
@@ -357,6 +357,15 @@ public HiveConnection(String uri, Properties info) throws SQLException {
}
if (numRetries >= maxRetries) {
+ try {
Review comment:
I was looking around and made the following notices:
* this check only occurs right before we throw the exception out
* what will happen with opened connection in between retries?
* it seems to me that `openTransport` does a check on the transport that is open or not - but it creates a new transport anyway; so I assume the driver will open a fresh connection for every try
I'm thinking the following:
* what do you think about closing the connection after a failed attempt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on a change in pull request #1920: HIVE-24694: Early connection close to release server resources during creating
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on a change in pull request #1920:
URL: https://github.com/apache/hive/pull/1920#discussion_r565992943
##########
File path: jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java
##########
@@ -357,6 +357,15 @@ public HiveConnection(String uri, Properties info) throws SQLException {
}
if (numRetries >= maxRetries) {
+ try {
+ // Cleaning up the server resources early
+ if (!isClosed) {
+ // close the session
+ close();
+ } else if (transport != null) {
+ transport.close();
+ }
Review comment:
I think you could also extend the close to be sure to close the transport if that's the only one open
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk merged pull request #1920: HIVE-24694: Early connection close to release server resources during creating
Posted by GitBox <gi...@apache.org>.
kgyrtkirk merged pull request #1920:
URL: https://github.com/apache/hive/pull/1920
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 closed pull request #1920: HIVE-24694: Early connection close to release server resources during creating
Posted by GitBox <gi...@apache.org>.
dengzhhu653 closed pull request #1920:
URL: https://github.com/apache/hive/pull/1920
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 closed pull request #1920: HIVE-24694: Early connection close to release server resources during creating
Posted by GitBox <gi...@apache.org>.
dengzhhu653 closed pull request #1920:
URL: https://github.com/apache/hive/pull/1920
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on a change in pull request #1920: HIVE-24694: Early connection close to release server resources during creating
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on a change in pull request #1920:
URL: https://github.com/apache/hive/pull/1920#discussion_r566793055
##########
File path: jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java
##########
@@ -1104,18 +1102,18 @@ public void clearWarnings() throws SQLException {
@Override
public void close() throws SQLException {
- if (!isClosed) {
- TCloseSessionReq closeReq = new TCloseSessionReq(sessHandle);
try {
- client.CloseSession(closeReq);
+ if (!isClosed) {
+ TCloseSessionReq closeReq = new TCloseSessionReq(sessHandle);
+ client.CloseSession(closeReq);
+ }
} catch (TException e) {
throw new SQLException("Error while cleaning up the server resources", e);
} finally {
isClosed = true;
- if (transport != null) {
+ if (transport != null && transport.isOpen()) {
transport.close();
}
Review comment:
can we release the references as well?
```
transport=null
client=null
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on a change in pull request #1920: HIVE-24694: Early connection close to release server resources during creating
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on a change in pull request #1920:
URL: https://github.com/apache/hive/pull/1920#discussion_r566000251
##########
File path: jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java
##########
@@ -357,6 +357,15 @@ public HiveConnection(String uri, Properties info) throws SQLException {
}
if (numRetries >= maxRetries) {
+ try {
Review comment:
yes, you're right. Thanks very much for the advice and comments!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk merged pull request #1920: HIVE-24694: Early connection close to release server resources during creating
Posted by GitBox <gi...@apache.org>.
kgyrtkirk merged pull request #1920:
URL: https://github.com/apache/hive/pull/1920
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on a change in pull request #1920: HIVE-24694: Early connection close to release server resources during creating
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on a change in pull request #1920:
URL: https://github.com/apache/hive/pull/1920#discussion_r566839416
##########
File path: jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java
##########
@@ -1104,18 +1102,18 @@ public void clearWarnings() throws SQLException {
@Override
public void close() throws SQLException {
- if (!isClosed) {
- TCloseSessionReq closeReq = new TCloseSessionReq(sessHandle);
try {
- client.CloseSession(closeReq);
+ if (!isClosed) {
+ TCloseSessionReq closeReq = new TCloseSessionReq(sessHandle);
+ client.CloseSession(closeReq);
+ }
} catch (TException e) {
throw new SQLException("Error while cleaning up the server resources", e);
} finally {
isClosed = true;
- if (transport != null) {
+ if (transport != null && transport.isOpen()) {
transport.close();
}
Review comment:
done and add some pre-checks on the connection state to avoid potential NPE
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org